All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tobias Schramm <t.schramm@manjaro.org>
To: Paul Fertser <fercerpav@gmail.com>, Martin Ashby <martin@ashbysoft.com>
Cc: t.schramm@manjaro.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] power: supply: cw2015: Add CHARGE_NOW support
Date: Sat, 19 Jun 2021 11:52:34 +0200	[thread overview]
Message-ID: <8390c743-e4a4-bf1d-457e-2bfdcf9143d2@manjaro.org> (raw)
In-Reply-To: <20210618123017.GA10695@home.paul.comp>

Hi all,

Am 18.06.21 um 14:30 schrieb Paul Fertser:
...
> 
> Are you sure the chip reports current state of charge relative to the
> full design capacity rather than to the latest auto-calibrated full
> capacity? That would mean that over time as the cells wear out
> cw_bat->soc (PROP_CAPACITY) is never going to be reaching 100; does
> this match your experience?
> 
As far as I'm aware the gauge reports SoC relative to what it believes 
to be the the current, auto-calibrated full battery capacity.
However, since I don't know how to extract that value from the gauge we 
just always assume it to be the design capacity [1].
Since we inquire the gauge about current SoC directly [2] there is no 
way for any miscalculation on our end preventing it from reaching 100%.

Cheers,
Tobias

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/power/supply/cw2015_battery.c#n507

[2] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/power/supply/cw2015_battery.c#n368

  reply	other threads:[~2021-06-19  9:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18 12:42 [PATCH] power: supply: cw2015: Add CHARGE_NOW support Martin Ashby
2021-02-18 14:53 ` Tobias Schramm
2021-06-18 12:30 ` Paul Fertser
2021-06-19  9:52   ` Tobias Schramm [this message]
2021-06-19 10:21     ` Paul Fertser
2021-06-19 13:48       ` Tobias Schramm
2021-06-19 19:06         ` Paul Fertser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8390c743-e4a4-bf1d-457e-2bfdcf9143d2@manjaro.org \
    --to=t.schramm@manjaro.org \
    --cc=fercerpav@gmail.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=martin@ashbysoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.