From: Daniel Borkmann <daniel@iogearbox.net>
To: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>,
Alexei Starovoitov <ast@kernel.org>,
John Fastabend <john.fastabend@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf-next v4 0/5] fix test_sockmap
Date: Sat, 2 Jun 2018 06:16:05 +0200 [thread overview]
Message-ID: <839ad376-9719-0649-e821-e05568aa1145@iogearbox.net> (raw)
In-Reply-To: <20180531044240.796-1-bhole_prashant_q7@lab.ntt.co.jp>
On 05/31/2018 06:42 AM, Prashant Bhole wrote:
> test_sockmap was originally written only to exercise kernel code
> paths, so there was no strict checking of errors. When the code was
> modified to run as selftests, due to lack of error handling it was not
> able to detect test failures.
>
> In order to improve, this series fixes error handling, test run time
> and data verification.
>
> Also slightly improved test output by printing parameter values (cork,
> apply, start, end) so that parameters for all tests are displayed.
>
> Changes in v4:
> - patch1: Ignore RX timoute error only for corked tests
> - patch3: Setting different timeout for corked tests and reduce
> run time by reducing number of iterations in some tests
>
> Changes in v3:
> - Skipped error checking for corked tests
>
> Prashant Bhole (5):
> selftests/bpf: test_sockmap, check test failure
> selftests/bpf: test_sockmap, join cgroup in selftest mode
> selftests/bpf: test_sockmap, timing improvements
> selftests/bpf: test_sockmap, fix data verification
> selftests/bpf: test_sockmap, print additional test options
>
> tools/testing/selftests/bpf/test_sockmap.c | 87 +++++++++++++++++-----
> 1 file changed, 67 insertions(+), 20 deletions(-)
>
Applied to bpf-next, thanks Prashant!
WARNING: multiple messages have this Message-ID (diff)
From: daniel at iogearbox.net (Daniel Borkmann)
Subject: [PATCH bpf-next v4 0/5] fix test_sockmap
Date: Sat, 2 Jun 2018 06:16:05 +0200 [thread overview]
Message-ID: <839ad376-9719-0649-e821-e05568aa1145@iogearbox.net> (raw)
In-Reply-To: <20180531044240.796-1-bhole_prashant_q7@lab.ntt.co.jp>
On 05/31/2018 06:42 AM, Prashant Bhole wrote:
> test_sockmap was originally written only to exercise kernel code
> paths, so there was no strict checking of errors. When the code was
> modified to run as selftests, due to lack of error handling it was not
> able to detect test failures.
>
> In order to improve, this series fixes error handling, test run time
> and data verification.
>
> Also slightly improved test output by printing parameter values (cork,
> apply, start, end) so that parameters for all tests are displayed.
>
> Changes in v4:
> - patch1: Ignore RX timoute error only for corked tests
> - patch3: Setting different timeout for corked tests and reduce
> run time by reducing number of iterations in some tests
>
> Changes in v3:
> - Skipped error checking for corked tests
>
> Prashant Bhole (5):
> selftests/bpf: test_sockmap, check test failure
> selftests/bpf: test_sockmap, join cgroup in selftest mode
> selftests/bpf: test_sockmap, timing improvements
> selftests/bpf: test_sockmap, fix data verification
> selftests/bpf: test_sockmap, print additional test options
>
> tools/testing/selftests/bpf/test_sockmap.c | 87 +++++++++++++++++-----
> 1 file changed, 67 insertions(+), 20 deletions(-)
>
Applied to bpf-next, thanks Prashant!
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: daniel@iogearbox.net (Daniel Borkmann)
Subject: [PATCH bpf-next v4 0/5] fix test_sockmap
Date: Sat, 2 Jun 2018 06:16:05 +0200 [thread overview]
Message-ID: <839ad376-9719-0649-e821-e05568aa1145@iogearbox.net> (raw)
Message-ID: <20180602041605.tUHO5biCSm0YWVYzjuKE3BWqDFRQqhiJq_NR1_czr9I@z> (raw)
In-Reply-To: <20180531044240.796-1-bhole_prashant_q7@lab.ntt.co.jp>
On 05/31/2018 06:42 AM, Prashant Bhole wrote:
> test_sockmap was originally written only to exercise kernel code
> paths, so there was no strict checking of errors. When the code was
> modified to run as selftests, due to lack of error handling it was not
> able to detect test failures.
>
> In order to improve, this series fixes error handling, test run time
> and data verification.
>
> Also slightly improved test output by printing parameter values (cork,
> apply, start, end) so that parameters for all tests are displayed.
>
> Changes in v4:
> - patch1: Ignore RX timoute error only for corked tests
> - patch3: Setting different timeout for corked tests and reduce
> run time by reducing number of iterations in some tests
>
> Changes in v3:
> - Skipped error checking for corked tests
>
> Prashant Bhole (5):
> selftests/bpf: test_sockmap, check test failure
> selftests/bpf: test_sockmap, join cgroup in selftest mode
> selftests/bpf: test_sockmap, timing improvements
> selftests/bpf: test_sockmap, fix data verification
> selftests/bpf: test_sockmap, print additional test options
>
> tools/testing/selftests/bpf/test_sockmap.c | 87 +++++++++++++++++-----
> 1 file changed, 67 insertions(+), 20 deletions(-)
>
Applied to bpf-next, thanks Prashant!
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-06-02 4:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 4:42 [PATCH bpf-next v4 0/5] fix test_sockmap Prashant Bhole
2018-05-31 4:42 ` Prashant Bhole
2018-05-31 4:42 ` bhole_prashant_q7
2018-05-31 4:42 ` [PATCH bpf-next v4 1/5] selftests/bpf: test_sockmap, check test failure Prashant Bhole
2018-05-31 4:42 ` Prashant Bhole
2018-05-31 4:42 ` bhole_prashant_q7
2018-06-01 14:04 ` John Fastabend
2018-06-01 14:04 ` John Fastabend
2018-06-01 14:04 ` john.fastabend
2018-05-31 4:42 ` [PATCH bpf-next v4 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode Prashant Bhole
2018-05-31 4:42 ` Prashant Bhole
2018-05-31 4:42 ` bhole_prashant_q7
2018-05-31 4:42 ` [PATCH bpf-next v4 3/5] selftests/bpf: test_sockmap, timing improvements Prashant Bhole
2018-05-31 4:42 ` Prashant Bhole
2018-05-31 4:42 ` bhole_prashant_q7
2018-06-01 14:11 ` John Fastabend
2018-06-01 14:11 ` John Fastabend
2018-06-01 14:11 ` john.fastabend
2018-05-31 4:42 ` [PATCH bpf-next v4 4/5] selftests/bpf: test_sockmap, fix data verification Prashant Bhole
2018-05-31 4:42 ` Prashant Bhole
2018-05-31 4:42 ` bhole_prashant_q7
2018-05-31 4:42 ` [PATCH bpf-next v4 5/5] selftests/bpf: test_sockmap, print additional test options Prashant Bhole
2018-05-31 4:42 ` Prashant Bhole
2018-05-31 4:42 ` bhole_prashant_q7
2018-06-02 4:16 ` Daniel Borkmann [this message]
2018-06-02 4:16 ` [PATCH bpf-next v4 0/5] fix test_sockmap Daniel Borkmann
2018-06-02 4:16 ` daniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=839ad376-9719-0649-e821-e05568aa1145@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=bhole_prashant_q7@lab.ntt.co.jp \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.