From mboxrd@z Thu Jan 1 00:00:00 1970 From: Schrempf Frieder Date: Wed, 11 Dec 2019 11:54:45 +0000 Subject: [U-Boot] [PATCH] net: eth-uclass: Remove warning about ROM MAC address In-Reply-To: <20191010230048.10935-1-smoch@web.de> References: <20191010230048.10935-1-smoch@web.de> Message-ID: <839d0375-1e90-6455-3c30-829011e9abe5@kontron.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11.10.19 01:00, Soeren Moch wrote: > Using a MAC address from ROM storage is the normal case for most > ethernet hardware. Why should we warn about this? > > Signed-off-by: Soeren Moch Some months ago I came up with the very same patch and I currently have it in my local fork with the description "Reading the MAC address from ROM is often a standard use case and should not produce a warning". Therefore I'm supporting Soeren's and Fabio's point of view here and I'm in favor of merging this patch or if preferred, change the printf() to debug(). Reviewed-by: Frieder Schrempf > --- > Cc: Joe Hershberger > Cc: u-boot at lists.denx.de > --- > net/eth-uclass.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/net/eth-uclass.c b/net/eth-uclass.c > index 3bd98b01ad..8b29de37bb 100644 > --- a/net/eth-uclass.c > +++ b/net/eth-uclass.c > @@ -538,8 +538,6 @@ static int eth_post_probe(struct udevice *dev) > memcpy(pdata->enetaddr, env_enetaddr, ARP_HLEN); > } else if (is_valid_ethaddr(pdata->enetaddr)) { > eth_env_set_enetaddr_by_index("eth", dev->seq, pdata->enetaddr); > - printf("\nWarning: %s using MAC address from ROM\n", > - dev->name); > } else if (is_zero_ethaddr(pdata->enetaddr) || > !is_valid_ethaddr(pdata->enetaddr)) { > #ifdef CONFIG_NET_RANDOM_ETHADDR > -- > 2.17.1 > > _______________________________________________ > U-Boot mailing list > U-Boot at lists.denx.de > https://lists.denx.de/listinfo/u-boot >