Re: [PATCH] drm/i915: request ring to be pinned above GUC_WOPCM_TOP

From: "Srivatsa, Anusha" <anusha.srivatsa@intel.com>
To: "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: request ring to be pinned above GUC_WOPCM_TOP
Date: Thu, 22 Dec 2016 20:58:22 +0000	[thread overview]
Message-ID: <83F5C7385F545743AD4FB2A62F75B0730195AEE4@ORSMSX108.amr.corp.intel.com> (raw)
In-Reply-To: <1482436502-7965-1-git-send-email-daniele.ceraolospurio@intel.com>


>-----Original Message-----
>From: Ceraolo Spurio, Daniele
>Sent: Thursday, December 22, 2016 11:55 AM
>To: intel-gfx@lists.freedesktop.org
>Cc: Ceraolo Spurio, Daniele <daniele.ceraolospurio@intel.com>; Chris Wilson
><chris@chris-wilson.co.uk>; Wajdeczko, Michal <Michal.Wajdeczko@intel.com>;
>Hiler, Arkadiusz <arkadiusz.hiler@intel.com>; Srivatsa, Anusha
><anusha.srivatsa@intel.com>; Winiarski, Michal <michal.winiarski@intel.com>
>Subject: [PATCH] drm/i915: request ring to be pinned above GUC_WOPCM_TOP
>
>From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>
>GuC will validate the ring offset and fail if it is in the [0, GUC_WOPCM_TOP)
>range.
>
>Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>Cc: Chris Wilson <chris@chris-wilson.co.uk>
>Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
>Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
>Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
>Cc: Michał Winiarski <michal.winiarski@intel.com>
Tested-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>---
> drivers/gpu/drm/i915/intel_ringbuffer.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c
>b/drivers/gpu/drm/i915/intel_ringbuffer.c
>index 69ccf4f..8f97b2e 100644
>--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
>+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
>@@ -1807,8 +1807,11 @@ static int init_phys_status_page(struct
>intel_engine_cs *engine)
>
> int intel_ring_pin(struct intel_ring *ring)  {
>-	/* Ring wraparound at offset 0 sometimes hangs. No idea why. */
>-	unsigned int flags = PIN_GLOBAL | PIN_OFFSET_BIAS | 4096;
>+	/* Need a bias for 2 reasons:
>+	 * 1: ring wraparound at offset 0 sometimes hangs. No idea why.
>+	 * 2: GuC requires the ring to be placed above GUC_WOPCM_TOP
>+	 */
>+	unsigned int flags = PIN_GLOBAL | PIN_OFFSET_BIAS |
>GUC_WOPCM_TOP;
> 	enum i915_map_type map;
> 	struct i915_vma *vma = ring->vma;
> 	void *addr;
>--
>1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx