All of lore.kernel.org
 help / color / mirror / Atom feed
* [CI v2 1/2] drm/i915/guc: Update GuC power domain states
@ 2018-09-10 10:41 Michal Wajdeczko
  2018-09-10 10:41 ` [CI v2 2/2] HAX Switch off GuC submission even if explicitly enabled Michal Wajdeczko
                   ` (6 more replies)
  0 siblings, 7 replies; 10+ messages in thread
From: Michal Wajdeczko @ 2018-09-10 10:41 UTC (permalink / raw)
  To: intel-gfx

We should update GuC power domain states also when GuC submission
is disabled, otherwise GuC might complain or ignore our requests.
This seems to be required for all currently released GuC firmwares.

v2: it is only needed by pre-Gen11 firmwares

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: John Spotswood <john.a.spotswood@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: Tomasz Lis <tomasz.lis@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
---
 drivers/gpu/drm/i915/intel_uc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
index 7c95697..b1b3e81 100644
--- a/drivers/gpu/drm/i915/intel_uc.c
+++ b/drivers/gpu/drm/i915/intel_uc.c
@@ -401,6 +401,10 @@ int intel_uc_init_hw(struct drm_i915_private *i915)
 		ret = intel_guc_submission_enable(guc);
 		if (ret)
 			goto err_communication;
+	} else if (INTEL_GEN(i915) < 11) {
+		ret = intel_guc_sample_forcewake(guc);
+		if (ret)
+			goto err_communication;
 	}
 
 	dev_info(i915->drm.dev, "GuC firmware version %u.%u\n",
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [CI v2 2/2] HAX Switch off GuC submission even if explicitly enabled
  2018-09-10 10:41 [CI v2 1/2] drm/i915/guc: Update GuC power domain states Michal Wajdeczko
@ 2018-09-10 10:41 ` Michal Wajdeczko
  2018-09-10 15:12 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,v2,1/2] drm/i915/guc: Update GuC power domain states Patchwork
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 10+ messages in thread
From: Michal Wajdeczko @ 2018-09-10 10:41 UTC (permalink / raw)
  To: intel-gfx

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
 drivers/gpu/drm/i915/intel_uc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
index b1b3e81..ad659c1 100644
--- a/drivers/gpu/drm/i915/intel_uc.c
+++ b/drivers/gpu/drm/i915/intel_uc.c
@@ -157,6 +157,9 @@ static void sanitize_options_early(struct drm_i915_private *i915)
 			 yesno(GUC_LOG_LEVEL_IS_VERBOSE(i915_modparams.guc_log_level)),
 			 GUC_LOG_LEVEL_TO_VERBOSITY(i915_modparams.guc_log_level));
 
+	/* HAX: Never allow GuC submission */
+	i915_modparams.enable_guc &= ~ENABLE_GUC_SUBMISSION;
+
 	/* Make sure that sanitization was done */
 	GEM_BUG_ON(i915_modparams.enable_guc < 0);
 	GEM_BUG_ON(i915_modparams.guc_log_level < 0);
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,v2,1/2] drm/i915/guc: Update GuC power domain states
  2018-09-10 10:41 [CI v2 1/2] drm/i915/guc: Update GuC power domain states Michal Wajdeczko
  2018-09-10 10:41 ` [CI v2 2/2] HAX Switch off GuC submission even if explicitly enabled Michal Wajdeczko
@ 2018-09-10 15:12 ` Patchwork
  2018-09-10 15:30 ` ✗ Fi.CI.BAT: failure " Patchwork
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2018-09-10 15:12 UTC (permalink / raw)
  To: Michal Wajdeczko; +Cc: intel-gfx

== Series Details ==

Series: series starting with [CI,v2,1/2] drm/i915/guc: Update GuC power domain states
URL   : https://patchwork.freedesktop.org/series/49423/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
d0f85704c2c0 drm/i915/guc: Update GuC power domain states
1ad52148da5f HAX Switch off GuC submission even if explicitly enabled
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 9 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread

* ✗ Fi.CI.BAT: failure for series starting with [CI,v2,1/2] drm/i915/guc: Update GuC power domain states
  2018-09-10 10:41 [CI v2 1/2] drm/i915/guc: Update GuC power domain states Michal Wajdeczko
  2018-09-10 10:41 ` [CI v2 2/2] HAX Switch off GuC submission even if explicitly enabled Michal Wajdeczko
  2018-09-10 15:12 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,v2,1/2] drm/i915/guc: Update GuC power domain states Patchwork
@ 2018-09-10 15:30 ` Patchwork
  2018-09-10 15:34 ` [CI v2 1/2] " Chris Wilson
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2018-09-10 15:30 UTC (permalink / raw)
  To: Michal Wajdeczko; +Cc: intel-gfx

== Series Details ==

Series: series starting with [CI,v2,1/2] drm/i915/guc: Update GuC power domain states
URL   : https://patchwork.freedesktop.org/series/49423/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4792 -> Patchwork_10134 =

== Summary - FAILURE ==

  Serious unknown changes coming with Patchwork_10134 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_10134, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49423/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_10134:

  === IGT changes ===

    ==== Possible regressions ====

    igt@drv_selftest@live_contexts:
      fi-bsw-n3050:       PASS -> DMESG-WARN

    
== Known issues ==

  Here are the changes found in Patchwork_10134 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
      fi-skl-guc:         PASS -> FAIL (fdo#103191)

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
      fi-byt-clapper:     PASS -> FAIL (fdo#107362)

    igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
      fi-byt-clapper:     PASS -> FAIL (fdo#107362, fdo#103191)

    igt@kms_psr@primary_page_flip:
      fi-cnl-psr:         PASS -> FAIL (fdo#107336)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_guc:
      fi-skl-guc:         DMESG-WARN (fdo#107258) -> PASS
      fi-kbl-guc:         DMESG-WARN (fdo#107258) -> PASS

    igt@drv_selftest@live_hangcheck:
      fi-skl-guc:         FAIL (fdo#107837) -> PASS

    igt@kms_frontbuffer_tracking@basic:
      fi-byt-clapper:     FAIL (fdo#103167) -> PASS

    igt@prime_vgem@basic-fence-flip:
      fi-ilk-650:         FAIL (fdo#104008) -> PASS

    
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
  fdo#107258 https://bugs.freedesktop.org/show_bug.cgi?id=107258
  fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107837 https://bugs.freedesktop.org/show_bug.cgi?id=107837


== Participating hosts (52 -> 47) ==

  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * Linux: CI_DRM_4792 -> Patchwork_10134

  CI_DRM_4792: e1d007eb6fbfa346237b7b3a62625e50b3070c71 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4637: 57e3d826dee154cb8664667db7660d854a707fc6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_10134: 1ad52148da5f720ebb994660f92f72850196d8df @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

1ad52148da5f HAX Switch off GuC submission even if explicitly enabled
d0f85704c2c0 drm/i915/guc: Update GuC power domain states

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10134/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [CI v2 1/2] drm/i915/guc: Update GuC power domain states
  2018-09-10 10:41 [CI v2 1/2] drm/i915/guc: Update GuC power domain states Michal Wajdeczko
                   ` (2 preceding siblings ...)
  2018-09-10 15:30 ` ✗ Fi.CI.BAT: failure " Patchwork
@ 2018-09-10 15:34 ` Chris Wilson
  2018-09-11  8:08   ` Chris Wilson
  2018-09-10 16:39 ` Srivatsa, Anusha
                   ` (2 subsequent siblings)
  6 siblings, 1 reply; 10+ messages in thread
From: Chris Wilson @ 2018-09-10 15:34 UTC (permalink / raw)
  To: Michal Wajdeczko, intel-gfx

Quoting Michal Wajdeczko (2018-09-10 11:41:49)
> We should update GuC power domain states also when GuC submission
> is disabled, otherwise GuC might complain or ignore our requests.
> This seems to be required for all currently released GuC firmwares.

Was it expected to fix the live_guc selftest? Might be worth mentioning
Testcase: igt/drv_selftest/live_guc
in that case.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [CI v2 1/2] drm/i915/guc: Update GuC power domain states
  2018-09-10 10:41 [CI v2 1/2] drm/i915/guc: Update GuC power domain states Michal Wajdeczko
                   ` (3 preceding siblings ...)
  2018-09-10 15:34 ` [CI v2 1/2] " Chris Wilson
@ 2018-09-10 16:39 ` Srivatsa, Anusha
  2018-09-10 19:37   ` Chris Wilson
  2018-09-10 17:07 ` ✓ Fi.CI.BAT: success for series starting with [CI,v2,1/2] " Patchwork
  2018-09-10 19:14 ` ✓ Fi.CI.IGT: " Patchwork
  6 siblings, 1 reply; 10+ messages in thread
From: Srivatsa, Anusha @ 2018-09-10 16:39 UTC (permalink / raw)
  To: Wajdeczko, Michal, intel-gfx



>-----Original Message-----
>From: Wajdeczko, Michal
>Sent: Monday, September 10, 2018 3:42 AM
>To: intel-gfx@lists.freedesktop.org
>Cc: Wajdeczko, Michal <Michal.Wajdeczko@intel.com>; Spotswood, John A
><john.a.spotswood@intel.com>; Srivatsa, Anusha <anusha.srivatsa@intel.com>;
>Lis, Tomasz <tomasz.lis@intel.com>; Ceraolo Spurio, Daniele
><daniele.ceraolospurio@intel.com>
>Subject: [CI v2 1/2] drm/i915/guc: Update GuC power domain states
>
>We should update GuC power domain states also when GuC submission is
>disabled, otherwise GuC might complain or ignore our requests.
>This seems to be required for all currently released GuC firmwares.
>
>v2: it is only needed by pre-Gen11 firmwares
>
>Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>Cc: John Spotswood <john.a.spotswood@intel.com>
>Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
>Cc: Tomasz Lis <tomasz.lis@intel.com>
>Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Reviewed-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>---
> drivers/gpu/drm/i915/intel_uc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
>index 7c95697..b1b3e81 100644
>--- a/drivers/gpu/drm/i915/intel_uc.c
>+++ b/drivers/gpu/drm/i915/intel_uc.c
>@@ -401,6 +401,10 @@ int intel_uc_init_hw(struct drm_i915_private *i915)
> 		ret = intel_guc_submission_enable(guc);
> 		if (ret)
> 			goto err_communication;
>+	} else if (INTEL_GEN(i915) < 11) {
>+		ret = intel_guc_sample_forcewake(guc);
>+		if (ret)
>+			goto err_communication;
> 	}
>
> 	dev_info(i915->drm.dev, "GuC firmware version %u.%u\n",
>--
>1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread

* ✓ Fi.CI.BAT: success for series starting with [CI,v2,1/2] drm/i915/guc: Update GuC power domain states
  2018-09-10 10:41 [CI v2 1/2] drm/i915/guc: Update GuC power domain states Michal Wajdeczko
                   ` (4 preceding siblings ...)
  2018-09-10 16:39 ` Srivatsa, Anusha
@ 2018-09-10 17:07 ` Patchwork
  2018-09-10 19:14 ` ✓ Fi.CI.IGT: " Patchwork
  6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2018-09-10 17:07 UTC (permalink / raw)
  To: Michal Wajdeczko; +Cc: intel-gfx

== Series Details ==

Series: series starting with [CI,v2,1/2] drm/i915/guc: Update GuC power domain states
URL   : https://patchwork.freedesktop.org/series/49423/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4792 -> Patchwork_10137 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49423/revisions/1/mbox/

== Known issues ==

  Here are the changes found in Patchwork_10137 that come from known issues:

  === IGT changes ===

    ==== Possible fixes ====

    igt@drv_selftest@live_guc:
      fi-skl-guc:         DMESG-WARN (fdo#107258) -> PASS
      fi-kbl-guc:         DMESG-WARN (fdo#107258) -> PASS

    igt@drv_selftest@live_hangcheck:
      fi-skl-guc:         FAIL (fdo#107837) -> PASS

    igt@gem_exec_suspend@basic-s3:
      fi-blb-e6850:       INCOMPLETE (fdo#107718) -> PASS

    igt@kms_frontbuffer_tracking@basic:
      fi-byt-clapper:     FAIL (fdo#103167) -> PASS

    igt@prime_vgem@basic-fence-flip:
      fi-ilk-650:         FAIL (fdo#104008) -> PASS

    
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
  fdo#107258 https://bugs.freedesktop.org/show_bug.cgi?id=107258
  fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
  fdo#107837 https://bugs.freedesktop.org/show_bug.cgi?id=107837


== Participating hosts (52 -> 47) ==

  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * Linux: CI_DRM_4792 -> Patchwork_10137

  CI_DRM_4792: e1d007eb6fbfa346237b7b3a62625e50b3070c71 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4637: 57e3d826dee154cb8664667db7660d854a707fc6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_10137: aeefdf21ff2a38b6b958b267513dbbf8325dc1da @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

aeefdf21ff2a HAX Switch off GuC submission even if explicitly enabled
d32a07cfbc60 drm/i915/guc: Update GuC power domain states

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10137/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread

* ✓ Fi.CI.IGT: success for series starting with [CI,v2,1/2] drm/i915/guc: Update GuC power domain states
  2018-09-10 10:41 [CI v2 1/2] drm/i915/guc: Update GuC power domain states Michal Wajdeczko
                   ` (5 preceding siblings ...)
  2018-09-10 17:07 ` ✓ Fi.CI.BAT: success for series starting with [CI,v2,1/2] " Patchwork
@ 2018-09-10 19:14 ` Patchwork
  6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2018-09-10 19:14 UTC (permalink / raw)
  To: Michal Wajdeczko; +Cc: intel-gfx

== Series Details ==

Series: series starting with [CI,v2,1/2] drm/i915/guc: Update GuC power domain states
URL   : https://patchwork.freedesktop.org/series/49423/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4792_full -> Patchwork_10137_full =

== Summary - SUCCESS ==

  No regressions found.

  

== Known issues ==

  Here are the changes found in Patchwork_10137_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_ctx_isolation@bcs0-s3:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665)

    igt@kms_flip@2x-flip-vs-expired-vblank:
      shard-glk:          PASS -> FAIL (fdo#105363)

    igt@kms_setmode@basic:
      shard-kbl:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@perf@blocking:
      shard-hsw:          FAIL -> PASS

    
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * Linux: CI_DRM_4792 -> Patchwork_10137

  CI_DRM_4792: e1d007eb6fbfa346237b7b3a62625e50b3070c71 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4637: 57e3d826dee154cb8664667db7660d854a707fc6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_10137: aeefdf21ff2a38b6b958b267513dbbf8325dc1da @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10137/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [CI v2 1/2] drm/i915/guc: Update GuC power domain states
  2018-09-10 16:39 ` Srivatsa, Anusha
@ 2018-09-10 19:37   ` Chris Wilson
  0 siblings, 0 replies; 10+ messages in thread
From: Chris Wilson @ 2018-09-10 19:37 UTC (permalink / raw)
  To: Srivatsa, Anusha, Wajdeczko, Michal, intel-gfx

Quoting Srivatsa, Anusha (2018-09-10 17:39:30)
> 
> 
> >-----Original Message-----
> >From: Wajdeczko, Michal
> >Sent: Monday, September 10, 2018 3:42 AM
> >To: intel-gfx@lists.freedesktop.org
> >Cc: Wajdeczko, Michal <Michal.Wajdeczko@intel.com>; Spotswood, John A
> ><john.a.spotswood@intel.com>; Srivatsa, Anusha <anusha.srivatsa@intel.com>;
> >Lis, Tomasz <tomasz.lis@intel.com>; Ceraolo Spurio, Daniele
> ><daniele.ceraolospurio@intel.com>
> >Subject: [CI v2 1/2] drm/i915/guc: Update GuC power domain states
> >
> >We should update GuC power domain states also when GuC submission is
> >disabled, otherwise GuC might complain or ignore our requests.
> >This seems to be required for all currently released GuC firmwares.
> >
> >v2: it is only needed by pre-Gen11 firmwares
> >
> >Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> >Cc: John Spotswood <john.a.spotswood@intel.com>
> >Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> >Cc: Tomasz Lis <tomasz.lis@intel.com>
> >Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Reviewed-by: Anusha Srivatsa <anusha.srivatsa@intel.com>

And pushed. Thanks for the patch and review,
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [CI v2 1/2] drm/i915/guc: Update GuC power domain states
  2018-09-10 15:34 ` [CI v2 1/2] " Chris Wilson
@ 2018-09-11  8:08   ` Chris Wilson
  0 siblings, 0 replies; 10+ messages in thread
From: Chris Wilson @ 2018-09-11  8:08 UTC (permalink / raw)
  To: Michal Wajdeczko, intel-gfx

Quoting Chris Wilson (2018-09-10 16:34:36)
> Quoting Michal Wajdeczko (2018-09-10 11:41:49)
> > We should update GuC power domain states also when GuC submission
> > is disabled, otherwise GuC might complain or ignore our requests.
> > This seems to be required for all currently released GuC firmwares.
> 
> Was it expected to fix the live_guc selftest? Might be worth mentioning
> Testcase: igt/drv_selftest/live_guc
> in that case.

Yes. It was because HAX wasn't to enable guc live I thought it was going
to be, but to clear guc submission. My bad for not reading before
speaking.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2018-09-11  8:08 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-10 10:41 [CI v2 1/2] drm/i915/guc: Update GuC power domain states Michal Wajdeczko
2018-09-10 10:41 ` [CI v2 2/2] HAX Switch off GuC submission even if explicitly enabled Michal Wajdeczko
2018-09-10 15:12 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,v2,1/2] drm/i915/guc: Update GuC power domain states Patchwork
2018-09-10 15:30 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-09-10 15:34 ` [CI v2 1/2] " Chris Wilson
2018-09-11  8:08   ` Chris Wilson
2018-09-10 16:39 ` Srivatsa, Anusha
2018-09-10 19:37   ` Chris Wilson
2018-09-10 17:07 ` ✓ Fi.CI.BAT: success for series starting with [CI,v2,1/2] " Patchwork
2018-09-10 19:14 ` ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.