From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEF1DC43460 for ; Thu, 1 Apr 2021 09:04:30 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id F06EA61055 for ; Thu, 1 Apr 2021 09:04:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F06EA61055 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ashroe.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E87F240696; Thu, 1 Apr 2021 11:04:28 +0200 (CEST) Received: from mail-109-mta107.mxroute.com (mail-109-mta107.mxroute.com [136.175.109.107]) by mails.dpdk.org (Postfix) with ESMTP id 63D8440142 for ; Thu, 1 Apr 2021 11:04:27 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-109-mta107.mxroute.com (ZoneMTA) with ESMTPSA id 1788cad2dbf0004964.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Thu, 01 Apr 2021 09:04:22 +0000 X-Zone-Loop: 22ee55eaac521dcb31ded9194da096fa794c0fd7b9bf X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=LMaopqPC0uljHIbiy92XvxNUMLeSIYIsNc6IQBKhMf4=; b=Cj0gxzO59Kz9KiUXg/uulQMA18 qZJKgMT5jKux62LRz+wnJkXmzYh8q0aMdbRiOTdkYmOk55qd0bvVCmWTrNuyqiQJiEBNpkYjb0jVe Oxuw18pITx7cCQyR7t+GVNK7URCojm5V60o7su7uYRVlSTQJ2PhvfsvxkO/V1Xo0aAthatZTJDXaA /yen2c2VSNEORPZHnq2ciNKHICLRCLGsUI16j4grQZQJM3fFx2JYMTv44dFLP1UxzH6OXzOhE//mX zEHILYJibsHVzI3SungZvjR0AJqM6UlkuFHvTh/btXlFmbZJYeMK7mAPxcgaLgWmgpHraRBrBMBzD j5LP48eg==; To: Xueming Li , Thomas Monjalon , Gaetan Rivet Cc: dev@dpdk.org, Asaf Penso , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Gaetan Rivet , Anatoly Burakov , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Neil Horman , Ferruh Yigit , Andrew Rybchenko References: <1617106521-25931-1-git-send-email-xuemingl@nvidia.com> <1617106521-25931-2-git-send-email-xuemingl@nvidia.com> From: "Kinsella, Ray" Message-ID: <83b5944d-e882-c25a-8d1d-cf7c12a0b385@ashroe.eu> Date: Thu, 1 Apr 2021 10:04:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <1617106521-25931-2-git-send-email-xuemingl@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH v3 1/5] devargs: unify scratch buffer storage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 30/03/2021 13:15, Xueming Li wrote: > In current design, legacy parser rte_devargs_parse() saved scratch > buffer to devargs.args while new parser rte_devargs_layers_parse() saved > to devargs.data. Code using devargs had to know the difference and > cleaned up memory accordingly - error prone. > > This patch unifies scratch buffer to data field, introduces > rte_devargs_reset() function to wrap the memory clean up logic. > > Signed-off-by: Xueming Li > --- > app/test-pmd/config.c | 3 +- > app/test-pmd/testpmd.c | 5 +-- > drivers/bus/vdev/vdev.c | 9 +++--- > drivers/net/failsafe/failsafe_args.c | 3 +- > drivers/net/failsafe/failsafe_eal.c | 2 +- > examples/multi_process/hotplug_mp/commands.c | 6 ++-- > lib/librte_eal/common/eal_common_dev.c | 9 +++--- > lib/librte_eal/common/eal_common_devargs.c | 34 +++++++++++--------- > lib/librte_eal/common/hotplug_mp.c | 6 ++-- > lib/librte_eal/include/rte_devargs.h | 18 ++++++++--- > lib/librte_eal/rte_eal_exports.def | 1 + > lib/librte_eal/version.map | 1 + > lib/librte_ethdev/rte_ethdev.c | 8 ++--- > 13 files changed, 59 insertions(+), 46 deletions(-) > Acked-by: Ray Kinsella