From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Allow modeset to survive change of cdclk
Date: Fri, 17 Apr 2020 10:35:08 +0300 [thread overview]
Message-ID: <83c8e359-5c8a-7f29-a59d-4e53ad48a317@gmail.com> (raw)
In-Reply-To: <20200416174225.GL6112@intel.com>
On 16.4.2020 20.42, Ville Syrjälä wrote:
> On Thu, Apr 16, 2020 at 08:29:33PM +0300, Juha-Pekka Heikkila wrote:
>> When testing 64bpp formats there will come modeset to change cdclk.
>> Allow modesets on commits so commits will not produce error.
>>
>> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>> ---
>> tests/kms_big_fb.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
>> index eb144da9..dabd16f3 100644
>> --- a/tests/kms_big_fb.c
>> +++ b/tests/kms_big_fb.c
>> @@ -294,6 +294,7 @@ static bool test_plane(data_t *data)
>> */
>> if (i == 0 && data->display.is_atomic &&
>> igt_display_try_commit_atomic(&data->display,
>> + DRM_MODE_ATOMIC_ALLOW_MODESET |
>> DRM_MODE_ATOMIC_TEST_ONLY,
>> NULL) != 0) {
>> if (igt_plane_has_prop(plane, IGT_PLANE_ROTATION))
>> @@ -318,8 +319,8 @@ static bool test_plane(data_t *data)
>> copy_pattern(data, small_fb, 0, 0, big_fb, x, y,
>> small_fb->width, small_fb->height);
>>
>> - igt_display_commit2(&data->display, data->display.is_atomic ?
>> - COMMIT_ATOMIC : COMMIT_UNIVERSAL);
>> + igt_display_commit2(&data->display, DRM_MODE_ATOMIC_ALLOW_MODESET |
>
> That's not how you use igt_display_commit2(). And it also
> passes DRM_MODE_ATOMIC_ALLOW_MODESET to igt_atomic_commit().
Yea, I'll fix that. Seems it was too late hours yesterday making that patch.
>
>> + data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_UNIVERSAL);
>>
>>
>> igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
>> --
>> 2.26.0
>>
>> _______________________________________________
>> igt-dev mailing list
>> igt-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/igt-dev
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-04-17 7:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 17:29 [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Allow modeset to survive change of cdclk Juha-Pekka Heikkila
2020-04-16 17:42 ` Ville Syrjälä
2020-04-17 7:35 ` Juha-Pekka Heikkila [this message]
2020-04-16 18:17 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-04-17 18:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83c8e359-5c8a-7f29-a59d-4e53ad48a317@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.