From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 862B01865 for ; Thu, 27 Oct 2022 09:09:32 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 620FF5C0138; Thu, 27 Oct 2022 05:09:31 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute3.internal (MEProxy); Thu, 27 Oct 2022 05:09:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1666861771; x=1666948171; bh=u2xJJZS73/ d/o0CIY2bxlyBu06Lupq5Y1/URzXoJcZI=; b=rUKXcm/ZhA8H39d7Mex+vFksm2 Qmi6KcNPjWQvRWB12gV8FTf66HPVHIIA3nYIek0C31gN+JN5Ak1sDL7DM2mLRfVs RRCRnZ4q9ByYglAPDZDcXb6P/ICiQYtL44cdpumyX3jIexaSuM8Kcj0H20+eaZfy sfFqsByd37G0970SHeKG/pbBAKPNChWG61mB6DzOMkKCSXTFYrEzXOEgzSWO9N/I tPDXvnIxRMLa9EAbW0ieaMW45agQW6DqvolCY3qc/quOEV7qb5UL4ANB2KWjeP3R Xvee8PU9sHJZaDkiPxLB73yJi0h1g2p2TV3c4uj6imLbCJVzolZzAAgacAUQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1666861771; x=1666948171; bh=u2xJJZS73/d/o0CIY2bxlyBu06Lu pq5Y1/URzXoJcZI=; b=SdiOIhdIJ8srI2G1QM70siY4nnlcIEMsHF0g+Lil2Rd2 kAyh8Nhsrgu6iyT89NTTAAAyvaE4Z0B8SeXYyI4GeKuq+Y33p9D3cVC9yBi5tCpK FL30Acjm208Dkl2yl+PyKSPq8xKMs+eb+hg39HUISIdVDkttQxsjS6eyusj6Klqs Xlnk0VFqhU1eTOLybznPzWfbKgfLJLGasSlfCUBzs646X3Q5ev1AmKKnUiA1GUOm y8olD3ck/4/NMjMivWcs2/j0NF4zrTC1+KhxlgWaHtIb3rVkizCCBE8bW061WD+3 2jh4AdSgPcRBt1m0t6N02o6pHkwE5U0sU94GYCWuNQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdeggddutdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 88ADEB60089; Thu, 27 Oct 2022 05:09:30 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1087-g968661d8e1-fm-20221021.001-g968661d8 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Message-Id: <83c93b5e-c589-4ca9-8bc0-ad3571f7f54d@app.fastmail.com> In-Reply-To: References: Date: Thu, 27 Oct 2022 11:09:10 +0200 From: "Arnd Bergmann" To: "Naresh Kamboju" , patches@opensource.cirrus.com, "Linux ARM" , "Linux Samsung SOC" , "open list" , llvm@lists.linux.dev Cc: "Krzysztof Kozlowski" , "Russell King" , "Alim Akhtar" , "Nathan Chancellor" , "Andy Shevchenko" Subject: Re: s3c6400_defconfig: arch/arm/mach-s3c/mach-crag6410.c:183:12: error: use of undeclared identifier 'KEY_VOLUMEUP' Content-Type: text/plain On Thu, Oct 27, 2022, at 09:29, Naresh Kamboju wrote: > Following build warnings / errors noticed while building arm s3c6400_defconfig > with clang tool chain. Do you mean this is a clang specific issue? > arch/arm/mach-s3c/mach-crag6410.c:183:12: error: use of undeclared > identifier 'KEY_VOLUMEUP' > KEY(0, 0, KEY_VOLUMEUP), > ^ I can see that KEY_VOLUMEUP is defined in , which is included by a couple of files in the kernel, but not from this specific board file, so I don't see how it works with gcc. Isn't this just a regression from commit 1810e248b2dc ("Input: matrix_keypad - replace header inclusions by forward declarations")? If that is the problem, I would expect to see the same thing in all of these files, regardless of the compiler: $ git grep -wl '\(linux/input/matrix_keypad.h\|linux/mfd/twl.h\|linux/platform_data/keyboard-spear.h\|linux/platform_data/keypad-nomadik-ske.h\|linux/platform_data/keypad-omap.h\|linux/platform_data/keypad-pxa27x.h\|linux/input/samsung-keypad.h\|\"keypad.h\"\)' | xargs grep -l \\\ X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7485DC67871 for ; Thu, 27 Oct 2022 09:10:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lFETuUCPKepAjY5lV91HKT+zMI4V2XjJRPOv+9cFaCI=; b=of8OkZnCP3wPX+ lkkOgiYOMiaIG00+9py2/k3yQIS0cAuZXEJlzU/cnQGbkqFSheR1dwHWypUHi007fnYn0eq/tZiSA 09lrGlA4kGP8u/T7L20xz/awxMOcYJTJVXo9BMP2/V1ZCDEEOUH9ExmzTTKxdiFw8+Dk7ZiWI7U0t XhzWlwoDR9zLC3J0foTU8Ow9EOKmfaN2mrQADMjtUfxLr/ylRHcVdT8ctbGCaJa6nfq+L+ZVWdkxi aHCLlNP9N6wPwz5BCpMXh/ae2KL5VsrgU+YLww+pVsQ/2TPC/lMC7mKRRg/twwvz/B+KyxVs3tJqA V9zg3Nga889Imv5posEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onytN-00CY9e-Mb; Thu, 27 Oct 2022 09:09:37 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1onytL-00CY8n-3r for linux-arm-kernel@lists.infradead.org; Thu, 27 Oct 2022 09:09:36 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 620FF5C0138; Thu, 27 Oct 2022 05:09:31 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute3.internal (MEProxy); Thu, 27 Oct 2022 05:09:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1666861771; x=1666948171; bh=u2xJJZS73/ d/o0CIY2bxlyBu06Lupq5Y1/URzXoJcZI=; b=rUKXcm/ZhA8H39d7Mex+vFksm2 Qmi6KcNPjWQvRWB12gV8FTf66HPVHIIA3nYIek0C31gN+JN5Ak1sDL7DM2mLRfVs RRCRnZ4q9ByYglAPDZDcXb6P/ICiQYtL44cdpumyX3jIexaSuM8Kcj0H20+eaZfy sfFqsByd37G0970SHeKG/pbBAKPNChWG61mB6DzOMkKCSXTFYrEzXOEgzSWO9N/I tPDXvnIxRMLa9EAbW0ieaMW45agQW6DqvolCY3qc/quOEV7qb5UL4ANB2KWjeP3R Xvee8PU9sHJZaDkiPxLB73yJi0h1g2p2TV3c4uj6imLbCJVzolZzAAgacAUQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1666861771; x=1666948171; bh=u2xJJZS73/d/o0CIY2bxlyBu06Lu pq5Y1/URzXoJcZI=; b=SdiOIhdIJ8srI2G1QM70siY4nnlcIEMsHF0g+Lil2Rd2 kAyh8Nhsrgu6iyT89NTTAAAyvaE4Z0B8SeXYyI4GeKuq+Y33p9D3cVC9yBi5tCpK FL30Acjm208Dkl2yl+PyKSPq8xKMs+eb+hg39HUISIdVDkttQxsjS6eyusj6Klqs Xlnk0VFqhU1eTOLybznPzWfbKgfLJLGasSlfCUBzs646X3Q5ev1AmKKnUiA1GUOm y8olD3ck/4/NMjMivWcs2/j0NF4zrTC1+KhxlgWaHtIb3rVkizCCBE8bW061WD+3 2jh4AdSgPcRBt1m0t6N02o6pHkwE5U0sU94GYCWuNQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdeggddutdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 88ADEB60089; Thu, 27 Oct 2022 05:09:30 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1087-g968661d8e1-fm-20221021.001-g968661d8 Mime-Version: 1.0 Message-Id: <83c93b5e-c589-4ca9-8bc0-ad3571f7f54d@app.fastmail.com> In-Reply-To: References: Date: Thu, 27 Oct 2022 11:09:10 +0200 From: "Arnd Bergmann" To: "Naresh Kamboju" , patches@opensource.cirrus.com, "Linux ARM" , "Linux Samsung SOC" , "open list" , llvm@lists.linux.dev Cc: "Krzysztof Kozlowski" , "Russell King" , "Alim Akhtar" , "Nathan Chancellor" , "Andy Shevchenko" Subject: Re: s3c6400_defconfig: arch/arm/mach-s3c/mach-crag6410.c:183:12: error: use of undeclared identifier 'KEY_VOLUMEUP' X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221027_020935_461534_A06345D5 X-CRM114-Status: GOOD ( 11.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 27, 2022, at 09:29, Naresh Kamboju wrote: > Following build warnings / errors noticed while building arm s3c6400_defconfig > with clang tool chain. Do you mean this is a clang specific issue? > arch/arm/mach-s3c/mach-crag6410.c:183:12: error: use of undeclared > identifier 'KEY_VOLUMEUP' > KEY(0, 0, KEY_VOLUMEUP), > ^ I can see that KEY_VOLUMEUP is defined in , which is included by a couple of files in the kernel, but not from this specific board file, so I don't see how it works with gcc. Isn't this just a regression from commit 1810e248b2dc ("Input: matrix_keypad - replace header inclusions by forward declarations")? If that is the problem, I would expect to see the same thing in all of these files, regardless of the compiler: $ git grep -wl '\(linux/input/matrix_keypad.h\|linux/mfd/twl.h\|linux/platform_data/keyboard-spear.h\|linux/platform_data/keypad-nomadik-ske.h\|linux/platform_data/keypad-omap.h\|linux/platform_data/keypad-pxa27x.h\|linux/input/samsung-keypad.h\|\"keypad.h\"\)' | xargs grep -l \\\