From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4F3BC43334 for ; Thu, 2 Jun 2022 10:30:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233850AbiFBKaT (ORCPT ); Thu, 2 Jun 2022 06:30:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233891AbiFBKaE (ORCPT ); Thu, 2 Jun 2022 06:30:04 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A3441522CA for ; Thu, 2 Jun 2022 03:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654165802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=snHHRq9gvgH3KmNDhpwAr/uJvvmdHvD2RhbsF2j6EaQ=; b=OYtNTYyJ3Hu7NQ51IoFpRTU3TXYO1YNDkP5wVaUTPx5aTrr596dNoOF2SBWV6xNPl7oMPc fQPGo1m9+B4dD9V0dH53qC7JyrW+nFI52jJSTekaW06j+1IZnuBZlpZDh+uC2rQuCCjvLq pW8EhyPTFzamZXfH8dt03fSTv+XJTS0= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-675-pJUXRJydNnKBjFShCpY7Qw-1; Thu, 02 Jun 2022 06:29:52 -0400 X-MC-Unique: pJUXRJydNnKBjFShCpY7Qw-1 Received: by mail-qt1-f199.google.com with SMTP id u17-20020a05622a14d100b00304cf9c24fdso1404978qtx.7 for ; Thu, 02 Jun 2022 03:29:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=snHHRq9gvgH3KmNDhpwAr/uJvvmdHvD2RhbsF2j6EaQ=; b=Zu1eumRLLJxhSs+zNhbhq6/3GuvlXQp7un8bCm2igPxT0tTikzAjIdB9jzJ3UvYN4A b0h3Gs3dZWzjWMfkMX3W0+cYUIORfaUQEtir+A1MkRQSzBiS4uPaVsv1/+Ri+0QT61nw M4zaVJPj5UHHaSN2QJmZd8H5ZsS9g9zgZds2qtmi6KPnc9NFs40h0qdZQQSTih5vQTce 7bK9+H+AxqYeZTDoCszux2rpE9en6WyfWaJQI80vC3QX6gpJuw9W7hVGDVKEBPFI8gh0 koSaREMcfNqQZ16UON1UW0ZlO2adx1SR1NryQ/4aNtEH6LtgcV81qT96cKSoZAnMDpKr BXYg== X-Gm-Message-State: AOAM533eB+0iXb5/rKrs9AiMmOHS0wbxCdsUsedSQpgro1IuMZaPQNlq NDc9LNxECzD/W7YB/cr+7dXTmmwIuAR3YB9igA1VZH/ZzLJTh9r8IDxHVkmeL2svPfwDhQVQ1TV v6/5Bo4U1Yxmkl+DLC9biA2qU X-Received: by 2002:a37:6290:0:b0:6a6:7d23:5eb7 with SMTP id w138-20020a376290000000b006a67d235eb7mr840498qkb.642.1654165791784; Thu, 02 Jun 2022 03:29:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzdvLDzsn8T7wXWgdLuW/UBeiKgUTaKg8kIckdX0qrk68ukg3/B5uglLQxeT5wvy6xQscvXRA== X-Received: by 2002:a37:6290:0:b0:6a6:7d23:5eb7 with SMTP id w138-20020a376290000000b006a67d235eb7mr840481qkb.642.1654165791538; Thu, 02 Jun 2022 03:29:51 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-112-184.dyn.eolo.it. [146.241.112.184]) by smtp.gmail.com with ESMTPSA id u3-20020a372e03000000b006a323e60e29sm2950621qkh.135.2022.06.02.03.29.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jun 2022 03:29:51 -0700 (PDT) Message-ID: <83d04ebf876fc2be804a6351318806cd38fba20b.camel@redhat.com> Subject: Re: [PATCH v2] selftests net: fix bpf build error From: Paolo Abeni To: Lina Wang , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Shuah Khan , Daniel Borkmann Cc: Alexei Starovoitov , Andrii Nakryiko , Maciej enczykowski , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, lkp@intel.com, rong.a.chen@intel.com, kernel test robot Date: Thu, 02 Jun 2022 12:29:46 +0200 In-Reply-To: <20220601084840.11024-1-lina.wang@mediatek.com> References: <20220601084840.11024-1-lina.wang@mediatek.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2022-06-01 at 16:48 +0800, Lina Wang wrote: > bpf_helpers.h has been moved to tools/lib/bpf since 5.10, so add more > including path. > > Fixes: edae34a3ed92 ("selftests net: add UDP GRO fraglist + bpf self-tests") > Reported-by: kernel test robot > Signed-off-by: Lina Wang > --- > tools/testing/selftests/net/bpf/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/net/bpf/Makefile b/tools/testing/selftests/net/bpf/Makefile > index f91bf14bbee7..070251986dbe 100644 > --- a/tools/testing/selftests/net/bpf/Makefile > +++ b/tools/testing/selftests/net/bpf/Makefile > @@ -2,6 +2,7 @@ > > CLANG ?= clang > CCINCLUDE += -I../../bpf > +CCINCLUDE += -I../../../../lib > CCINCLUDE += -I../../../../../usr/include/ > > TEST_CUSTOM_PROGS = $(OUTPUT)/bpf/nat6to4.o With this patch applied, I still get an error while building the self- tests: --- cd tools/testing/selftests/ make #... make[1]: Entering directory '/home/pabeni/net/tools/testing/selftests/net' bpf/Makefile:15: warning: overriding recipe for target 'clean' ../lib.mk:136: warning: ignoring old recipe for target 'clean' clang -O2 -target bpf -c bpf/nat6to4.c -I../../bpf -I../../../../lib -I../../../../../usr/include/ -o /home/pabeni/net/tools/testing/selftests/net/bpf/nat6to4.o bpf/nat6to4.c:43:10: fatal error: 'bpf/bpf_helpers.h' file not found #include ^~~~~~~~~~~~~~~~~~~ 1 error generated. make[1]: *** [bpf/Makefile:12: /home/pabeni/net/tools/testing/selftests/net/bpf/nat6to4.o] Error 1 --- the following fix the issue here: --- diff --git a/tools/testing/selftests/net/bpf/Makefile b/tools/testing/selftests/net/bpf/Makefile index 070251986dbe..cff99d571408 100644 --- a/tools/testing/selftests/net/bpf/Makefile +++ b/tools/testing/selftests/net/bpf/Makefile @@ -2,7 +2,7 @@ CLANG ?= clang CCINCLUDE += -I../../bpf -CCINCLUDE += -I../../../../lib +CCINCLUDE += -I../../../lib CCINCLUDE += -I../../../../../usr/include/ --- (But I still hit the "overriding recipe for target 'clean'" warnings) Cheers, Paolo