From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64057C433EF for ; Thu, 16 Sep 2021 06:57:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 482FB61209 for ; Thu, 16 Sep 2021 06:57:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234755AbhIPG66 (ORCPT ); Thu, 16 Sep 2021 02:58:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234796AbhIPG6t (ORCPT ); Thu, 16 Sep 2021 02:58:49 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D3C3C061768 for ; Wed, 15 Sep 2021 23:57:28 -0700 (PDT) Received: from [192.168.1.111] (91-158-153-130.elisa-laajakaista.fi [91.158.153.130]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4ACD92A5; Thu, 16 Sep 2021 08:57:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1631775445; bh=d+TECPeHdBfHoBsmFP30RU2fIUhu3wc4WKeHCNSDajM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=JnRds8sm4FvmLoA/FxBbW0nsDJgk7SvDglmluSfufbYpOY8bhZlnUIH1nHlbtNQE7 tsbOAQTUF8zfa+rG7GOKXKVIY2ZxhzuP2irGKyflFECqL2Hj6riDZReCNO0xMGjSIw RGLT3o1UiZvqWyrl8wzV0Z8KXHzmjxo4U7LZEZPk= Subject: Re: [PATCH v8 28/36] media: subdev: Add [GS]_ROUTING subdev ioctls and operations To: Jacopo Mondi Cc: linux-media@vger.kernel.org, sakari.ailus@linux.intel.com, Jacopo Mondi , Laurent Pinchart , niklas.soderlund+renesas@ragnatech.se, Mauro Carvalho Chehab , Hans Verkuil , Pratyush Yadav , Lokesh Vutla , Michal Simek References: <20210830110116.488338-1-tomi.valkeinen@ideasonboard.com> <20210830110116.488338-29-tomi.valkeinen@ideasonboard.com> <20210915161034.h5hqxkfa53urdpwn@uno.localdomain> From: Tomi Valkeinen Message-ID: <83d4950d-fdda-0ef1-c0b0-f82b5e49284c@ideasonboard.com> Date: Thu, 16 Sep 2021 09:57:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210915161034.h5hqxkfa53urdpwn@uno.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi, On 15/09/2021 19:10, Jacopo Mondi wrote: >> +#define V4L2_SUBDEV_ROUTE_FL_ACTIVE BIT(0) > > Am I wrong or BIT() is not available to userspace ? > > ../../include/linux/v4l2-subdev.h:209:38: error: ‘BIT’ was not declared in this scope > 209 | #define V4L2_SUBDEV_ROUTE_FL_ACTIVE BIT(0) > > Header was exported with headers_install. Yes, I think you are correct. I see only two other BIT() uses in uapi headers, and those might be errors too. Tomi