All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Alper Nebi Yasak <alpernebiyasak@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Banajit Goswami <bgoswami@quicinc.com>,
	Bard Liao <yung-chuan.liao@linux.intel.com>,
	Brent Lu <brent.lu@intel.com>,
	Cezary Rojewski <cezary.rojewski@intel.com>,
	Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Jaroslav Kysela <perex@perex.cz>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Mark Brown <broonie@kernel.org>,
	Maso Huang <maso.huang@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Shengjiu Wang <shengjiu.wang@gmail.com>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Takashi Iwai <tiwai@suse.com>, Trevor Wu <trevor.wu@mediatek.com>,
	Vinod Koul <vkoul@kernel.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
	alsa-devel@alsa-project.org, imx@lists.linux.dev,
	linux-sound@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 00/15] ASoC: replace dpcm_playback/capture to playback/capture_only
Date: Tue, 26 Mar 2024 13:25:38 +0100	[thread overview]
Message-ID: <83d63442-ae4c-4e5e-a610-c0c0be54d50e@linux.intel.com> (raw)
In-Reply-To: <87o7b353of.wl-kuninori.morimoto.gx@renesas.com>

On 3/25/2024 5:35 AM, Kuninori Morimoto wrote:
> 
> Hi Mark
> 
> When we use DPCM, we need to set dpcm_playback/capture flag.
> If these flag are set, soc_get_playback_capture() will check its
> availability, but non DPCM case is checked without special flags.
> 
> OTOH, it cares playback/capture_only flag. It is needed.
> 
> This patch remove DPCM special flag, and replace it playback/capture_only
> flag if needed.
> 

One general note, I wonder if playback/capture_only should be renamed to 
something more descriptive, current names are a bit weird from use case 
point of view. I mean no flags, means both capture and playback are 
enabled. Then you do something like playback_only = 1, which effectively 
affects capture stream. Notice that flag is named playback, but affects 
capture. Perhaps, something like capture_disabled, playback_disabled 
would make more sense? This would also make more sense to me for 
something like playback_only = 1; capture_only = 1; which while weird 
doesn't instantly seem that wrong, while disable on both directions 
instantly seems broken.



  parent reply	other threads:[~2024-03-26 12:25 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-25  4:35 [PATCH 00/15] ASoC: replace dpcm_playback/capture to playback/capture_only Kuninori Morimoto
2024-03-25  4:36 ` [PATCH 01/15] ASoC: soc-pcm.c: cleanup soc_get_playback_capture() Kuninori Morimoto
2024-03-25  4:36 ` [PATCH 02/15] ASoC: amd: replace dpcm_playback/capture to playback/capture_only Kuninori Morimoto
2024-03-25  4:36 ` [PATCH 03/15] ASoC: fsl: " Kuninori Morimoto
2024-03-25  4:36 ` [PATCH 04/15] ASoC: sof: " Kuninori Morimoto
2024-03-25  4:36 ` [PATCH 05/15] ASoC: meson: " Kuninori Morimoto
2024-03-25  4:36 ` [PATCH 06/15] ASoC: Intel: " Kuninori Morimoto
2024-03-26 20:24   ` Pierre-Louis Bossart
2024-03-27  1:18     ` Kuninori Morimoto
2024-03-25  4:36 ` [PATCH 07/15] ASoC: samsung: " Kuninori Morimoto
2024-03-25  4:36 ` [PATCH 08/15] ASoC: mediatek: " Kuninori Morimoto
2024-03-25  4:37 ` [PATCH 09/15] ASoC: Intel/avs: " Kuninori Morimoto
2024-03-26  9:15   ` Amadeusz Sławiński
2024-03-27  1:19     ` Kuninori Morimoto
2024-03-25  4:37 ` [PATCH 10/15] ASoC: soc-core.c: " Kuninori Morimoto
2024-03-25  4:37 ` [PATCH 11/15] ASoC: soc-topology.c: " Kuninori Morimoto
2024-03-25  4:37 ` [PATCH 12/15] ASoC: soc-compress.c: " Kuninori Morimoto
2024-03-25  4:37 ` [PATCH 13/15] ASoC: remove snd_soc_dai_link_set_capabilities() Kuninori Morimoto
2024-03-25  4:37 ` [PATCH 14/15] ASoC: soc-pcm.c: remove dpcm_playback/capture Kuninori Morimoto
2024-03-25  4:37 ` [PATCH 15/15] ASoC: soc-pcm: indicate warning if DPCM BE Codec has no settings Kuninori Morimoto
2024-03-26 14:58   ` Jerome Brunet
2024-03-27  1:06     ` Kuninori Morimoto
2024-03-27 12:30       ` Jerome Brunet
2024-03-27 23:44         ` Kuninori Morimoto
2024-03-26 12:25 ` Amadeusz Sławiński [this message]
2024-03-27  1:26   ` [PATCH 00/15] ASoC: replace dpcm_playback/capture to playback/capture_only Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d63442-ae4c-4e5e-a610-c0c0be54d50e@linux.intel.com \
    --to=amadeuszx.slawinski@linux.intel.com \
    --cc=Xiubo.Lee@gmail.com \
    --cc=alpernebiyasak@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=bgoswami@quicinc.com \
    --cc=brent.lu@intel.com \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=cristian.ciocaltea@collabora.com \
    --cc=daniel.baluta@nxp.com \
    --cc=hdegoede@redhat.com \
    --cc=imx@lists.linux.dev \
    --cc=jbrunet@baylibre.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=khilman@baylibre.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=maso.huang@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=perex@perex.cz \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=s.hauer@pengutronix.de \
    --cc=s.nawrocki@samsung.com \
    --cc=shawnguo@kernel.org \
    --cc=shengjiu.wang@gmail.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    --cc=trevor.wu@mediatek.com \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.