From: J William Piggott <elseifthen@gmx.com>
To: Sami Kerola <kerolasa@iki.fi>, util-linux@vger.kernel.org
Subject: Re: [PATCH 06/13] blkid: add messages to translations
Date: Tue, 7 Mar 2017 09:15:25 -0500 [thread overview]
Message-ID: <83d6c687-8fec-0446-0914-ff00eb3837fc@gmx.com> (raw)
In-Reply-To: <20170305205232.24030-7-kerolasa@iki.fi>
On 03/05/2017 03:52 PM, Sami Kerola wrote:
8< ---
> + fputs(_( " -o <format> output format; can be one of:\n"
> + " value, device, export or full; (default: full)\n"), out);
This says there are four output formats, but the error message
below lists six?
8< ---
> @@ -721,39 +724,38 @@ int main(int argc, char **argv)
> else if (!strcmp(optarg, "full"))
> output_format = 0;
> else {
> - fprintf(stderr, "Invalid output format %s. "
> + errx(BLKID_EXIT_OTHER, _("Invalid output format %s. "
> "Choose from value,\n\t"
> - "device, list, udev or full\n", optarg);
> - exit(BLKID_EXIT_OTHER);
> + "value, device, list, udev, export, or full"), optarg);
8< ---
Looks like the above outputs 'value' twice?
Maybe it should also have a colon "Choose from:\n\t"
A single line would be preferable I think:
"Choose from: value, device, list, udev, export, or full"
next prev parent reply other threads:[~2017-03-07 14:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-05 20:52 [PATCH 00/13] pull: warnings fixes and blkid translations Sami Kerola
2017-03-05 20:52 ` [PATCH 01/13] misc: stop mixing declarations and code Sami Kerola
2017-03-05 20:52 ` [PATCH 02/13] libmount: fix use of preprocessor identifier Sami Kerola
2017-03-05 20:52 ` [PATCH 03/13] libblkid: avoid overflow when initializing array Sami Kerola
2017-03-05 20:52 ` [PATCH 04/13] libblkid: ensure uninitialized variable is not used [clang] Sami Kerola
2017-03-05 20:52 ` [PATCH 05/13] blkid: add curly braces to do-while statement Sami Kerola
2017-03-05 20:52 ` [PATCH 06/13] blkid: add messages to translations Sami Kerola
2017-03-07 14:15 ` J William Piggott [this message]
2017-03-13 14:37 ` Karel Zak
2017-03-13 12:58 ` Karel Zak
2017-03-05 20:52 ` [PATCH 07/13] blkid: define output names only once Sami Kerola
2017-03-07 14:37 ` J William Piggott
2017-03-08 17:14 ` J William Piggott
2017-03-10 9:29 ` Sami Kerola
2017-03-10 14:48 ` Sami Kerola
2017-03-11 17:14 ` J William Piggott
2017-03-13 12:53 ` Karel Zak
2017-03-05 20:52 ` [PATCH 08/13] blkid: improve coding style Sami Kerola
2017-03-05 20:52 ` [PATCH 09/13] include: fix compiler warning Sami Kerola
2017-03-05 20:52 ` [PATCH 10/13] libfdisk: dos: fix potential null pointer dereferences Sami Kerola
2017-03-05 20:52 ` [PATCH 11/13] libfdisk: fix potentially null Sami Kerola
2017-03-05 20:52 ` [PATCH 12/13] docs: improve boilerplate.c options example Sami Kerola
2017-03-05 20:52 ` [PATCH 13/13] lib/colors: assert rathen than overflow Sami Kerola
2017-03-13 13:43 ` Karel Zak
2017-03-13 13:45 ` Karel Zak
2017-03-13 14:39 ` [PATCH 00/13] pull: warnings fixes and blkid translations Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d6c687-8fec-0446-0914-ff00eb3837fc@gmx.com \
--to=elseifthen@gmx.com \
--cc=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.