From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A652AC4361B for ; Mon, 7 Dec 2020 12:11:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64EE4233EA for ; Mon, 7 Dec 2020 12:11:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727247AbgLGMKv (ORCPT ); Mon, 7 Dec 2020 07:10:51 -0500 Received: from szxga08-in.huawei.com ([45.249.212.255]:2331 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727018AbgLGMKv (ORCPT ); Mon, 7 Dec 2020 07:10:51 -0500 Received: from DGGEMM402-HUB.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4CqMYR1xCjz13RDD; Mon, 7 Dec 2020 20:09:15 +0800 (CST) Received: from dggema765-chm.china.huawei.com (10.1.198.207) by DGGEMM402-HUB.china.huawei.com (10.3.20.210) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 7 Dec 2020 20:10:06 +0800 Received: from [10.174.185.137] (10.174.185.137) by dggema765-chm.china.huawei.com (10.1.198.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Mon, 7 Dec 2020 20:10:05 +0800 Subject: Re: [PATCH] iommu/io-pgtalbe-arm: Remove "iopte_type(pte, l)" extra parameter "l" To: Will Deacon CC: Robin Murphy , Joerg Roedel , "moderated list:ARM SMMU DRIVERS" , "open list:IOMMU DRIVERS" , open list , , Keqian Zhu References: <20201207081404.1699-1-jiangkunkun@huawei.com> <20201207102458.GB3825@willie-the-truck> From: Kunkun Jiang Message-ID: <83f3f9f5-43d8-e02b-39e2-70edd42799a8@huawei.com> Date: Mon, 7 Dec 2020 20:09:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201207102458.GB3825@willie-the-truck> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.174.185.137] X-ClientProxiedBy: dggeme705-chm.china.huawei.com (10.1.199.101) To dggema765-chm.china.huawei.com (10.1.198.207) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Will, On 2020/12/7 18:24, Will Deacon wrote: > On Mon, Dec 07, 2020 at 04:14:04PM +0800, Kunkun Jiang wrote: >> Knowing from the code, the macro "iopte_type(pte, l)" doesn't use the >> parameter "l" (level). So we'd better to remove it. >> >> Fixes: e1d3c0fd701df(iommu: add ARM LPAE page table allocator) >> Signed-off-by: Kunkun Jiang >> --- >> drivers/iommu/io-pgtable-arm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/iommu/io-pgtable-arm.c b/drivers/iommu/io-pgtable-arm.c >> index a7a9bc08dcd1..925ae2b713d6 100644 >> --- a/drivers/iommu/io-pgtable-arm.c >> +++ b/drivers/iommu/io-pgtable-arm.c >> @@ -130,7 +130,7 @@ >> /* IOPTE accessors */ >> #define iopte_deref(pte,d) __va(iopte_to_paddr(pte, d)) >> >> -#define iopte_type(pte,l) \ >> +#define iopte_type(pte) \ >> (((pte) >> ARM_LPAE_PTE_TYPE_SHIFT) & ARM_LPAE_PTE_TYPE_MASK) > Shouldn't we update all the users of the macro too? > > Will > . Sorry for my carelessness.  :( I have resent it. Thanks, Kunkun Jiang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5EF3C433FE for ; Mon, 7 Dec 2020 12:10:20 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E51B23370 for ; Mon, 7 Dec 2020 12:10:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E51B23370 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 1679087820; Mon, 7 Dec 2020 12:10:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pF22rQF3uEDf; Mon, 7 Dec 2020 12:10:19 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 9ECCE8781E; Mon, 7 Dec 2020 12:10:19 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8BC97C0FA7; Mon, 7 Dec 2020 12:10:19 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id E8E70C013B for ; Mon, 7 Dec 2020 12:10:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id D694587820 for ; Mon, 7 Dec 2020 12:10:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l7-LhWrkU0Rw for ; Mon, 7 Dec 2020 12:10:13 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by hemlock.osuosl.org (Postfix) with ESMTPS id 686338781E for ; Mon, 7 Dec 2020 12:10:13 +0000 (UTC) Received: from DGGEMM402-HUB.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4CqMYR1xCjz13RDD; Mon, 7 Dec 2020 20:09:15 +0800 (CST) Received: from dggema765-chm.china.huawei.com (10.1.198.207) by DGGEMM402-HUB.china.huawei.com (10.3.20.210) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 7 Dec 2020 20:10:06 +0800 Received: from [10.174.185.137] (10.174.185.137) by dggema765-chm.china.huawei.com (10.1.198.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Mon, 7 Dec 2020 20:10:05 +0800 Subject: Re: [PATCH] iommu/io-pgtalbe-arm: Remove "iopte_type(pte, l)" extra parameter "l" To: Will Deacon References: <20201207081404.1699-1-jiangkunkun@huawei.com> <20201207102458.GB3825@willie-the-truck> From: Kunkun Jiang Message-ID: <83f3f9f5-43d8-e02b-39e2-70edd42799a8@huawei.com> Date: Mon, 7 Dec 2020 20:09:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201207102458.GB3825@willie-the-truck> Content-Language: en-US X-Originating-IP: [10.174.185.137] X-ClientProxiedBy: dggeme705-chm.china.huawei.com (10.1.199.101) To dggema765-chm.china.huawei.com (10.1.198.207) X-CFilter-Loop: Reflected Cc: Keqian Zhu , open list , "open list:IOMMU DRIVERS" , wanghaibin.wang@huawei.com, Robin Murphy , "moderated list:ARM SMMU DRIVERS" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" SGkgV2lsbCwKCk9uIDIwMjAvMTIvNyAxODoyNCwgV2lsbCBEZWFjb24gd3JvdGU6Cj4gT24gTW9u LCBEZWMgMDcsIDIwMjAgYXQgMDQ6MTQ6MDRQTSArMDgwMCwgS3Vua3VuIEppYW5nIHdyb3RlOgo+ PiBLbm93aW5nIGZyb20gdGhlIGNvZGUsIHRoZSBtYWNybyAiaW9wdGVfdHlwZShwdGUsIGwpIiBk b2Vzbid0IHVzZSB0aGUKPj4gcGFyYW1ldGVyICJsIiAobGV2ZWwpLiBTbyB3ZSdkIGJldHRlciB0 byByZW1vdmUgaXQuCj4+Cj4+IEZpeGVzOiBlMWQzYzBmZDcwMWRmKGlvbW11OiBhZGQgQVJNIExQ QUUgcGFnZSB0YWJsZSBhbGxvY2F0b3IpCj4+IFNpZ25lZC1vZmYtYnk6IEt1bmt1biBKaWFuZyA8 amlhbmdrdW5rdW5AaHVhd2VpLmNvbT4KPj4gLS0tCj4+ICAgZHJpdmVycy9pb21tdS9pby1wZ3Rh YmxlLWFybS5jIHwgMiArLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBk ZWxldGlvbigtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9pb21tdS9pby1wZ3RhYmxlLWFy bS5jIGIvZHJpdmVycy9pb21tdS9pby1wZ3RhYmxlLWFybS5jCj4+IGluZGV4IGE3YTliYzA4ZGNk MS4uOTI1YWUyYjcxM2Q2IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2lvbW11L2lvLXBndGFibGUt YXJtLmMKPj4gKysrIGIvZHJpdmVycy9pb21tdS9pby1wZ3RhYmxlLWFybS5jCj4+IEBAIC0xMzAs NyArMTMwLDcgQEAKPj4gICAvKiBJT1BURSBhY2Nlc3NvcnMgKi8KPj4gICAjZGVmaW5lIGlvcHRl X2RlcmVmKHB0ZSxkKSBfX3ZhKGlvcHRlX3RvX3BhZGRyKHB0ZSwgZCkpCj4+ICAgCj4+IC0jZGVm aW5lIGlvcHRlX3R5cGUocHRlLGwpCQkJCQlcCj4+ICsjZGVmaW5lIGlvcHRlX3R5cGUocHRlKQkJ CQkJXAo+PiAgIAkoKChwdGUpID4+IEFSTV9MUEFFX1BURV9UWVBFX1NISUZUKSAmIEFSTV9MUEFF X1BURV9UWVBFX01BU0spCj4gU2hvdWxkbid0IHdlIHVwZGF0ZSBhbGwgdGhlIHVzZXJzIG9mIHRo ZSBtYWNybyB0b28/Cj4KPiBXaWxsCj4gLgoKU29ycnkgZm9yIG15IGNhcmVsZXNzbmVzcy7CoCA6 KAoKSSBoYXZlIHJlc2VudCBpdC4KCgpUaGFua3MsCgpLdW5rdW4gSmlhbmcKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlvbW11IG1haWxpbmcgbGlzdApp b21tdUBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRh dGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby9pb21tdQ== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCDCBC433FE for ; Mon, 7 Dec 2020 12:11:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90C6C23370 for ; Mon, 7 Dec 2020 12:11:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90C6C23370 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TV9S84Qtz/xBBYUsr07siII4t8SNEk+uIfgmwDRofW0=; b=pKKwFQPq/tGbTpeYiHg8sKPqT EFXPBIY1MdQ5f+7c9PNhIvr3kJ7hB4CsQQw3yD83aWEjnEjtiAQYGwz72Su8nT4UvBL7rw3pcT+Qi bX3VX/8awOc7PRQE0ybR/zBTCClBUWivdQBDsWWAgqwPkMd5FiV4rSK6GXOGYhNSzpC41HSd0CkRp zzP54hEJupKma67XZsD3MXEiD/PtXlhEjp8vec2U5qMiKD3JFbujZ+bzAkLR4k/ebZTm8LWLEZfKf N5fVlJ+oJ8SwPKqaBzsDM51dlt6ATYsGMeqB1QV52i/6KuygHlDa8XswTlU/vMRrI0vbR0Mii3GTS 3ZHwZQrXA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmFLO-0006yt-42; Mon, 07 Dec 2020 12:10:18 +0000 Received: from szxga08-in.huawei.com ([45.249.212.255]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmFLL-0006xV-AH for linux-arm-kernel@lists.infradead.org; Mon, 07 Dec 2020 12:10:16 +0000 Received: from DGGEMM402-HUB.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4CqMYR1xCjz13RDD; Mon, 7 Dec 2020 20:09:15 +0800 (CST) Received: from dggema765-chm.china.huawei.com (10.1.198.207) by DGGEMM402-HUB.china.huawei.com (10.3.20.210) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 7 Dec 2020 20:10:06 +0800 Received: from [10.174.185.137] (10.174.185.137) by dggema765-chm.china.huawei.com (10.1.198.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Mon, 7 Dec 2020 20:10:05 +0800 Subject: Re: [PATCH] iommu/io-pgtalbe-arm: Remove "iopte_type(pte, l)" extra parameter "l" To: Will Deacon References: <20201207081404.1699-1-jiangkunkun@huawei.com> <20201207102458.GB3825@willie-the-truck> From: Kunkun Jiang Message-ID: <83f3f9f5-43d8-e02b-39e2-70edd42799a8@huawei.com> Date: Mon, 7 Dec 2020 20:09:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201207102458.GB3825@willie-the-truck> Content-Language: en-US X-Originating-IP: [10.174.185.137] X-ClientProxiedBy: dggeme705-chm.china.huawei.com (10.1.199.101) To dggema765-chm.china.huawei.com (10.1.198.207) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201207_071015_614878_CB2E4C9B X-CRM114-Status: GOOD ( 14.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keqian Zhu , Joerg Roedel , open list , "open list:IOMMU DRIVERS" , wanghaibin.wang@huawei.com, Robin Murphy , "moderated list:ARM SMMU DRIVERS" Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgV2lsbCwKCk9uIDIwMjAvMTIvNyAxODoyNCwgV2lsbCBEZWFjb24gd3JvdGU6Cj4gT24gTW9u LCBEZWMgMDcsIDIwMjAgYXQgMDQ6MTQ6MDRQTSArMDgwMCwgS3Vua3VuIEppYW5nIHdyb3RlOgo+ PiBLbm93aW5nIGZyb20gdGhlIGNvZGUsIHRoZSBtYWNybyAiaW9wdGVfdHlwZShwdGUsIGwpIiBk b2Vzbid0IHVzZSB0aGUKPj4gcGFyYW1ldGVyICJsIiAobGV2ZWwpLiBTbyB3ZSdkIGJldHRlciB0 byByZW1vdmUgaXQuCj4+Cj4+IEZpeGVzOiBlMWQzYzBmZDcwMWRmKGlvbW11OiBhZGQgQVJNIExQ QUUgcGFnZSB0YWJsZSBhbGxvY2F0b3IpCj4+IFNpZ25lZC1vZmYtYnk6IEt1bmt1biBKaWFuZyA8 amlhbmdrdW5rdW5AaHVhd2VpLmNvbT4KPj4gLS0tCj4+ICAgZHJpdmVycy9pb21tdS9pby1wZ3Rh YmxlLWFybS5jIHwgMiArLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBk ZWxldGlvbigtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9pb21tdS9pby1wZ3RhYmxlLWFy bS5jIGIvZHJpdmVycy9pb21tdS9pby1wZ3RhYmxlLWFybS5jCj4+IGluZGV4IGE3YTliYzA4ZGNk MS4uOTI1YWUyYjcxM2Q2IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2lvbW11L2lvLXBndGFibGUt YXJtLmMKPj4gKysrIGIvZHJpdmVycy9pb21tdS9pby1wZ3RhYmxlLWFybS5jCj4+IEBAIC0xMzAs NyArMTMwLDcgQEAKPj4gICAvKiBJT1BURSBhY2Nlc3NvcnMgKi8KPj4gICAjZGVmaW5lIGlvcHRl X2RlcmVmKHB0ZSxkKSBfX3ZhKGlvcHRlX3RvX3BhZGRyKHB0ZSwgZCkpCj4+ICAgCj4+IC0jZGVm aW5lIGlvcHRlX3R5cGUocHRlLGwpCQkJCQlcCj4+ICsjZGVmaW5lIGlvcHRlX3R5cGUocHRlKQkJ CQkJXAo+PiAgIAkoKChwdGUpID4+IEFSTV9MUEFFX1BURV9UWVBFX1NISUZUKSAmIEFSTV9MUEFF X1BURV9UWVBFX01BU0spCj4gU2hvdWxkbid0IHdlIHVwZGF0ZSBhbGwgdGhlIHVzZXJzIG9mIHRo ZSBtYWNybyB0b28/Cj4KPiBXaWxsCj4gLgoKU29ycnkgZm9yIG15IGNhcmVsZXNzbmVzcy7CoCA6 KAoKSSBoYXZlIHJlc2VudCBpdC4KCgpUaGFua3MsCgpLdW5rdW4gSmlhbmcKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==