From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51784C61DB3 for ; Thu, 12 Jan 2023 21:59:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zV/P1KGBH0fdw31kOeSYac/VHc1MC9hfzb53dCkxmjs=; b=xK9nZdlFoLYkOP SuSvyAIuE9vxusC5zotOSEGX2kYKg/Oq6P/0NpB3Z78GqDHtyNp9YlQR+KSQipAqs0f92iMipMLj9 vnuR8k2mrTVD1AE3CRVCcl37O7U7vBSbfTkgdWbFcbp0GfhucLSUAJ44sVW0ITxOR20dHT+V4DxZK gv/SmbbN5B9FXMpTSG2LwCpfwkFvh9JRzYTGe3fOZOtCf8k+Bl41IyUv3QM0a3z7MhztcLaCd7ogR NrrYBxfkTsIh0UWCRWZV1Lddk4EFQqReokbWq3mRHggg6Cj2MycDxJV518VlBYiPPT+hHGY9alaQx 3afk8T1OaGWoeqiWqp6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pG5Zu-00HHPr-Ch; Thu, 12 Jan 2023 21:57:42 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pG5Zq-00HHNH-TZ for linux-arm-kernel@lists.infradead.org; Thu, 12 Jan 2023 21:57:40 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 9D9BC320046F; Thu, 12 Jan 2023 16:57:35 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Thu, 12 Jan 2023 16:57:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1673560655; x=1673647055; bh=s7tq5Dt4vQ 7KWmnlphnVVetcWhkbTgMUgBJi8a3V96c=; b=FH6VjcMHfmIaUgUjinAiyozgq8 CuO4EN2FoQdMnf0Q5EWOYzUaiyrRSEYyG7eW/dY4OfmjlsNMfIlDJ///YxWBVAt8 4lvsHRxNWPTvvcnFtw86rsh78eLG5wwreZzZUOrtxqKUnP6+JLHGhHHC+J41/GpY +pI7OKaf2wODzjjvvwBl3mqXq5JVtQFPLJuLHjJJNtd2ND9u/J6E2ThNKYRnnh0G sdIh5VxpF0MKNlBp+WvKpq9waN1HAZGrCYSeq/2CDgzziGkFo0pF075JN0H/0fMI Z7weZIAWaWdhVyr3ZYHSdpMUVpgoS40kkW+GnBSK3ucJyUj7cfoiOfizWr0g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1673560655; x=1673647055; bh=s7tq5Dt4vQ7KWmnlphnVVetcWhkb TgMUgBJi8a3V96c=; b=pgK/1suD/fOcIK9hUgjbK/lN103NpjOTTIAlUO7mr97V W7cdmlDu3tBreLzMVCuY2UnlnmpRw1qdawNFdwtK1IhYD3l2e8q85DwZaS6wNHBU VRZHXixN2lyT09ohcuECYWZpgF7Sb7TQNbMTs7STcKrS/KWOAxY+jG9sqWiktHwb BjuxPy9pwLTHFujXcO62FyFi/+t+gk1B1W0SYpQtke+194l/PjgkzxCfScl4yFkl 84c5WVD0p9YA7bjZ9tifo0drq8RFyxGn00QTmegdKoEUJ/64bGJlWM7GKMttASNo wDFESfuC1d34YAi+69p6duDAZQdx1A08Nq3KTKsbnQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrleeigdduheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 8C0F7B60086; Thu, 12 Jan 2023 16:57:34 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1185-g841157300a-fm-20221208.002-g84115730 Mime-Version: 1.0 Message-Id: <83f5fc9f-4b46-4ac4-ba65-455d0aaaed88@app.fastmail.com> In-Reply-To: <1E4BFECB-D29A-43CE-A521-F2A81939202F@hpe.com> References: <20230103203654.59322-1-nick.hawkins@hpe.com> <20230103203654.59322-4-nick.hawkins@hpe.com> <5ad677f3-2cbc-4ba0-bd48-2f832a72fb28@app.fastmail.com> <6bae68eb-866f-4b78-b4db-e3154feec28e@app.fastmail.com> <1E4BFECB-D29A-43CE-A521-F2A81939202F@hpe.com> Date: Thu, 12 Jan 2023 22:57:13 +0100 From: "Arnd Bergmann" To: "Hawkins, Nick" Cc: "Verdun, Jean-Marie" , "Jean Delvare" , "Guenter Roeck" , "Rob Herring" , "krzysztof.kozlowski+dt@linaro.org" , "Jonathan Corbet" , "Russell King" , "linux-hwmon@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v4 3/5] ARM: dts: add GXP Support for fans and SPI X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230112_135739_201689_B794B952 X-CRM114-Status: GOOD ( 13.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 12, 2023, at 20:58, Hawkins, Nick wrote: > The updated section of the device tree will be: > > ahb@80000000 { > compatible = "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x0 0x80000000 0xf000000>, /* > 0x80000000 - 0x8f000000 */ > <0x40000000 0xc0000000 0x40000000>; /* > 0xc0000000 - 0xffffffff */ > dma-ranges; Ok > > ... > > vic0: interrupt-controller@4eff0000 { /* 0xceff0000 */ > compatible = "arm,pl192-vic"; > reg = <0x4eff0000 0x1000>; > interrupt-controller; > #interrupt-cells = <1>; > }; > > vic1: interrupt-controller@f00000 { /* 0x80f00000 */ > compatible = "arm,pl192-vic"; > reg = <0xf00000 0x1000>; > interrupt-controller; > #interrupt-cells = <1>; > }; I still don't see the value of the /* 0x80f00000 */ comments, you should define the ranges to the most sensible mapping based on the datasheet so you don't need the comments. If the datasheet uses a bus-local address (0xf00000), then just get rid of the comment, since that only adds confusion. OTOH if the 0x80f00000 number is what is in the datasheet, then adjust the ranges to do a 1:1 mapping of the registers on the bus and use that address directly. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3FA3C54EBE for ; Thu, 12 Jan 2023 22:08:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232835AbjALWIa (ORCPT ); Thu, 12 Jan 2023 17:08:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232816AbjALWH0 (ORCPT ); Thu, 12 Jan 2023 17:07:26 -0500 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E37A167F6; Thu, 12 Jan 2023 13:57:40 -0800 (PST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 9D9BC320046F; Thu, 12 Jan 2023 16:57:35 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Thu, 12 Jan 2023 16:57:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1673560655; x=1673647055; bh=s7tq5Dt4vQ 7KWmnlphnVVetcWhkbTgMUgBJi8a3V96c=; b=FH6VjcMHfmIaUgUjinAiyozgq8 CuO4EN2FoQdMnf0Q5EWOYzUaiyrRSEYyG7eW/dY4OfmjlsNMfIlDJ///YxWBVAt8 4lvsHRxNWPTvvcnFtw86rsh78eLG5wwreZzZUOrtxqKUnP6+JLHGhHHC+J41/GpY +pI7OKaf2wODzjjvvwBl3mqXq5JVtQFPLJuLHjJJNtd2ND9u/J6E2ThNKYRnnh0G sdIh5VxpF0MKNlBp+WvKpq9waN1HAZGrCYSeq/2CDgzziGkFo0pF075JN0H/0fMI Z7weZIAWaWdhVyr3ZYHSdpMUVpgoS40kkW+GnBSK3ucJyUj7cfoiOfizWr0g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1673560655; x=1673647055; bh=s7tq5Dt4vQ7KWmnlphnVVetcWhkb TgMUgBJi8a3V96c=; b=pgK/1suD/fOcIK9hUgjbK/lN103NpjOTTIAlUO7mr97V W7cdmlDu3tBreLzMVCuY2UnlnmpRw1qdawNFdwtK1IhYD3l2e8q85DwZaS6wNHBU VRZHXixN2lyT09ohcuECYWZpgF7Sb7TQNbMTs7STcKrS/KWOAxY+jG9sqWiktHwb BjuxPy9pwLTHFujXcO62FyFi/+t+gk1B1W0SYpQtke+194l/PjgkzxCfScl4yFkl 84c5WVD0p9YA7bjZ9tifo0drq8RFyxGn00QTmegdKoEUJ/64bGJlWM7GKMttASNo wDFESfuC1d34YAi+69p6duDAZQdx1A08Nq3KTKsbnQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrleeigdduheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 8C0F7B60086; Thu, 12 Jan 2023 16:57:34 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1185-g841157300a-fm-20221208.002-g84115730 Mime-Version: 1.0 Message-Id: <83f5fc9f-4b46-4ac4-ba65-455d0aaaed88@app.fastmail.com> In-Reply-To: <1E4BFECB-D29A-43CE-A521-F2A81939202F@hpe.com> References: <20230103203654.59322-1-nick.hawkins@hpe.com> <20230103203654.59322-4-nick.hawkins@hpe.com> <5ad677f3-2cbc-4ba0-bd48-2f832a72fb28@app.fastmail.com> <6bae68eb-866f-4b78-b4db-e3154feec28e@app.fastmail.com> <1E4BFECB-D29A-43CE-A521-F2A81939202F@hpe.com> Date: Thu, 12 Jan 2023 22:57:13 +0100 From: "Arnd Bergmann" To: "Hawkins, Nick" Cc: "Verdun, Jean-Marie" , "Jean Delvare" , "Guenter Roeck" , "Rob Herring" , "krzysztof.kozlowski+dt@linaro.org" , "Jonathan Corbet" , "Russell King" , "linux-hwmon@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v4 3/5] ARM: dts: add GXP Support for fans and SPI Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Thu, Jan 12, 2023, at 20:58, Hawkins, Nick wrote: > The updated section of the device tree will be: > > ahb@80000000 { > compatible = "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x0 0x80000000 0xf000000>, /* > 0x80000000 - 0x8f000000 */ > <0x40000000 0xc0000000 0x40000000>; /* > 0xc0000000 - 0xffffffff */ > dma-ranges; Ok > > ... > > vic0: interrupt-controller@4eff0000 { /* 0xceff0000 */ > compatible = "arm,pl192-vic"; > reg = <0x4eff0000 0x1000>; > interrupt-controller; > #interrupt-cells = <1>; > }; > > vic1: interrupt-controller@f00000 { /* 0x80f00000 */ > compatible = "arm,pl192-vic"; > reg = <0xf00000 0x1000>; > interrupt-controller; > #interrupt-cells = <1>; > }; I still don't see the value of the /* 0x80f00000 */ comments, you should define the ranges to the most sensible mapping based on the datasheet so you don't need the comments. If the datasheet uses a bus-local address (0xf00000), then just get rid of the comment, since that only adds confusion. OTOH if the 0x80f00000 number is what is in the datasheet, then adjust the ranges to do a 1:1 mapping of the registers on the bus and use that address directly. Arnd