Re: [PATCH 0/6] Remove last users of v4l2-clk and remove v4l2-clk

From: Petr Cvek <petrcvekcz@gmail.com>
To: Ezequiel Garcia <ezequiel@collabora.com>,
	linux-media@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>
Cc: kernel@collabora.com, Arnd Bergmann <arnd@arndb.de>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Janusz Krzysztofik <jmkrzyszt@gmail.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: Re: [PATCH 0/6] Remove last users of v4l2-clk and remove v4l2-clk
Date: Fri, 8 Jan 2021 12:04:30 +0100	[thread overview]
Message-ID: <84055855-d84a-70e2-a9ce-88166147bc8e@gmail.com> (raw)
In-Reply-To: <3bec40b9d5b9af50c069357cc41ad0a401e5615a.camel@collabora.com>

Dne 06. 01. 21 v 15:24 Ezequiel Garcia napsal(a):
> Hi Petr,
> 
> On Tue, 2021-01-05 at 17:08 +0100, Petr Cvek wrote:
>> I don't have a working magician setup at the moment, so I can only test the compilation (which works).
>>
> 
> Thanks for the testing! Does that mean I can take your Tested-by ?

Well it was just a compilation and I don't know ov6650 nor mt9m111. And I may have some time in the next month to try it on the real device.

> 
>> Petr
>>
>> Dne 04. 01. 21 v 17:57 Ezequiel Garcia napsal(a):
>>> The V4L2 temporary clock helper API is used by just one last capture
>>> driver, pxa-camera, which registers a dummy clock; and then by just
>>> a few sensor drivers, consuming clocks through the v4l2-clk API.
>>>
>>> It's possible to convert these few last users, and so remove
>>> the v4l2-clk API, which hasn't been used for a few years.
>>>
>>> The sensor drivers are already using the CCF API,
>>> which v4l2-clk API uses as fallback.
>>>
>>> To convert the pxa-camera driver, a fixed-rate clock
>>> is registered for the mach-based platforms that still exist,
>>> for mt9m111 to work (the only sensor that PXA currently
>>> registers).
>>>
>>> Ezequiel Garcia (6):
>>>   media: mach-pxa: Register the camera sensor fixed-rate clock
>>>   media: pxa_camera: Drop the v4l2-clk clock register
>>>   media: ov9640: Use the generic clock framework
>>>   media: mt9m111: Use the generic clock framework
>>>   media: ov6650: Use the generic clock framework
>>>   media: Remove the legacy v4l2-clk API
>>>
>>>  .../driver-api/media/v4l2-clocks.rst          |  31 --
>>>  Documentation/driver-api/media/v4l2-core.rst  |   1 -
>>>  arch/arm/mach-pxa/devices.c                   |   8 +
>>>  drivers/media/i2c/mt9m111.c                   |  17 +-
>>>  drivers/media/i2c/ov6650.c                    |  26 +-
>>>  drivers/media/i2c/ov9640.c                    |  15 +-
>>>  drivers/media/i2c/ov9640.h                    |   4 +-
>>>  drivers/media/platform/pxa_camera.c           |  30 +-
>>>  drivers/media/v4l2-core/Makefile              |   2 +-
>>>  drivers/media/v4l2-core/v4l2-clk.c            | 321 ------------------
>>>  include/media/v4l2-clk.h                      |  73 ----
>>>  11 files changed, 37 insertions(+), 491 deletions(-)
>>>  delete mode 100644 Documentation/driver-api/media/v4l2-clocks.rst
>>>  delete mode 100644 drivers/media/v4l2-core/v4l2-clk.c
>>>  delete mode 100644 include/media/v4l2-clk.h
>>>
> 
> 