From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 172DAC25B0F for ; Fri, 12 Aug 2022 18:27:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239260AbiHLS12 (ORCPT ); Fri, 12 Aug 2022 14:27:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238811AbiHLS10 (ORCPT ); Fri, 12 Aug 2022 14:27:26 -0400 Received: from esa4.hgst.iphmx.com (esa4.hgst.iphmx.com [216.71.154.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F839B2DB6 for ; Fri, 12 Aug 2022 11:27:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1660328846; x=1691864846; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=J8PCRcRxT28IiRu+oG8WalqgKIw6ylYNh1g9F5tucFE=; b=ZGOo5lg1BZfUdQtKZ1z0rdAJF41G4G7RaDGED5it/o6/vOU/dAHvvL0g 7h+rWyJkfJJlU7LNITtXlT51TyV1DIlKcrYYv3hldeg6QjBg10aidinmb UFcYAwLZjuNbcuO92iSuVcjoCoxU+2pnciYp9oGrSBjuTERuFwVW5yDfg JvAXrl388RUBshrcpB3rvLmYub9db30ZkN69OKgB6w6aMiZu5lbLyNdJE oqeCEexA+ZOFlnuF/1e4z8zXinKbo2zYQshTH7TZuOl/mwUrU8H7lfwZO WSgNC61NYCwON45pRP9pdPikZfYNQRMAnwTAXIx7RZg1G6iQMGM+uy7la A==; X-IronPort-AV: E=Sophos;i="5.93,233,1654531200"; d="scan'208";a="207055467" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 13 Aug 2022 02:27:24 +0800 IronPort-SDR: edPGqUTdgIF6tEUBailpUzoR8GBaDyyBor+VziOo+vmuHBl4FiZpaFN1BcDJPPss0G2d9jSuqO JtgytsjvOwgQRwUHcVEj9gCZ/RB5jDo1djTshcDZabQ8v4QY42Ndej/xx4GJvtxDZ5C066byMn /5B9U50cKJ3KKK1XPOw41xBmInI2gqUDwmH9et3OwLOO42xAQwGo29SVn5wCOmmddDDh+iTyGB esLiKVsqzNiV79n4S2RAItNC4BUtD3PnxHRNTEprCyTV5rWjcplbKaQ7a2pEKTC3qB9NhiWoJk jEbJA/KzGLdALwov7Ayg12Ou Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Aug 2022 10:42:56 -0700 IronPort-SDR: JvroBVESL02Ngw3COow+CFhEcbqiqp+qs6O+s+Jzw2CwKff+dnTDonqr349KOg9ReKYWFNMD/z AKgzrB28x/ub1b+WG+f6fIMfllIta5CEXttcgQP6CqWgQ4e15a+2C/+ICdkmMP+ym+XPRcGVke 2O9yJ3fNU8HZYCtHL+Qk0Qkf2Q7s87hG92K4bLaDbGrYLjds9Z57k6DGN0nRFF0WNc8DBUv4pH 6Aovjoq3DvzawksXorNIdJAVZwbG1OOXsGOtbm0Um7bvamQfULCuQiwFdeoVSbEaCpGmhPPD5f A5w= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Aug 2022 11:27:24 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4M4Bwq4WJpz1Rwnx for ; Fri, 12 Aug 2022 11:27:23 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1660328842; x=1662920843; bh=J8PCRcRxT28IiRu+oG8WalqgKIw6ylYNh1g 9F5tucFE=; b=qOjZ2eJigFW0bMEdf4pTu7XkilFMPaqV8LU/rsqiMzEgNo3MD8p LJ+T/7TijflwtiaYE0Q9JqQ/07i9X3G4HfNUvtxrKFpyzh2N+CwjiYe0tCBSAARK v1DhM78Ix7hFJAJF3R0hdJkCyHo8LSzmIAEjTjy4WDBkvrVR5eRHYRrqodx0Qe4Q UEiNag8pfV2UFyNDwB0cqcMVo/Wg9KgOes7yxK7mE6U7g09iRl7N2wXmChO+7CZj pL7s64hInkI6XqVt2sgeGywtw1N1fbuMG/bfL1YDSkSFGN3DN5QP8vo+JzVwyjq7 QH32SYunbwB2VONkgLgnS48VEHs7tiLQGPg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 7nvF68674CIN for ; Fri, 12 Aug 2022 11:27:22 -0700 (PDT) Received: from [10.225.89.57] (cnd1221sqt.ad.shared [10.225.89.57]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4M4Bwn4CJGz1RtVk; Fri, 12 Aug 2022 11:27:21 -0700 (PDT) Message-ID: <840a5f98-a53c-ce08-2833-f41d8c9a015b@opensource.wdc.com> Date: Fri, 12 Aug 2022 11:27:20 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression Content-Language: en-US To: John Garry , Oliver Sang Cc: Christoph Hellwig , "Martin K. Petersen" , LKML , Linux Memory Management List , linux-ide@vger.kernel.org, lkp@lists.01.org, lkp@intel.com, ying.huang@intel.com, feng.tang@intel.com, zhengjun.xing@linux.intel.com, fengwei.yin@intel.com References: <1f498d4a-f93f-ceb4-b713-753196e5e08d@opensource.wdc.com> <3451fa5a-6229-073f-ae18-0c232cd48ed5@huawei.com> <2e9cf5a6-c043-5ccf-e363-097c6c941891@huawei.com> <4642848c-a386-d6a0-6255-8b16800e0548@opensource.wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 2022/08/12 10:17, John Garry wrote: > On 12/08/2022 16:41, Damien Le Moal wrote: >>>> we noticed the commit is already in mainline now, and in our tests, there is >>>> still similar regression and also on other platforms. >>>> could you guide us how to check "which host driver is being used for this >>>> test"? hope to supply some useful information. >>>> >>> For me, a complete kernel log may help. >> I had a look yesterday with my test rig. I did not see any difference in the >> default max_sectors_kb values for various drives between 5.18 and 5.19 (current >> linus tree). The test machine has 2 AHCI adapters: Intel and Marvell. Both use >> the regular AHCI driver. I have another rig with different ATA adapters but it >> is powered down and I am traveling... So cannot test that right now. >> > > FWIW, on QEMU I get a difference for IDE disk for ata_piix host. > > Interestingly ata dev max_sectors kb also gets capped from 32MB (LBA48) > -> 256KB due to swiotlb max mapping size. (It would be capped by shost > default max sectors 512KB without that swiotlb limit). I assume capping > due to swiotlb limit is not occuring on Oliver's machine. Yes, I was suspecting that we may be seeing a difference for anything that is not AHCI, e.g. with other drivers. But that seems to be the correct thing to do, no ? How was this working before without applying the swiotlb limit ? > > thanks, > John > > [ 1.497233] ata7: found unknown device (class 0) > [ 1.498341] ata7.00: ATA-7: QEMU HARDDISK, 2.5+, max UDMA/100 > [ 1.499030] ata7.00: 209716 sectors, multi 16: LBA48 > [ 1.623795] ata2: SATA link down (SStatus 0 SControl 300) > [ 1.624633] ata1: SATA link down (SStatus 0 SControl 300) > [ 1.633395] ata6: SATA link down (SStatus 0 SControl 300) > [ 1.634200] ata5: SATA link down (SStatus 0 SControl 300) > [ 1.635094] ata4: SATA link down (SStatus 0 SControl 300) > [ 1.635887] ata3: SATA link down (SStatus 0 SControl 300) > [ 1.636748] scsi 6:0:0:0: Direct-Access ATA QEMU HARDDISK > 2.5+ PQ: 0 ANSI: 5 > [ 1.641298] sd 6:0:0:0: [sda] 209716 512-byte logical blocks: (107 > MB/102 MiB) > [ 1.642188] sd 6:0:0:0: [sda] Write Protect is off > [ 1.642770] sd 6:0:0:0: [sda] Mode Sense: 00 3a 00 00 > [ 1.642783] sd 6:0:0:0: [sda] Write cache: enabled, read cache: > enabled, doesn't support DPO or FUA > [ 1.644149] sd 6:0:0:0: [sda] Preferred minimum I/O size 512 bytes > [ 1.645142] sd 6:0:0:0: Attached scsi generic sg0 type 0 > [ 1.655145] sd 6:0:0:0: [sda] Attached SCSI disk -- Damien Le Moal Western Digital Research From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6164224997842114532==" MIME-Version: 1.0 From: Damien Le Moal To: lkp@lists.01.org Subject: Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression Date: Fri, 12 Aug 2022 11:27:20 -0700 Message-ID: <840a5f98-a53c-ce08-2833-f41d8c9a015b@opensource.wdc.com> In-Reply-To: List-Id: --===============6164224997842114532== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 2022/08/12 10:17, John Garry wrote: > On 12/08/2022 16:41, Damien Le Moal wrote: >>>> we noticed the commit is already in mainline now, and in our tests, th= ere is >>>> still similar regression and also on other platforms. >>>> could you guide us how to check "which host driver is being used for t= his >>>> test"? hope to supply some useful information. >>>> >>> For me, a complete kernel log may help. >> I had a look yesterday with my test rig. I did not see any difference in= the >> default max_sectors_kb values for various drives between 5.18 and 5.19 (= current >> linus tree). The test machine has 2 AHCI adapters: Intel and Marvell. Bo= th use >> the regular AHCI driver. I have another rig with different ATA adapters = but it >> is powered down and I am traveling... So cannot test that right now. >> > = > FWIW, on QEMU I get a difference for IDE disk for ata_piix host. > = > Interestingly ata dev max_sectors kb also gets capped from 32MB (LBA48) = > -> 256KB due to swiotlb max mapping size. (It would be capped by shost = > default max sectors 512KB without that swiotlb limit). I assume capping = > due to swiotlb limit is not occuring on Oliver's machine. Yes, I was suspecting that we may be seeing a difference for anything that = is not AHCI, e.g. with other drivers. But that seems to be the correct thing to do, no ? How was this working bef= ore without applying the swiotlb limit ? > = > thanks, > John > = > [ 1.497233] ata7: found unknown device (class 0) > [ 1.498341] ata7.00: ATA-7: QEMU HARDDISK, 2.5+, max UDMA/100 > [ 1.499030] ata7.00: 209716 sectors, multi 16: LBA48 > [ 1.623795] ata2: SATA link down (SStatus 0 SControl 300) > [ 1.624633] ata1: SATA link down (SStatus 0 SControl 300) > [ 1.633395] ata6: SATA link down (SStatus 0 SControl 300) > [ 1.634200] ata5: SATA link down (SStatus 0 SControl 300) > [ 1.635094] ata4: SATA link down (SStatus 0 SControl 300) > [ 1.635887] ata3: SATA link down (SStatus 0 SControl 300) > [ 1.636748] scsi 6:0:0:0: Direct-Access ATA QEMU HARDDISK = > 2.5+ PQ: 0 ANSI: 5 > [ 1.641298] sd 6:0:0:0: [sda] 209716 512-byte logical blocks: (107 = > MB/102 MiB) > [ 1.642188] sd 6:0:0:0: [sda] Write Protect is off > [ 1.642770] sd 6:0:0:0: [sda] Mode Sense: 00 3a 00 00 > [ 1.642783] sd 6:0:0:0: [sda] Write cache: enabled, read cache: = > enabled, doesn't support DPO or FUA > [ 1.644149] sd 6:0:0:0: [sda] Preferred minimum I/O size 512 bytes > [ 1.645142] sd 6:0:0:0: Attached scsi generic sg0 type 0 > [ 1.655145] sd 6:0:0:0: [sda] Attached SCSI disk -- = Damien Le Moal Western Digital Research --===============6164224997842114532==--