All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [PATCH v10 14/15] HACK: drm/i915/icl: Add changes to program DSI panel GPIOs
Date: Fri,  2 Nov 2018 13:47:33 +0200	[thread overview]
Message-ID: <8417ac6254ebf466e4375f79e48d554320769fcd.1541158986.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1541158986.git.jani.nikula@intel.com>
In-Reply-To: <cover.1541158986.git.jani.nikula@intel.com>

From: Madhav Chauhan <madhav.chauhan@intel.com>

For ICELAKE DSI, Display Pins are the only GPIOs
that need to be programmed. So DSI driver should have
its own implementation to toggle these pins based on
GPIO info coming from VBT sequences instead of using
platform specific GPIO driver.

Signed-off-by: Madhav Chauhan <madhav.chauhan@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/intel_dsi_vbt.c | 38 +++++++++++++++++++++++++++++++++++-
 1 file changed, 37 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_dsi_vbt.c b/drivers/gpu/drm/i915/intel_dsi_vbt.c
index a1a8b3790e61..e6686dbdf462 100644
--- a/drivers/gpu/drm/i915/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/intel_dsi_vbt.c
@@ -339,7 +339,43 @@ static void bxt_exec_gpio(struct drm_i915_private *dev_priv,
 static void icl_exec_gpio(struct drm_i915_private *dev_priv,
 			  u8 gpio_source, u8 gpio_index, bool value)
 {
-	DRM_DEBUG_KMS("Skipping ICL GPIO element execution\n");
+	u32 val;
+
+	switch (gpio_index) {
+	case ICL_GPIO_DDSP_HPD_A:
+		val = I915_READ(SHOTPLUG_CTL_DDI);
+		val &= ~ICP_DDIA_HPD_ENABLE;
+		I915_WRITE(SHOTPLUG_CTL_DDI, val);
+		val = I915_READ(SHOTPLUG_CTL_DDI);
+
+		if (value)
+			val |= ICP_DDIA_HPD_OP_DRIVE_1;
+		else
+			val &= ~ICP_DDIA_HPD_OP_DRIVE_1;
+
+		I915_WRITE(SHOTPLUG_CTL_DDI, val);
+		break;
+	case ICL_GPIO_L_VDDEN_1:
+		val = I915_READ(ICP_PP_CONTROL(1));
+		if (value)
+			val |= PWR_STATE_TARGET;
+		else
+			val &= ~PWR_STATE_TARGET;
+		I915_WRITE(ICP_PP_CONTROL(1), val);
+		break;
+	case ICL_GPIO_L_BKLTEN_1:
+		val = I915_READ(ICP_PP_CONTROL(1));
+		if (value)
+			val |= BACKLIGHT_ENABLE;
+		else
+			val &= ~BACKLIGHT_ENABLE;
+		I915_WRITE(ICP_PP_CONTROL(1), val);
+		break;
+	default:
+		/* TODO: Add support for remaining GPIOs */
+		DRM_ERROR("Invalid GPIO no from VBT\n");
+		break;
+	}
 }
 
 static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-11-02 11:48 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-02 11:47 [PATCH v10 00/15] drm/i915/icl: dsi enabling Jani Nikula
2018-11-02 11:47 ` [PATCH v10 01/15] drm/i915/icl: Allocate DSI encoder/connector Jani Nikula
2018-11-02 11:47 ` [PATCH v10 02/15] drm/i915/icl: Fill DSI ports info Jani Nikula
2018-11-02 11:47 ` [PATCH v10 03/15] drm/i915/icl: Allocate DSI hosts and imlement host transfer Jani Nikula
2018-11-02 11:47 ` [PATCH v10 04/15] drm/i915/icl: Add get config functionality for DSI Jani Nikula
2018-11-02 11:47 ` [PATCH v10 05/15] drm/i915/icl: Get HW state for DSI encoder Jani Nikula
2018-11-02 13:30   ` Madhav Chauhan
2018-11-08 14:29   ` Lisovskiy, Stanislav
2018-11-02 11:47 ` [PATCH v10 06/15] drm/i915/icl: Add DSI encoder remaining functions Jani Nikula
2018-11-02 12:20   ` Madhav Chauhan
2018-11-02 11:47 ` [PATCH v10 07/15] drm/i915/icl: Configure DSI Dual link mode Jani Nikula
2018-11-02 11:47 ` [PATCH v10 08/15] drm/i915/icl: Consider DSI for getting transcoder state Jani Nikula
2018-11-02 11:47 ` [PATCH v10 09/15] drm/i915/icl: Get pipe timings for DSI Jani Nikula
2018-11-02 11:47 ` [PATCH v10 10/15] drm/i915/icl: Define missing bitfield for shortplug reg Jani Nikula
2018-11-02 11:47 ` [PATCH v10 11/15] drm/i915/icl: Define Panel power ctrl register Jani Nikula
2018-11-02 11:47 ` [PATCH v10 12/15] drm/i915/icl: Define display GPIO pins for DSI Jani Nikula
2018-11-02 11:47 ` [PATCH v10 13/15] drm/i915/icl: add dummy DSI GPIO element execution function Jani Nikula
2018-11-02 11:54   ` Madhav Chauhan
2018-11-02 13:10     ` Jani Nikula
2018-11-02 11:47 ` Jani Nikula [this message]
2018-11-02 11:47 ` [PATCH v10 15/15] HACK: drm/i915/icl: Configure backlight functions for DSI Jani Nikula
2018-11-02 11:49 ` [PATCH v10 00/15] drm/i915/icl: dsi enabling Jani Nikula
2018-11-02 12:26 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/icl: dsi enabling (rev5) Patchwork
2018-11-02 12:30 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-11-02 12:44 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-11-02 13:45 ` [PATCH v10 00/15] drm/i915/icl: dsi enabling Jani Nikula
2018-11-02 18:33   ` Madhav Chauhan
2018-11-03 19:16     ` Jani Nikula
2018-11-05  5:46       ` Kulkarni, Vandita
2018-11-05  9:32         ` Chauhan, Madhav
2018-11-05  9:55           ` Kulkarni, Vandita
2018-11-05 10:16             ` Chauhan, Madhav
2018-11-05 11:42               ` Kulkarni, Vandita
2018-11-02 13:47 ` ✗ Fi.CI.BAT: failure for drm/i915/icl: dsi enabling (rev5) Patchwork
2018-11-30 14:13 ` [PATCH v10 00/15] drm/i915/icl: dsi enabling Madhav Chauhan
2018-11-30 14:15   ` Chauhan, Madhav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8417ac6254ebf466e4375f79e48d554320769fcd.1541158986.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.