From: Max Reitz <mreitz@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH] hw/audio/gus: Use AUDIO_HOST_ENDIANNESS definition from 'audio/audio.h'
Date: Tue, 5 May 2020 13:09:12 +0200 [thread overview]
Message-ID: <84198b64-9b2e-f13d-f492-206b4f8331af@redhat.com> (raw)
In-Reply-To: <c55f934e-fc41-073a-fbfb-806f1b5b4527@amsat.org>
On 05.05.20 12:55, Philippe Mathieu-Daudé wrote:
> On 5/5/20 12:49 PM, Paolo Bonzini wrote:
>> On 05/05/20 12:45, Philippe Mathieu-Daudé wrote:
>>> On 5/5/20 12:10 PM, Paolo Bonzini wrote:
>>>> On 05/05/20 12:07, Philippe Mathieu-Daudé wrote:
>>>>> Use the generic AUDIO_HOST_ENDIANNESS definition instead
>>>>> of a custom one.
>>>>>
>>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>>> ---
>>>>> Who/what machine is using this device anyway?
>>>>
>>>> PC, like all old ISA audio cards.
>>>
>>> I imagined, but any particular project in mind? I'm wondering if we
>>> should add a test for it, and what kind of testing.
>>
>> Old games and demos use it. Most demos don't work that well on QEMU
>> though.
>
> Good. Cc'ing Max in case he knows a such demo we can use for testing.
I don’t know how that impression could have manifested, but I’m actually
not really an expert on old demos or games. (I just happened to write
some 512 byte stuff at some point, but the only sound I ever used there
was over the PC speaker...)
Max
next prev parent reply other threads:[~2020-05-05 11:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 10:07 [PATCH] hw/audio/gus: Use AUDIO_HOST_ENDIANNESS definition from 'audio/audio.h' Philippe Mathieu-Daudé
2020-05-05 10:10 ` Paolo Bonzini
2020-05-05 10:45 ` Philippe Mathieu-Daudé
2020-05-05 10:49 ` Paolo Bonzini
2020-05-05 10:55 ` Philippe Mathieu-Daudé
2020-05-05 11:09 ` Max Reitz [this message]
2020-05-26 6:05 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84198b64-9b2e-f13d-f492-206b4f8331af@redhat.com \
--to=mreitz@redhat.com \
--cc=f4bug@amsat.org \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.