From: Matthew Auld <matthew.auld@intel.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Matthew Brost <matthew.brost@intel.com>,
John Harrison <John.C.Harrison@Intel.com>
Subject: Re: [PATCH] drm/i915: Fix coredump of perma-pinned vmas
Date: Thu, 9 Dec 2021 17:43:27 +0000 [thread overview]
Message-ID: <841f622f-24e3-fcae-e9bd-b2bea148278a@intel.com> (raw)
In-Reply-To: <20211208082245.86933-1-thomas.hellstrom@linux.intel.com>
On 08/12/2021 08:22, Thomas Hellström wrote:
> When updating the error capture code and introducing vma snapshots,
> we introduced code to hold the vma in memory while capturing it,
> calling i915_active_acquire_if_busy(). Now that function isn't relevant
> for perma-pinned vmas and caused important vmas to be dropped from the
> coredump. Like for example the GuC log.
>
> Fix this by instead requiring those vmas to be pinned while capturing.
>
> Tested by running the initial subtests of the gem_exec_capture igt test
> with GuC submission enabled and verifying that a GuC log blob appears
> in the output.
>
> Fixes: ff20afc4cee7 ("drm/i915: Update error capture code to avoid using the current vma state")
> Cc: Ramalingam C <ramalingam.c@intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: John Harrison <John.C.Harrison@Intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Reported-by: John Harrison <John.C.Harrison@Intel.com>
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Auld <matthew.auld@intel.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix coredump of perma-pinned vmas
Date: Thu, 9 Dec 2021 17:43:27 +0000 [thread overview]
Message-ID: <841f622f-24e3-fcae-e9bd-b2bea148278a@intel.com> (raw)
In-Reply-To: <20211208082245.86933-1-thomas.hellstrom@linux.intel.com>
On 08/12/2021 08:22, Thomas Hellström wrote:
> When updating the error capture code and introducing vma snapshots,
> we introduced code to hold the vma in memory while capturing it,
> calling i915_active_acquire_if_busy(). Now that function isn't relevant
> for perma-pinned vmas and caused important vmas to be dropped from the
> coredump. Like for example the GuC log.
>
> Fix this by instead requiring those vmas to be pinned while capturing.
>
> Tested by running the initial subtests of the gem_exec_capture igt test
> with GuC submission enabled and verifying that a GuC log blob appears
> in the output.
>
> Fixes: ff20afc4cee7 ("drm/i915: Update error capture code to avoid using the current vma state")
> Cc: Ramalingam C <ramalingam.c@intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: John Harrison <John.C.Harrison@Intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Reported-by: John Harrison <John.C.Harrison@Intel.com>
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
next prev parent reply other threads:[~2021-12-09 17:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 8:22 [PATCH] drm/i915: Fix coredump of perma-pinned vmas Thomas Hellström
2021-12-08 8:22 ` [Intel-gfx] " Thomas Hellström
2021-12-08 10:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-12-08 14:28 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-12-08 19:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix coredump of perma-pinned vmas (rev2) Patchwork
2021-12-09 0:56 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-12-09 17:43 ` Matthew Auld [this message]
2021-12-09 17:43 ` [Intel-gfx] [PATCH] drm/i915: Fix coredump of perma-pinned vmas Matthew Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=841f622f-24e3-fcae-e9bd-b2bea148278a@intel.com \
--to=matthew.auld@intel.com \
--cc=John.C.Harrison@Intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.