From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C68C47258 for ; Wed, 6 May 2020 08:30:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E51B20714 for ; Wed, 6 May 2020 08:30:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="mLUoJKiQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728681AbgEFIaU (ORCPT ); Wed, 6 May 2020 04:30:20 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:59402 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728366AbgEFIaU (ORCPT ); Wed, 6 May 2020 04:30:20 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1588753818; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: References: Cc: To: Subject: From: Sender; bh=jzdjT5/FfPOTtWWCKqxudmO6PH7po5sH4MzlpxAcptc=; b=mLUoJKiQwJ1UcAVWjvEUgSGmHCWfHrw96LI9qtZWfMUlCWPZziU9j+Q/tf47sRCrOPNm6Hl3 jr4mFy0Cqji8j8gL/UeeCt7veyzSbVgWfzQZ6O3bREarmK66m2FTdWPKEHQYALYX4TYi4v6o I6TwDuIc3snOMqoxfm7oKn7pDzY= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5eb27599.7f608a93aca8-smtp-out-n04; Wed, 06 May 2020 08:30:17 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 58BC0C43636; Wed, 6 May 2020 08:30:17 +0000 (UTC) Received: from [192.168.0.102] (unknown [183.83.139.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: charante) by smtp.codeaurora.org (Postfix) with ESMTPSA id 90C41C433BA; Wed, 6 May 2020 08:30:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 90C41C433BA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=charante@codeaurora.org From: Charan Teja Kalla Subject: Re: [PATCH] dma-buf: fix use-after-free in dmabuffs_dname To: Greg KH , dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org Cc: vinmenon@codeaurora.org, sumit.semwal@linaro.org, ghackmann@google.com, fengc@google.com, linux-media@vger.kernel.org References: <1588060442-28638-1-git-send-email-charante@codeaurora.org> <20200505100806.GA4177627@kroah.com> Message-ID: <8424b2ac-3ea6-6e5b-b99c-951a569f493d@codeaurora.org> Date: Wed, 6 May 2020 14:00:10 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200505100806.GA4177627@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thank you Greg for the reply. On 5/5/2020 3:38 PM, Greg KH wrote: > On Tue, Apr 28, 2020 at 01:24:02PM +0530, Charan Teja Reddy wrote: >> The following race occurs while accessing the dmabuf object exported as >> file: >> P1 P2 >> dma_buf_release() dmabuffs_dname() >> [say lsof reading /proc//fd/] >> >> read dmabuf stored in dentry->fsdata >> Free the dmabuf object >> Start accessing the dmabuf structure >> >> In the above description, the dmabuf object freed in P1 is being >> accessed from P2 which is resulting into the use-after-free. Below is >> the dump stack reported. >> >> Call Trace: >> kasan_report+0x12/0x20 >> __asan_report_load8_noabort+0x14/0x20 >> dmabuffs_dname+0x4f4/0x560 >> tomoyo_realpath_from_path+0x165/0x660 >> tomoyo_get_realpath >> tomoyo_check_open_permission+0x2a3/0x3e0 >> tomoyo_file_open >> tomoyo_file_open+0xa9/0xd0 >> security_file_open+0x71/0x300 >> do_dentry_open+0x37a/0x1380 >> vfs_open+0xa0/0xd0 >> path_openat+0x12ee/0x3490 >> do_filp_open+0x192/0x260 >> do_sys_openat2+0x5eb/0x7e0 >> do_sys_open+0xf2/0x180 >> >> Fixes: bb2bb90 ("dma-buf: add DMA_BUF_SET_NAME ioctls") > Nit, please read the documentation for how to do a Fixes: line properly, > you need more digits: > Fixes: bb2bb9030425 ("dma-buf: add DMA_BUF_SET_NAME ioctls") Will update the patch >> Reported-by:syzbot+3643a18836bce555bff6@syzkaller.appspotmail.com >> Signed-off-by: Charan Teja Reddy > Also, any reason you didn't include the other mailing lists that > get_maintainer.pl said to? Really sorry for not sending to complete list. Added now. > And finally, no cc: stable in the s-o-b area for an issue that needs to > be backported to older kernels? Will update the patch. > >> --- >> drivers/dma-buf/dma-buf.c | 25 +++++++++++++++++++++++-- >> include/linux/dma-buf.h | 1 + >> 2 files changed, 24 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c >> index 570c923..069d8f78 100644 >> --- a/drivers/dma-buf/dma-buf.c >> +++ b/drivers/dma-buf/dma-buf.c >> @@ -25,6 +25,7 @@ >> #include >> #include >> #include >> +#include >> >> #include >> #include >> @@ -38,18 +39,34 @@ struct dma_buf_list { >> >> static struct dma_buf_list db_list; >> >> +static void dmabuf_dent_put(struct dma_buf *dmabuf) >> +{ >> + if (atomic_dec_and_test(&dmabuf->dent_count)) { >> + kfree(dmabuf->name); >> + kfree(dmabuf); >> + } > Why not just use a kref instead of an open-coded atomic value? Kref approach looks cleaner. will update the patch accordingly. >> +} >> + >> static char *dmabuffs_dname(struct dentry *dentry, char *buffer, int buflen) >> { >> struct dma_buf *dmabuf; >> char name[DMA_BUF_NAME_LEN]; >> size_t ret = 0; >> >> + spin_lock(&dentry->d_lock); >> dmabuf = dentry->d_fsdata; >> + if (!dmabuf || !atomic_add_unless(&dmabuf->dent_count, 1, 0)) { >> + spin_unlock(&dentry->d_lock); >> + goto out; > How can dmabuf not be valid here? > > And isn't there already a usecount for the buffer? dmabuf exported as file simply relies on that file's refcount, thus fput() releases the dmabuf. We are storing the dmabuf in the dentry->d_fsdata but there is no binding between the dentry and the dmabuf. So, flow will be like 1) P1 calls fput(dmabuf_fd) 2) P2 trying to access the file information of P1.     Eg: lsof command trying to list out the dmabuf_fd information using /proc//fd/dmabuf_fd 3) P1 calls the file->f_op->release(dmabuf_fd_file)(ends up in calling dma_buf_release()),   thus frees up the dmabuf buffer. 4) P2 access the dmabuf stored in the dentry->d_fsdata which was freed in step 3. So we need to have some refcount mechanism to avoid the use-after-free in step 4. >> + } >> + spin_unlock(&dentry->d_lock); >> dma_resv_lock(dmabuf->resv, NULL); >> if (dmabuf->name) >> ret = strlcpy(name, dmabuf->name, DMA_BUF_NAME_LEN); >> dma_resv_unlock(dmabuf->resv); >> + dmabuf_dent_put(dmabuf); >> >> +out: >> return dynamic_dname(dentry, buffer, buflen, "/%s:%s", >> dentry->d_name.name, ret > 0 ? name : ""); >> } >> @@ -80,12 +97,16 @@ static int dma_buf_fs_init_context(struct fs_context *fc) >> static int dma_buf_release(struct inode *inode, struct file *file) >> { >> struct dma_buf *dmabuf; >> + struct dentry *dentry = file->f_path.dentry; >> >> if (!is_dma_buf_file(file)) >> return -EINVAL; >> >> dmabuf = file->private_data; >> >> + spin_lock(&dentry->d_lock); >> + dentry->d_fsdata = NULL; >> + spin_unlock(&dentry->d_lock); >> BUG_ON(dmabuf->vmapping_counter); >> >> /* >> @@ -108,8 +129,7 @@ static int dma_buf_release(struct inode *inode, struct file *file) >> dma_resv_fini(dmabuf->resv); >> >> module_put(dmabuf->owner); >> - kfree(dmabuf->name); >> - kfree(dmabuf); >> + dmabuf_dent_put(dmabuf); >> return 0; >> } >> >> @@ -548,6 +568,7 @@ struct dma_buf *dma_buf_export(const struct dma_buf_export_info *exp_info) >> init_waitqueue_head(&dmabuf->poll); >> dmabuf->cb_excl.poll = dmabuf->cb_shared.poll = &dmabuf->poll; >> dmabuf->cb_excl.active = dmabuf->cb_shared.active = 0; >> + atomic_set(&dmabuf->dent_count, 1); >> >> if (!resv) { >> resv = (struct dma_resv *)&dmabuf[1]; >> diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h >> index 82e0a4a..a259042 100644 >> --- a/include/linux/dma-buf.h >> +++ b/include/linux/dma-buf.h >> @@ -315,6 +315,7 @@ struct dma_buf { >> struct list_head list_node; >> void *priv; >> struct dma_resv *resv; >> + atomic_t dent_count; > Isn't there other usage counters here that can support this? Adding > another one feels wrong as now we have multiple use counts, right? I couldn't see any refcount exist and couldn't find the need either, earlier. But the change bb2bb9030425 ("dma-buf: add DMA_BUF_SET_NAME ioctls") requires to have one. > thanks, > > greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 563AEC47247 for ; Thu, 7 May 2020 07:06:03 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 245C3208CA for ; Thu, 7 May 2020 07:06:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="mzFXJpXM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 245C3208CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 16F586E940; Thu, 7 May 2020 07:05:30 +0000 (UTC) Received: from mail26.static.mailgun.info (mail26.static.mailgun.info [104.130.122.26]) by gabe.freedesktop.org (Postfix) with ESMTPS id BDF1D6E82C for ; Wed, 6 May 2020 08:30:25 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1588753827; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: References: Cc: To: Subject: From: Sender; bh=jzdjT5/FfPOTtWWCKqxudmO6PH7po5sH4MzlpxAcptc=; b=mzFXJpXM+zyPqzjpJx26Nc4xQatCjaGQHlJqLsxjlM0fPjtP1h1mq7vbhRKgP4QL0rYVejU4 dYbBmPCpWMcqK4vppyWsr1pepcLYagYzqWp3tUAFzqZWG4HTv2TW3cnbdFHv+OEN+gGL9bKq pSnF5dP80ARYVaqpZraPZ4aqF7w= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5eb27599.7f54e6f7e228-smtp-out-n02; Wed, 06 May 2020 08:30:17 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 650E1C433F2; Wed, 6 May 2020 08:30:17 +0000 (UTC) Received: from [192.168.0.102] (unknown [183.83.139.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: charante) by smtp.codeaurora.org (Postfix) with ESMTPSA id 90C41C433BA; Wed, 6 May 2020 08:30:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 90C41C433BA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=charante@codeaurora.org From: Charan Teja Kalla Subject: Re: [PATCH] dma-buf: fix use-after-free in dmabuffs_dname To: Greg KH , dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org References: <1588060442-28638-1-git-send-email-charante@codeaurora.org> <20200505100806.GA4177627@kroah.com> Message-ID: <8424b2ac-3ea6-6e5b-b99c-951a569f493d@codeaurora.org> Date: Wed, 6 May 2020 14:00:10 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200505100806.GA4177627@kroah.com> Content-Language: en-US X-Mailman-Approved-At: Thu, 07 May 2020 07:05:09 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vinmenon@codeaurora.org, fengc@google.com, ghackmann@google.com, linux-media@vger.kernel.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" VGhhbmsgeW91IEdyZWcgZm9yIHRoZSByZXBseS4KCk9uIDUvNS8yMDIwIDM6MzggUE0sIEdyZWcg S0ggd3JvdGU6Cj4gT24gVHVlLCBBcHIgMjgsIDIwMjAgYXQgMDE6MjQ6MDJQTSArMDUzMCwgQ2hh cmFuIFRlamEgUmVkZHkgd3JvdGU6Cj4+IFRoZSBmb2xsb3dpbmcgcmFjZSBvY2N1cnMgd2hpbGUg YWNjZXNzaW5nIHRoZSBkbWFidWYgb2JqZWN0IGV4cG9ydGVkIGFzCj4+IGZpbGU6Cj4+IFAxCQkJ CVAyCj4+IGRtYV9idWZfcmVsZWFzZSgpICAgICAgICAgIGRtYWJ1ZmZzX2RuYW1lKCkKPj4gCQkJ ICAgW3NheSBsc29mIHJlYWRpbmcgL3Byb2MvPFAxIHBpZD4vZmQvPG51bT5dCj4+Cj4+IAkJCSAg IHJlYWQgZG1hYnVmIHN0b3JlZCBpbiBkZW50cnktPmZzZGF0YQo+PiBGcmVlIHRoZSBkbWFidWYg b2JqZWN0Cj4+IAkJCSAgIFN0YXJ0IGFjY2Vzc2luZyB0aGUgZG1hYnVmIHN0cnVjdHVyZQo+Pgo+ PiBJbiB0aGUgYWJvdmUgZGVzY3JpcHRpb24sIHRoZSBkbWFidWYgb2JqZWN0IGZyZWVkIGluIFAx IGlzIGJlaW5nCj4+IGFjY2Vzc2VkIGZyb20gUDIgd2hpY2ggaXMgcmVzdWx0aW5nIGludG8gdGhl IHVzZS1hZnRlci1mcmVlLiBCZWxvdyBpcwo+PiB0aGUgZHVtcCBzdGFjayByZXBvcnRlZC4KPj4K Pj4gQ2FsbCBUcmFjZToKPj4gICBrYXNhbl9yZXBvcnQrMHgxMi8weDIwCj4+ICAgX19hc2FuX3Jl cG9ydF9sb2FkOF9ub2Fib3J0KzB4MTQvMHgyMAo+PiAgIGRtYWJ1ZmZzX2RuYW1lKzB4NGY0LzB4 NTYwCj4+ICAgdG9tb3lvX3JlYWxwYXRoX2Zyb21fcGF0aCsweDE2NS8weDY2MAo+PiAgIHRvbW95 b19nZXRfcmVhbHBhdGgKPj4gICB0b21veW9fY2hlY2tfb3Blbl9wZXJtaXNzaW9uKzB4MmEzLzB4 M2UwCj4+ICAgdG9tb3lvX2ZpbGVfb3Blbgo+PiAgIHRvbW95b19maWxlX29wZW4rMHhhOS8weGQw Cj4+ICAgc2VjdXJpdHlfZmlsZV9vcGVuKzB4NzEvMHgzMDAKPj4gICBkb19kZW50cnlfb3Blbisw eDM3YS8weDEzODAKPj4gICB2ZnNfb3BlbisweGEwLzB4ZDAKPj4gICBwYXRoX29wZW5hdCsweDEy ZWUvMHgzNDkwCj4+ICAgZG9fZmlscF9vcGVuKzB4MTkyLzB4MjYwCj4+ICAgZG9fc3lzX29wZW5h dDIrMHg1ZWIvMHg3ZTAKPj4gICBkb19zeXNfb3BlbisweGYyLzB4MTgwCj4+Cj4+IEZpeGVzOiBi YjJiYjkwICgiZG1hLWJ1ZjogYWRkIERNQV9CVUZfU0VUX05BTUUgaW9jdGxzIikKPiBOaXQsIHBs ZWFzZSByZWFkIHRoZSBkb2N1bWVudGF0aW9uIGZvciBob3cgdG8gZG8gYSBGaXhlczogbGluZSBw cm9wZXJseSwKPiB5b3UgbmVlZCBtb3JlIGRpZ2l0czoKPiAJRml4ZXM6IGJiMmJiOTAzMDQyNSAo ImRtYS1idWY6IGFkZCBETUFfQlVGX1NFVF9OQU1FIGlvY3RscyIpCgoKV2lsbCB1cGRhdGUgdGhl IHBhdGNoCgoKPj4gUmVwb3J0ZWQtYnk6c3l6Ym90KzM2NDNhMTg4MzZiY2U1NTViZmY2QHN5emth bGxlci5hcHBzcG90bWFpbC5jb20KPj4gU2lnbmVkLW9mZi1ieTogQ2hhcmFuIFRlamEgUmVkZHk8 Y2hhcmFudGVAY29kZWF1cm9yYS5vcmc+Cj4gQWxzbywgYW55IHJlYXNvbiB5b3UgZGlkbid0IGlu Y2x1ZGUgdGhlIG90aGVyIG1haWxpbmcgbGlzdHMgdGhhdAo+IGdldF9tYWludGFpbmVyLnBsIHNh aWQgdG8/CgoKUmVhbGx5IHNvcnJ5IGZvciBub3Qgc2VuZGluZyB0byBjb21wbGV0ZSBsaXN0LiBB ZGRlZCBub3cuCgoKPiBBbmQgZmluYWxseSwgbm8gY2M6IHN0YWJsZSBpbiB0aGUgcy1vLWIgYXJl YSBmb3IgYW4gaXNzdWUgdGhhdCBuZWVkcyB0bwo+IGJlIGJhY2twb3J0ZWQgdG8gb2xkZXIga2Vy bmVscz8KCgpXaWxsIHVwZGF0ZSB0aGUgcGF0Y2guCgoKPgo+PiAtLS0KPj4gICBkcml2ZXJzL2Rt YS1idWYvZG1hLWJ1Zi5jIHwgMjUgKysrKysrKysrKysrKysrKysrKysrKystLQo+PiAgIGluY2x1 ZGUvbGludXgvZG1hLWJ1Zi5oICAgfCAgMSArCj4+ICAgMiBmaWxlcyBjaGFuZ2VkLCAyNCBpbnNl cnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9kbWEt YnVmL2RtYS1idWYuYyBiL2RyaXZlcnMvZG1hLWJ1Zi9kbWEtYnVmLmMKPj4gaW5kZXggNTcwYzky My4uMDY5ZDhmNzggMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZG1hLWJ1Zi9kbWEtYnVmLmMKPj4g KysrIGIvZHJpdmVycy9kbWEtYnVmL2RtYS1idWYuYwo+PiBAQCAtMjUsNiArMjUsNyBAQAo+PiAg ICNpbmNsdWRlIDxsaW51eC9tbS5oPgo+PiAgICNpbmNsdWRlIDxsaW51eC9tb3VudC5oPgo+PiAg ICNpbmNsdWRlIDxsaW51eC9wc2V1ZG9fZnMuaD4KPj4gKyNpbmNsdWRlIDxsaW51eC9kY2FjaGUu aD4KPj4gICAKPj4gICAjaW5jbHVkZSA8dWFwaS9saW51eC9kbWEtYnVmLmg+Cj4+ICAgI2luY2x1 ZGUgPHVhcGkvbGludXgvbWFnaWMuaD4KPj4gQEAgLTM4LDE4ICszOSwzNCBAQCBzdHJ1Y3QgZG1h X2J1Zl9saXN0IHsKPj4gICAKPj4gICBzdGF0aWMgc3RydWN0IGRtYV9idWZfbGlzdCBkYl9saXN0 Owo+PiAgIAo+PiArc3RhdGljIHZvaWQgZG1hYnVmX2RlbnRfcHV0KHN0cnVjdCBkbWFfYnVmICpk bWFidWYpCj4+ICt7Cj4+ICsJaWYgKGF0b21pY19kZWNfYW5kX3Rlc3QoJmRtYWJ1Zi0+ZGVudF9j b3VudCkpIHsKPj4gKwkJa2ZyZWUoZG1hYnVmLT5uYW1lKTsKPj4gKwkJa2ZyZWUoZG1hYnVmKTsK Pj4gKwl9Cj4gV2h5IG5vdCBqdXN0IHVzZSBhIGtyZWYgaW5zdGVhZCBvZiBhbiBvcGVuLWNvZGVk IGF0b21pYyB2YWx1ZT8KCgpLcmVmIGFwcHJvYWNoIGxvb2tzIGNsZWFuZXIuIHdpbGwgdXBkYXRl IHRoZSBwYXRjaCBhY2NvcmRpbmdseS4KCgo+PiArfQo+PiArCj4+ICAgc3RhdGljIGNoYXIgKmRt YWJ1ZmZzX2RuYW1lKHN0cnVjdCBkZW50cnkgKmRlbnRyeSwgY2hhciAqYnVmZmVyLCBpbnQgYnVm bGVuKQo+PiAgIHsKPj4gICAJc3RydWN0IGRtYV9idWYgKmRtYWJ1ZjsKPj4gICAJY2hhciBuYW1l W0RNQV9CVUZfTkFNRV9MRU5dOwo+PiAgIAlzaXplX3QgcmV0ID0gMDsKPj4gICAKPj4gKwlzcGlu X2xvY2soJmRlbnRyeS0+ZF9sb2NrKTsKPj4gICAJZG1hYnVmID0gZGVudHJ5LT5kX2ZzZGF0YTsK Pj4gKwlpZiAoIWRtYWJ1ZiB8fCAhYXRvbWljX2FkZF91bmxlc3MoJmRtYWJ1Zi0+ZGVudF9jb3Vu dCwgMSwgMCkpIHsKPj4gKwkJc3Bpbl91bmxvY2soJmRlbnRyeS0+ZF9sb2NrKTsKPj4gKwkJZ290 byBvdXQ7Cj4gSG93IGNhbiBkbWFidWYgbm90IGJlIHZhbGlkIGhlcmU/Cj4KPiBBbmQgaXNuJ3Qg dGhlcmUgYWxyZWFkeSBhIHVzZWNvdW50IGZvciB0aGUgYnVmZmVyPwoKCmRtYWJ1ZiBleHBvcnRl ZCBhcyBmaWxlIHNpbXBseSByZWxpZXMgb24gdGhhdCBmaWxlJ3MgcmVmY291bnQsIHRodXMgCmZw dXQoKSByZWxlYXNlcyB0aGUgZG1hYnVmLgoKV2UgYXJlIHN0b3JpbmcgdGhlIGRtYWJ1ZiBpbiB0 aGUgZGVudHJ5LT5kX2ZzZGF0YSBidXQgdGhlcmUgaXMgbm8gCmJpbmRpbmcgYmV0d2VlbiB0aGUg ZGVudHJ5IGFuZCB0aGUgZG1hYnVmLiBTbywgZmxvdyB3aWxsIGJlIGxpa2UKCjEpIFAxIGNhbGxz IGZwdXQoZG1hYnVmX2ZkKQoKMikgUDIgdHJ5aW5nIHRvIGFjY2VzcyB0aGUgZmlsZSBpbmZvcm1h dGlvbiBvZiBQMS4KIMKgwqDCoCBFZzogbHNvZiBjb21tYW5kIHRyeWluZyB0byBsaXN0IG91dCB0 aGUgZG1hYnVmX2ZkIGluZm9ybWF0aW9uIHVzaW5nIAovcHJvYy88UDEgcGlkPi9mZC9kbWFidWZf ZmQKCjMpIFAxIGNhbGxzIHRoZSBmaWxlLT5mX29wLT5yZWxlYXNlKGRtYWJ1Zl9mZF9maWxlKShl bmRzIHVwIGluIGNhbGxpbmcgCmRtYV9idWZfcmVsZWFzZSgpKSzCoMKgIHRodXMgZnJlZXMgdXAg dGhlIGRtYWJ1ZiBidWZmZXIuCgo0KSBQMiBhY2Nlc3MgdGhlIGRtYWJ1ZiBzdG9yZWQgaW4gdGhl IGRlbnRyeS0+ZF9mc2RhdGEgd2hpY2ggd2FzIGZyZWVkIAppbiBzdGVwIDMuCgpTbyB3ZSBuZWVk IHRvIGhhdmUgc29tZSByZWZjb3VudCBtZWNoYW5pc20gdG8gYXZvaWQgdGhlIHVzZS1hZnRlci1m cmVlIAppbiBzdGVwIDQuCgo+PiArCX0KPj4gKwlzcGluX3VubG9jaygmZGVudHJ5LT5kX2xvY2sp Owo+PiAgIAlkbWFfcmVzdl9sb2NrKGRtYWJ1Zi0+cmVzdiwgTlVMTCk7Cj4+ICAgCWlmIChkbWFi dWYtPm5hbWUpCj4+ICAgCQlyZXQgPSBzdHJsY3B5KG5hbWUsIGRtYWJ1Zi0+bmFtZSwgRE1BX0JV Rl9OQU1FX0xFTik7Cj4+ICAgCWRtYV9yZXN2X3VubG9jayhkbWFidWYtPnJlc3YpOwo+PiArCWRt YWJ1Zl9kZW50X3B1dChkbWFidWYpOwo+PiAgIAo+PiArb3V0Ogo+PiAgIAlyZXR1cm4gZHluYW1p Y19kbmFtZShkZW50cnksIGJ1ZmZlciwgYnVmbGVuLCAiLyVzOiVzIiwKPj4gICAJCQkgICAgIGRl bnRyeS0+ZF9uYW1lLm5hbWUsIHJldCA+IDAgPyBuYW1lIDogIiIpOwo+PiAgIH0KPj4gQEAgLTgw LDEyICs5NywxNiBAQCBzdGF0aWMgaW50IGRtYV9idWZfZnNfaW5pdF9jb250ZXh0KHN0cnVjdCBm c19jb250ZXh0ICpmYykKPj4gICBzdGF0aWMgaW50IGRtYV9idWZfcmVsZWFzZShzdHJ1Y3QgaW5v ZGUgKmlub2RlLCBzdHJ1Y3QgZmlsZSAqZmlsZSkKPj4gICB7Cj4+ICAgCXN0cnVjdCBkbWFfYnVm ICpkbWFidWY7Cj4+ICsJc3RydWN0IGRlbnRyeSAqZGVudHJ5ID0gZmlsZS0+Zl9wYXRoLmRlbnRy eTsKPj4gICAKPj4gICAJaWYgKCFpc19kbWFfYnVmX2ZpbGUoZmlsZSkpCj4+ICAgCQlyZXR1cm4g LUVJTlZBTDsKPj4gICAKPj4gICAJZG1hYnVmID0gZmlsZS0+cHJpdmF0ZV9kYXRhOwo+PiAgIAo+ PiArCXNwaW5fbG9jaygmZGVudHJ5LT5kX2xvY2spOwo+PiArCWRlbnRyeS0+ZF9mc2RhdGEgPSBO VUxMOwo+PiArCXNwaW5fdW5sb2NrKCZkZW50cnktPmRfbG9jayk7Cj4+ICAgCUJVR19PTihkbWFi dWYtPnZtYXBwaW5nX2NvdW50ZXIpOwo+PiAgIAo+PiAgIAkvKgo+PiBAQCAtMTA4LDggKzEyOSw3 IEBAIHN0YXRpYyBpbnQgZG1hX2J1Zl9yZWxlYXNlKHN0cnVjdCBpbm9kZSAqaW5vZGUsIHN0cnVj dCBmaWxlICpmaWxlKQo+PiAgIAkJZG1hX3Jlc3ZfZmluaShkbWFidWYtPnJlc3YpOwo+PiAgIAo+ PiAgIAltb2R1bGVfcHV0KGRtYWJ1Zi0+b3duZXIpOwo+PiAtCWtmcmVlKGRtYWJ1Zi0+bmFtZSk7 Cj4+IC0Ja2ZyZWUoZG1hYnVmKTsKPj4gKwlkbWFidWZfZGVudF9wdXQoZG1hYnVmKTsKPj4gICAJ cmV0dXJuIDA7Cj4+ICAgfQo+PiAgIAo+PiBAQCAtNTQ4LDYgKzU2OCw3IEBAIHN0cnVjdCBkbWFf YnVmICpkbWFfYnVmX2V4cG9ydChjb25zdCBzdHJ1Y3QgZG1hX2J1Zl9leHBvcnRfaW5mbyAqZXhw X2luZm8pCj4+ICAgCWluaXRfd2FpdHF1ZXVlX2hlYWQoJmRtYWJ1Zi0+cG9sbCk7Cj4+ICAgCWRt YWJ1Zi0+Y2JfZXhjbC5wb2xsID0gZG1hYnVmLT5jYl9zaGFyZWQucG9sbCA9ICZkbWFidWYtPnBv bGw7Cj4+ICAgCWRtYWJ1Zi0+Y2JfZXhjbC5hY3RpdmUgPSBkbWFidWYtPmNiX3NoYXJlZC5hY3Rp dmUgPSAwOwo+PiArCWF0b21pY19zZXQoJmRtYWJ1Zi0+ZGVudF9jb3VudCwgMSk7Cj4+ICAgCj4+ ICAgCWlmICghcmVzdikgewo+PiAgIAkJcmVzdiA9IChzdHJ1Y3QgZG1hX3Jlc3YgKikmZG1hYnVm WzFdOwo+PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9kbWEtYnVmLmggYi9pbmNsdWRlL2xp bnV4L2RtYS1idWYuaAo+PiBpbmRleCA4MmUwYTRhLi5hMjU5MDQyIDEwMDY0NAo+PiAtLS0gYS9p bmNsdWRlL2xpbnV4L2RtYS1idWYuaAo+PiArKysgYi9pbmNsdWRlL2xpbnV4L2RtYS1idWYuaAo+ PiBAQCAtMzE1LDYgKzMxNSw3IEBAIHN0cnVjdCBkbWFfYnVmIHsKPj4gICAJc3RydWN0IGxpc3Rf aGVhZCBsaXN0X25vZGU7Cj4+ICAgCXZvaWQgKnByaXY7Cj4+ICAgCXN0cnVjdCBkbWFfcmVzdiAq cmVzdjsKPj4gKwlhdG9taWNfdCBkZW50X2NvdW50Owo+IElzbid0IHRoZXJlIG90aGVyIHVzYWdl IGNvdW50ZXJzIGhlcmUgdGhhdCBjYW4gc3VwcG9ydCB0aGlzPyAgQWRkaW5nCj4gYW5vdGhlciBv bmUgZmVlbHMgd3JvbmcgYXMgbm93IHdlIGhhdmUgbXVsdGlwbGUgdXNlIGNvdW50cywgcmlnaHQ/ CgoKSSBjb3VsZG4ndCBzZWUgYW55IHJlZmNvdW50IGV4aXN0IGFuZCBjb3VsZG4ndCBmaW5kIHRo ZSBuZWVkIGVpdGhlciwgCmVhcmxpZXIuCgpCdXQgdGhlIGNoYW5nZSBiYjJiYjkwMzA0MjUgKCJk bWEtYnVmOiBhZGQgRE1BX0JVRl9TRVRfTkFNRSBpb2N0bHMiKSAKcmVxdWlyZXMgdG8gaGF2ZSBv bmUuCgoKPiB0aGFua3MsCj4KPiBncmVnIGstaApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK