From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2537C4320A for ; Tue, 31 Aug 2021 02:42:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 859F76101C for ; Tue, 31 Aug 2021 02:42:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239447AbhHaCm5 (ORCPT ); Mon, 30 Aug 2021 22:42:57 -0400 Received: from out30-57.freemail.mail.aliyun.com ([115.124.30.57]:52325 "EHLO out30-57.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236452AbhHaCmx (ORCPT ); Mon, 30 Aug 2021 22:42:53 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=yun.wang@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0Umi-x8D_1630377711; Received: from testdeMacBook-Pro.local(mailfrom:yun.wang@linux.alibaba.com fp:SMTPD_---0Umi-x8D_1630377711) by smtp.aliyun-inc.com(127.0.0.1); Tue, 31 Aug 2021 10:41:52 +0800 Subject: Re: [PATCH v2] net: fix NULL pointer reference in cipso_v4_doi_free To: Paul Moore , Jakub Kicinski Cc: "David S. Miller" , Hideaki YOSHIFUJI , David Ahern , netdev@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org References: <18f0171e-0cc8-6ae6-d04a-a69a2a3c1a39@linux.alibaba.com> <20210830094525.3c97e460@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: =?UTF-8?B?546L6LSH?= Message-ID: <84262e7b-fda6-9d7d-b0bd-1bb0e945e6f9@linux.alibaba.com> Date: Tue, 31 Aug 2021 10:41:51 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/8/31 上午12:50, Paul Moore wrote: [SNIP] >>>> Reported-by: Abaci >>>> Signed-off-by: Michael Wang >>>> --- >>>> net/netlabel/netlabel_cipso_v4.c | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> I see this was already merged, but it looks good to me, thanks for >>> making those changes. >> >> FWIW it looks like v1 was also merged: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=733c99ee8b > > Yeah, that is unfortunate, there was a brief discussion about that > over on one of the -stable patches for the v1 patch (odd that I never > saw a patchbot post for the v1 patch?). Having both merged should be > harmless, but we want to revert the v1 patch as soon as we can. > Michael, can you take care of this? As v1 already merged, may be we could just goon with it? Actually both working to fix the problem, v1 will cover all the cases, v2 take care one case since that's currently the only one, but maybe there will be more in future. Regards, Michael Wang >