From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A14CC4338F for ; Mon, 2 Aug 2021 20:05:00 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8738C61050 for ; Mon, 2 Aug 2021 20:04:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8738C61050 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A31FD82D7C; Mon, 2 Aug 2021 22:04:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="Y7/HoWsG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B72DC8339D; Mon, 2 Aug 2021 22:04:55 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 23A8280F47 for ; Mon, 2 Aug 2021 22:04:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1627934685; bh=NYHyYlsfXrgw6qp3AEXgqkUjDd7pXEg8h5Bs83Z5X1w=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Y7/HoWsGlQDOp/whuXRYLzHArgjxESud6Fb4DTLdvpWv6EXSYRfXN/jnqgl7byMLB fwGkM8EV50+lqfo8cdr3jdoNGtYVz3Wu+1SzvqFbNkmvXEztckivgMFRv9X+eiLP1/ QTqMPSFe56P+dlcXdAelGSuqDDyUwdvfnl9Xzv3Q= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.35] ([88.152.144.157]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N5mGH-1nDNLi26vb-017Fa8; Mon, 02 Aug 2021 22:04:45 +0200 Subject: Re: [PATCH 03/11] efi_loader: Use directly version_string variable To: =?UTF-8?Q?Pali_Roh=c3=a1r?= Cc: u-boot@lists.denx.de, Bin Meng , Angelo Dureghello , =?UTF-8?Q?Marek_Beh=c3=ban?= , Alexander Graf , Tom Rini , Christophe Leroy , Priyanka Jain , Wolfgang Denk , Huan Wang , Simon Glass , Ilias Apalodimas References: <20210802131838.21097-1-pali@kernel.org> <20210802131838.21097-4-pali@kernel.org> From: Heinrich Schuchardt Message-ID: <8451040c-ae23-a544-6f6b-b24bdd88c9cb@gmx.de> Date: Mon, 2 Aug 2021 22:04:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210802131838.21097-4-pali@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:1lyVWV+HHj1Hj/6cfwf0jhVhpsl5d82E/wA4p8csmDz0ddw2sba oW97A7PkQkJ7b5GeImEUmC0hoA9WCgRcTqgWZvxNjSpJAOxqDe0CUpSYx527unFE7mnu9Gd 5rF45A2Q6sccnUZb8dmYaptD0loiNLkQmUH45AMtVz2zNbzWw2N+9SwG2Dnziti16a4mNfo j+B/qvjLswgZa+zApZ5CQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:NtmmKUuJGyE=:2ww2pz6XxlfQFNicrxqSmY jeLCGEGv4mjUIwuNiNNf0xa+v0C1frKas1PE6iHNcUTLyviDC+bC4uiPHZYXRR/n7oPXJzXko Zh0oRgqh2UduNMt5OCIt6N9OnKZq3qE2Likyd41VrmrLHuicasYl9Ko3bmQNB74AIjtgO7QQD kzOEbpsvJb5ifTwQtAZQZV1HmNRTuhdaEO/dCzLnGkYwYeVhrAfcnoqd9i5MJzMMe4l1u3F4I L3lPJYWpNTgHWVx2yA/7GfaSy9KY94gNHUhMJTre1iHlVo2BFll77SpwciX/+5r8q5mZgnLD3 qjn59WH1cRpyXKHKZihOb/m1+nOw3iCGWVE055Q78iUKGs2CH5+U/pKv1MM27w2xKHVedLXrh mx2qGKwqK3SAoOJO1cTTBehhbIZZ2tXzeqLrlHEplEN/S75t4brW5c/QyLIz2ZBIWDRet9/ne MXFawRS7sexfM6Wfchngo8ZqcMtsjYEzpKg/rvfJVyj0Y8QFdLXEkKwB3PiFkkOxDF7aVAR+A NFdRTcGgvkzImlMz3sHIpw+AXcNuRyGKB7ZdaSHpN5DCfN3jpQvJYzfjQhr0hcEO+IMkBVmcy R012vzjLDk4yu9LNgG+otvrjbqcTLdnFZLxab24xNbeWoUDmESCac/Dq/8kcrKVL4j6UIl4mx HyzS1XKIif3sd0w6zQtOtkWPvzlGMZSAV4uHB3OR5oC5FqeFOtas5Ne7Ga2XuhxtbzoqIhCwL iwG0JhRLp3CwA6vpz+SLYyUdjv699FDQaJzkMmRrhnau5qpSJXjv8BGe4cBBbd0fGDDFjOvAD XlQNH3JahQ/Vcz0t7GxxrYTbLUFVTfV0nqHrKveCC5fh43ZG70qCKB4LN301UfWDGhAY0Z+2W GwmXbOed81QWtda2iyuzJ65hZ9wPhDKgk0lOTtLVfdlWk9UM78AYzYhAQXgknMyisQuSVVEEX PwcM1XQa7SFwgPXWSO3jLh4HSKTcXNNd7En+tO7WCDbg6CaCtsv9MM90cQm/P6b/zEZXHaqSe Cl7W7lb9RFyB4cLr+LEky8+Rx+RKvfSO8QamrKkdc5qMMrD0Tfc7+7tVidziSkb7Cj48Z3wyy kUkL+SgZB8iOaNh6QrodmvbX7fjUH35PWhC X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean +cc Ilias On 8/2/21 3:18 PM, Pali Roh=C3=A1r wrote: > Macro U_BOOT_VERSION_STRING is already stored in variable version_string= . > So use directly this variable instead of storing U_BOOT_VERSION_STRING i= nto > temporary variable. > > Signed-off-by: Pali Roh=C3=A1r > --- > lib/efi_loader/efi_tcg2.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/lib/efi_loader/efi_tcg2.c b/lib/efi_loader/efi_tcg2.c > index 1319a8b37868..14353ae71c9b 100644 > --- a/lib/efi_loader/efi_tcg2.c > +++ b/lib/efi_loader/efi_tcg2.c > @@ -1275,11 +1275,10 @@ free_pool: > static efi_status_t efi_append_scrtm_version(struct udevice *dev) > { > struct tpml_digest_values digest_list; > - u8 ver[] =3D U_BOOT_VERSION_STRING; > const int pcr_index =3D 0; > efi_status_t ret; > > - ret =3D tcg2_create_digest(ver, sizeof(ver), &digest_list); > + ret =3D tcg2_create_digest(version_string, strlen(version_string) + 1,= &digest_list); > if (ret !=3D EFI_SUCCESS) > goto out; > > @@ -1288,7 +1287,7 @@ static efi_status_t efi_append_scrtm_version(struc= t udevice *dev) > goto out; > > ret =3D tcg2_agile_log_append(pcr_index, EV_S_CRTM_VERSION, &digest_l= ist, > - sizeof(ver), ver); > + strlen(version_string) + 1, version_string); > > out: > return ret; >