From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753017AbdC0No7 (ORCPT ); Mon, 27 Mar 2017 09:44:59 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:34526 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752147AbdC0No5 (ORCPT ); Mon, 27 Mar 2017 09:44:57 -0400 Subject: Re: [PATCH 0/7] dwc3 - bug fixes and use meaningful goto labels To: Felipe Balbi , gregkh@linuxfoundation.org, kgene@kernel.org, krzk@kernel.org, javier@osg.samsung.com References: <87poh523r3.fsf@linux.intel.com> Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org, Shuah Khan From: Shuah Khan Message-ID: <8477b3ae-7841-db0b-1faa-7c0dfa452082@osg.samsung.com> Date: Mon, 27 Mar 2017 07:44:26 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <87poh523r3.fsf@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/25/2017 01:51 AM, Felipe Balbi wrote: > > Hi, > > Shuah Khan writes: >> This patch series consists of two fixes and changes to goto labels > > we *NEVER* put cleanups and fixes together. > >> to use meaningful names. >> >> While working on goto label changes, I noticed put_sync calls without >> successful get_sync in error legs. The first two patches are the fixes >> and the rest of the patches are goto label changes. > > so, you mean to say that you're adding regressions because you *THOUGHT* > there was a bug there, right? Read the docs ;-) > Sorry for the noise. Thanks for pointing this out. -- Shuah From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuah Khan Subject: Re: [PATCH 0/7] dwc3 - bug fixes and use meaningful goto labels Date: Mon, 27 Mar 2017 07:44:26 -0600 Message-ID: <8477b3ae-7841-db0b-1faa-7c0dfa452082@osg.samsung.com> References: <87poh523r3.fsf@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87poh523r3.fsf@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Felipe Balbi , gregkh@linuxfoundation.org, kgene@kernel.org, krzk@kernel.org, javier@osg.samsung.com Cc: linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org On 03/25/2017 01:51 AM, Felipe Balbi wrote: > > Hi, > > Shuah Khan writes: >> This patch series consists of two fixes and changes to goto labels > > we *NEVER* put cleanups and fixes together. > >> to use meaningful names. >> >> While working on goto label changes, I noticed put_sync calls without >> successful get_sync in error legs. The first two patches are the fixes >> and the rest of the patches are goto label changes. > > so, you mean to say that you're adding regressions because you *THOUGHT* > there was a bug there, right? Read the docs ;-) > Sorry for the noise. Thanks for pointing this out. -- Shuah From mboxrd@z Thu Jan 1 00:00:00 1970 From: shuahkh@osg.samsung.com (Shuah Khan) Date: Mon, 27 Mar 2017 07:44:26 -0600 Subject: [PATCH 0/7] dwc3 - bug fixes and use meaningful goto labels In-Reply-To: <87poh523r3.fsf@linux.intel.com> References: <87poh523r3.fsf@linux.intel.com> Message-ID: <8477b3ae-7841-db0b-1faa-7c0dfa452082@osg.samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/25/2017 01:51 AM, Felipe Balbi wrote: > > Hi, > > Shuah Khan writes: >> This patch series consists of two fixes and changes to goto labels > > we *NEVER* put cleanups and fixes together. > >> to use meaningful names. >> >> While working on goto label changes, I noticed put_sync calls without >> successful get_sync in error legs. The first two patches are the fixes >> and the rest of the patches are goto label changes. > > so, you mean to say that you're adding regressions because you *THOUGHT* > there was a bug there, right? Read the docs ;-) > Sorry for the noise. Thanks for pointing this out. -- Shuah