From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753025AbcFVPwC (ORCPT ); Wed, 22 Jun 2016 11:52:02 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:57327 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752993AbcFVPv7 (ORCPT ); Wed, 22 Jun 2016 11:51:59 -0400 From: Arnd Bergmann To: Christoph Hellwig Cc: "Nicholas A. Bellinger" , Jens Axboe , Mike Christie , Andy Grover , Hannes Reinecke , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] target/iblock: use ilog2 to compute block size Date: Wed, 22 Jun 2016 17:53:01 +0200 Message-ID: <8480462.cSbQVM4ZJM@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160622133809.GA29657@infradead.org> References: <20160622125534.1267407-1-arnd@arndb.de> <20160622133809.GA29657@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:tyGPu7kA0NnGlbcKzyUNWEZne9phq7dVRMTrKBgRHE0UNH6gCdL h5frw5pcXWgQb/q9wymEjzYy/zUWhkz1nIAb2zoz0bb8ZAEexLjhO87OeX+awneY7Nu7JLY TzDt8U3d6FeyYGFmfNs9wnRhHgmC4LRZuiRd6VMu1m30Lu0mNxIlofyUdoX6I9IgmmlFsC9 w60Yy9ZyXF3DmTuv5PSWQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:fftPA7Vfbro=:s3Y7CGNHj3kEyzPrwXoOQJ HAosY6H2JFPuCIL6r9gmYHm2mq6fQkMMSNwgaUkdwZzuc5DQF2QpmcXn35MAwageEq36s26Gp 72Stf+eeioUCHU0CX9LwVKQm5Grf0i5Y1qgwVJO0F0YGeulcFoqzNl2MP+nYUqBZd+9lCLVLi 2uj6ryR2T6dn8ISaXIF1TReXbRDduvnDjCySMkBwn6bz4d9tKurFQnguBFmHTMotToZSu//uN F6bueDVmTTuPZN6c7kkvxigldidwWsR3YwVrtfVWQ4CEMMKm+bNfKl8Sll6emHTnJoIg1nhRQ 0mVxpDM5oZGdp3XoZkli7+0fk5gko5Vfuub8GxzF5qpOgOGASnfpcvVT4RF0I3tSkBOPnvaU0 i07iJtEH9Mu/9Rxu/WSG386dfA5DgZ7/P6+adq+9DjZU32nqDKf3okr0n1zxASd3cE0OmCxE3 cJSD526AXfkhNuZu4w5EDWTWJI9qYvv6UV/zmjvr2klv+uX1oR4bG5HTbdUNOAdTxvGlgiaMm SzY9j2HHRpva8HmzOsgTFvZaKiWdovkKJR6x/z8jbYjYk+f9gIolVlRKJX9409apXS24lKYno S7uy8cgHiWNiGlVuRLisesoUESKfSqPmnu2uL2M4u4r587PF68pmheyexNXjG1BLlKfRHiYW3 OrTTlZf5UKpP1L8+XXStgk+0FoUqqYYw3L9S+dT6wGXZXwgPNB3y2txlVGXnaMO8s4qiTc+38 QKDGwdr+NC8FCdB6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, June 22, 2016 6:38:09 AM CEST Christoph Hellwig wrote: > This doesn't compute the block size, it computes the number of block > in a block device. Right, that's at least what I planned to put in the $subject ;-) > I think it would be useful to add a generic helper > (e.g. in blkdev.h) as this calculation seems to be open coded in various > places. Good idea, I'll try to come up with a patch for that. Arnd