All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
@ 2019-10-22 15:38 ` Aaron Ma
  0 siblings, 0 replies; 22+ messages in thread
From: Aaron Ma @ 2019-10-22 15:38 UTC (permalink / raw)
  To: perex, tiwai, kailang, hui.wang, alsa-devel, aaron.ma, linux-kernel

These 2 ThinkCentres installed a new realtek codec ID 0x623,
it has 2 front mics with the same location on pin 0x18 and 0x19.

Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic
location to right, then pulseaudio can handle them.
One "Front Mic" and one "Mic" will be shown, and audio output works
fine.

Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b000b36ac3c6..c34d8b435f58 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7186,6 +7186,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
 	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
 	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
 	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
 	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
@@ -9187,6 +9189,7 @@ static const struct hda_device_id snd_hda_id_realtek[] = {
 	HDA_CODEC_ENTRY(0x10ec0298, "ALC298", patch_alc269),
 	HDA_CODEC_ENTRY(0x10ec0299, "ALC299", patch_alc269),
 	HDA_CODEC_ENTRY(0x10ec0300, "ALC300", patch_alc269),
+	HDA_CODEC_ENTRY(0x10ec0623, "ALC623", patch_alc269),
 	HDA_CODEC_REV_ENTRY(0x10ec0861, 0x100340, "ALC660", patch_alc861),
 	HDA_CODEC_ENTRY(0x10ec0660, "ALC660-VD", patch_alc861vd),
 	HDA_CODEC_ENTRY(0x10ec0861, "ALC861", patch_alc861),
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [alsa-devel] [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
@ 2019-10-22 15:38 ` Aaron Ma
  0 siblings, 0 replies; 22+ messages in thread
From: Aaron Ma @ 2019-10-22 15:38 UTC (permalink / raw)
  To: perex, tiwai, kailang, hui.wang, alsa-devel, aaron.ma, linux-kernel

These 2 ThinkCentres installed a new realtek codec ID 0x623,
it has 2 front mics with the same location on pin 0x18 and 0x19.

Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic
location to right, then pulseaudio can handle them.
One "Front Mic" and one "Mic" will be shown, and audio output works
fine.

Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b000b36ac3c6..c34d8b435f58 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7186,6 +7186,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
 	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
 	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
 	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
 	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
@@ -9187,6 +9189,7 @@ static const struct hda_device_id snd_hda_id_realtek[] = {
 	HDA_CODEC_ENTRY(0x10ec0298, "ALC298", patch_alc269),
 	HDA_CODEC_ENTRY(0x10ec0299, "ALC299", patch_alc269),
 	HDA_CODEC_ENTRY(0x10ec0300, "ALC300", patch_alc269),
+	HDA_CODEC_ENTRY(0x10ec0623, "ALC623", patch_alc269),
 	HDA_CODEC_REV_ENTRY(0x10ec0861, 0x100340, "ALC660", patch_alc861),
 	HDA_CODEC_ENTRY(0x10ec0660, "ALC660-VD", patch_alc861vd),
 	HDA_CODEC_ENTRY(0x10ec0861, "ALC861", patch_alc861),
-- 
2.17.1

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
  2019-10-22 15:38 ` [alsa-devel] " Aaron Ma
@ 2019-10-22 16:08   ` Takashi Iwai
  -1 siblings, 0 replies; 22+ messages in thread
From: Takashi Iwai @ 2019-10-22 16:08 UTC (permalink / raw)
  To: Aaron Ma; +Cc: perex, kailang, hui.wang, alsa-devel, linux-kernel

On Tue, 22 Oct 2019 17:38:55 +0200,
Aaron Ma wrote:
> 
> These 2 ThinkCentres installed a new realtek codec ID 0x623,
> it has 2 front mics with the same location on pin 0x18 and 0x19.
> 
> Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic
> location to right, then pulseaudio can handle them.
> One "Front Mic" and one "Mic" will be shown, and audio output works
> fine.
> 
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>

I'd like to have Kailang's review about the new codec before
applying.

Kailang, could you take a look?


thanks,

Takashi

> ---
>  sound/pci/hda/patch_realtek.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index b000b36ac3c6..c34d8b435f58 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -7186,6 +7186,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
>  	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
>  	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
> +	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
> +	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
>  	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
>  	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
>  	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
> @@ -9187,6 +9189,7 @@ static const struct hda_device_id snd_hda_id_realtek[] = {
>  	HDA_CODEC_ENTRY(0x10ec0298, "ALC298", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0299, "ALC299", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0300, "ALC300", patch_alc269),
> +	HDA_CODEC_ENTRY(0x10ec0623, "ALC623", patch_alc269),
>  	HDA_CODEC_REV_ENTRY(0x10ec0861, 0x100340, "ALC660", patch_alc861),
>  	HDA_CODEC_ENTRY(0x10ec0660, "ALC660-VD", patch_alc861vd),
>  	HDA_CODEC_ENTRY(0x10ec0861, "ALC861", patch_alc861),
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [alsa-devel] [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
@ 2019-10-22 16:08   ` Takashi Iwai
  0 siblings, 0 replies; 22+ messages in thread
From: Takashi Iwai @ 2019-10-22 16:08 UTC (permalink / raw)
  To: Aaron Ma; +Cc: hui.wang, alsa-devel, kailang, linux-kernel

On Tue, 22 Oct 2019 17:38:55 +0200,
Aaron Ma wrote:
> 
> These 2 ThinkCentres installed a new realtek codec ID 0x623,
> it has 2 front mics with the same location on pin 0x18 and 0x19.
> 
> Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic
> location to right, then pulseaudio can handle them.
> One "Front Mic" and one "Mic" will be shown, and audio output works
> fine.
> 
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>

I'd like to have Kailang's review about the new codec before
applying.

Kailang, could you take a look?


thanks,

Takashi

> ---
>  sound/pci/hda/patch_realtek.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index b000b36ac3c6..c34d8b435f58 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -7186,6 +7186,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
>  	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
>  	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
> +	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
> +	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
>  	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
>  	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
>  	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
> @@ -9187,6 +9189,7 @@ static const struct hda_device_id snd_hda_id_realtek[] = {
>  	HDA_CODEC_ENTRY(0x10ec0298, "ALC298", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0299, "ALC299", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0300, "ALC300", patch_alc269),
> +	HDA_CODEC_ENTRY(0x10ec0623, "ALC623", patch_alc269),
>  	HDA_CODEC_REV_ENTRY(0x10ec0861, 0x100340, "ALC660", patch_alc861),
>  	HDA_CODEC_ENTRY(0x10ec0660, "ALC660-VD", patch_alc861vd),
>  	HDA_CODEC_ENTRY(0x10ec0861, "ALC861", patch_alc861),
> -- 
> 2.17.1
> 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 22+ messages in thread

* RE: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
  2019-10-22 16:08   ` [alsa-devel] " Takashi Iwai
@ 2019-10-23  8:44     ` Kailang
  -1 siblings, 0 replies; 22+ messages in thread
From: Kailang @ 2019-10-23  8:44 UTC (permalink / raw)
  To: Takashi Iwai, Aaron Ma; +Cc: perex, hui.wang, alsa-devel, linux-kernel



> -----Original Message-----
> From: Takashi Iwai <tiwai@suse.de>
> Sent: Wednesday, October 23, 2019 12:08 AM
> To: Aaron Ma <aaron.ma@canonical.com>
> Cc: perex@perex.cz; Kailang <kailang@realtek.com>;
> hui.wang@canonical.com; alsa-devel@alsa-project.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
> 
> On Tue, 22 Oct 2019 17:38:55 +0200,
> Aaron Ma wrote:
> >
> > These 2 ThinkCentres installed a new realtek codec ID 0x623, it has 2
> > front mics with the same location on pin 0x18 and 0x19.
> >
> > Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic location to
> > right, then pulseaudio can handle them.
> > One "Front Mic" and one "Mic" will be shown, and audio output works
> > fine.
> >
> > Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> 
> I'd like to have Kailang's review about the new codec before applying.
> 
> Kailang, could you take a look?
OK.
I will post you the patch for ALC623 codec tomorrow.
Thanks.

> 
> 
> thanks,
> 
> Takashi
> 
> > ---
> >  sound/pci/hda/patch_realtek.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/sound/pci/hda/patch_realtek.c
> > b/sound/pci/hda/patch_realtek.c index b000b36ac3c6..c34d8b435f58
> > 100644
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -7186,6 +7186,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[]
> = {
> >  	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station",
> ALC294_FIXUP_LENOVO_MIC_LOCATION),
> >  	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station",
> ALC294_FIXUP_LENOVO_MIC_LOCATION),
> >  	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station",
> > ALC283_FIXUP_HEADSET_MIC),
> > +	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station",
> ALC283_FIXUP_HEADSET_MIC),
> > +	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station",
> > +ALC283_FIXUP_HEADSET_MIC),
> >  	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80",
> ALC269_FIXUP_DMIC_THINKPAD_ACPI),
> >  	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210",
> ALC283_FIXUP_INT_MIC),
> >  	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70",
> > ALC269_FIXUP_DMIC_THINKPAD_ACPI), @@ -9187,6 +9189,7 @@ static
> const struct hda_device_id snd_hda_id_realtek[] = {
> >  	HDA_CODEC_ENTRY(0x10ec0298, "ALC298", patch_alc269),
> >  	HDA_CODEC_ENTRY(0x10ec0299, "ALC299", patch_alc269),
> >  	HDA_CODEC_ENTRY(0x10ec0300, "ALC300", patch_alc269),
> > +	HDA_CODEC_ENTRY(0x10ec0623, "ALC623", patch_alc269),
> >  	HDA_CODEC_REV_ENTRY(0x10ec0861, 0x100340, "ALC660",
> patch_alc861),
> >  	HDA_CODEC_ENTRY(0x10ec0660, "ALC660-VD", patch_alc861vd),
> >  	HDA_CODEC_ENTRY(0x10ec0861, "ALC861", patch_alc861),
> > --
> > 2.17.1
> >
> 
> ------Please consider the environment before printing this e-mail.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [alsa-devel] [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
@ 2019-10-23  8:44     ` Kailang
  0 siblings, 0 replies; 22+ messages in thread
From: Kailang @ 2019-10-23  8:44 UTC (permalink / raw)
  To: Takashi Iwai, Aaron Ma; +Cc: hui.wang, alsa-devel, linux-kernel



> -----Original Message-----
> From: Takashi Iwai <tiwai@suse.de>
> Sent: Wednesday, October 23, 2019 12:08 AM
> To: Aaron Ma <aaron.ma@canonical.com>
> Cc: perex@perex.cz; Kailang <kailang@realtek.com>;
> hui.wang@canonical.com; alsa-devel@alsa-project.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
> 
> On Tue, 22 Oct 2019 17:38:55 +0200,
> Aaron Ma wrote:
> >
> > These 2 ThinkCentres installed a new realtek codec ID 0x623, it has 2
> > front mics with the same location on pin 0x18 and 0x19.
> >
> > Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic location to
> > right, then pulseaudio can handle them.
> > One "Front Mic" and one "Mic" will be shown, and audio output works
> > fine.
> >
> > Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> 
> I'd like to have Kailang's review about the new codec before applying.
> 
> Kailang, could you take a look?
OK.
I will post you the patch for ALC623 codec tomorrow.
Thanks.

> 
> 
> thanks,
> 
> Takashi
> 
> > ---
> >  sound/pci/hda/patch_realtek.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/sound/pci/hda/patch_realtek.c
> > b/sound/pci/hda/patch_realtek.c index b000b36ac3c6..c34d8b435f58
> > 100644
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -7186,6 +7186,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[]
> = {
> >  	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station",
> ALC294_FIXUP_LENOVO_MIC_LOCATION),
> >  	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station",
> ALC294_FIXUP_LENOVO_MIC_LOCATION),
> >  	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station",
> > ALC283_FIXUP_HEADSET_MIC),
> > +	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station",
> ALC283_FIXUP_HEADSET_MIC),
> > +	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station",
> > +ALC283_FIXUP_HEADSET_MIC),
> >  	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80",
> ALC269_FIXUP_DMIC_THINKPAD_ACPI),
> >  	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210",
> ALC283_FIXUP_INT_MIC),
> >  	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70",
> > ALC269_FIXUP_DMIC_THINKPAD_ACPI), @@ -9187,6 +9189,7 @@ static
> const struct hda_device_id snd_hda_id_realtek[] = {
> >  	HDA_CODEC_ENTRY(0x10ec0298, "ALC298", patch_alc269),
> >  	HDA_CODEC_ENTRY(0x10ec0299, "ALC299", patch_alc269),
> >  	HDA_CODEC_ENTRY(0x10ec0300, "ALC300", patch_alc269),
> > +	HDA_CODEC_ENTRY(0x10ec0623, "ALC623", patch_alc269),
> >  	HDA_CODEC_REV_ENTRY(0x10ec0861, 0x100340, "ALC660",
> patch_alc861),
> >  	HDA_CODEC_ENTRY(0x10ec0660, "ALC660-VD", patch_alc861vd),
> >  	HDA_CODEC_ENTRY(0x10ec0861, "ALC861", patch_alc861),
> > --
> > 2.17.1
> >
> 
> ------Please consider the environment before printing this e-mail.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
  2019-10-23  8:44     ` [alsa-devel] " Kailang
@ 2019-10-23 10:06       ` Aaron Ma
  -1 siblings, 0 replies; 22+ messages in thread
From: Aaron Ma @ 2019-10-23 10:06 UTC (permalink / raw)
  To: Kailang, Takashi Iwai; +Cc: perex, hui.wang, alsa-devel, linux-kernel

On 10/23/19 4:44 PM, Kailang wrote:
> 
> 
>> -----Original Message-----
>> From: Takashi Iwai <tiwai@suse.de>
>> Sent: Wednesday, October 23, 2019 12:08 AM
>> To: Aaron Ma <aaron.ma@canonical.com>
>> Cc: perex@perex.cz; Kailang <kailang@realtek.com>;
>> hui.wang@canonical.com; alsa-devel@alsa-project.org;
>> linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
>>
>> On Tue, 22 Oct 2019 17:38:55 +0200,
>> Aaron Ma wrote:
>>>
>>> These 2 ThinkCentres installed a new realtek codec ID 0x623, it has 2
>>> front mics with the same location on pin 0x18 and 0x19.
>>>
>>> Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic location to
>>> right, then pulseaudio can handle them.
>>> One "Front Mic" and one "Mic" will be shown, and audio output works
>>> fine.
>>>
>>> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
>>
>> I'd like to have Kailang's review about the new codec before applying.
>>
>> Kailang, could you take a look?
> OK.
> I will post you the patch for ALC623 codec tomorrow.
> Thanks.

Cc me too.

Thank you.
Aaron

> 
>>
>>
>> thanks,
>>
>> Takashi
>>
>>> ---
>>>  sound/pci/hda/patch_realtek.c | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/sound/pci/hda/patch_realtek.c
>>> b/sound/pci/hda/patch_realtek.c index b000b36ac3c6..c34d8b435f58
>>> 100644
>>> --- a/sound/pci/hda/patch_realtek.c
>>> +++ b/sound/pci/hda/patch_realtek.c
>>> @@ -7186,6 +7186,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[]
>> = {
>>>  	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station",
>> ALC294_FIXUP_LENOVO_MIC_LOCATION),
>>>  	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station",
>> ALC294_FIXUP_LENOVO_MIC_LOCATION),
>>>  	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station",
>>> ALC283_FIXUP_HEADSET_MIC),
>>> +	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station",
>> ALC283_FIXUP_HEADSET_MIC),
>>> +	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station",
>>> +ALC283_FIXUP_HEADSET_MIC),
>>>  	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80",
>> ALC269_FIXUP_DMIC_THINKPAD_ACPI),
>>>  	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210",
>> ALC283_FIXUP_INT_MIC),
>>>  	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70",
>>> ALC269_FIXUP_DMIC_THINKPAD_ACPI), @@ -9187,6 +9189,7 @@ static
>> const struct hda_device_id snd_hda_id_realtek[] = {
>>>  	HDA_CODEC_ENTRY(0x10ec0298, "ALC298", patch_alc269),
>>>  	HDA_CODEC_ENTRY(0x10ec0299, "ALC299", patch_alc269),
>>>  	HDA_CODEC_ENTRY(0x10ec0300, "ALC300", patch_alc269),
>>> +	HDA_CODEC_ENTRY(0x10ec0623, "ALC623", patch_alc269),
>>>  	HDA_CODEC_REV_ENTRY(0x10ec0861, 0x100340, "ALC660",
>> patch_alc861),
>>>  	HDA_CODEC_ENTRY(0x10ec0660, "ALC660-VD", patch_alc861vd),
>>>  	HDA_CODEC_ENTRY(0x10ec0861, "ALC861", patch_alc861),
>>> --
>>> 2.17.1
>>>
>>
>> ------Please consider the environment before printing this e-mail.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [alsa-devel] [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
@ 2019-10-23 10:06       ` Aaron Ma
  0 siblings, 0 replies; 22+ messages in thread
From: Aaron Ma @ 2019-10-23 10:06 UTC (permalink / raw)
  To: Kailang, Takashi Iwai; +Cc: hui.wang, alsa-devel, linux-kernel

On 10/23/19 4:44 PM, Kailang wrote:
> 
> 
>> -----Original Message-----
>> From: Takashi Iwai <tiwai@suse.de>
>> Sent: Wednesday, October 23, 2019 12:08 AM
>> To: Aaron Ma <aaron.ma@canonical.com>
>> Cc: perex@perex.cz; Kailang <kailang@realtek.com>;
>> hui.wang@canonical.com; alsa-devel@alsa-project.org;
>> linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
>>
>> On Tue, 22 Oct 2019 17:38:55 +0200,
>> Aaron Ma wrote:
>>>
>>> These 2 ThinkCentres installed a new realtek codec ID 0x623, it has 2
>>> front mics with the same location on pin 0x18 and 0x19.
>>>
>>> Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic location to
>>> right, then pulseaudio can handle them.
>>> One "Front Mic" and one "Mic" will be shown, and audio output works
>>> fine.
>>>
>>> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
>>
>> I'd like to have Kailang's review about the new codec before applying.
>>
>> Kailang, could you take a look?
> OK.
> I will post you the patch for ALC623 codec tomorrow.
> Thanks.

Cc me too.

Thank you.
Aaron

> 
>>
>>
>> thanks,
>>
>> Takashi
>>
>>> ---
>>>  sound/pci/hda/patch_realtek.c | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/sound/pci/hda/patch_realtek.c
>>> b/sound/pci/hda/patch_realtek.c index b000b36ac3c6..c34d8b435f58
>>> 100644
>>> --- a/sound/pci/hda/patch_realtek.c
>>> +++ b/sound/pci/hda/patch_realtek.c
>>> @@ -7186,6 +7186,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[]
>> = {
>>>  	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station",
>> ALC294_FIXUP_LENOVO_MIC_LOCATION),
>>>  	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station",
>> ALC294_FIXUP_LENOVO_MIC_LOCATION),
>>>  	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station",
>>> ALC283_FIXUP_HEADSET_MIC),
>>> +	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station",
>> ALC283_FIXUP_HEADSET_MIC),
>>> +	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station",
>>> +ALC283_FIXUP_HEADSET_MIC),
>>>  	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80",
>> ALC269_FIXUP_DMIC_THINKPAD_ACPI),
>>>  	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210",
>> ALC283_FIXUP_INT_MIC),
>>>  	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70",
>>> ALC269_FIXUP_DMIC_THINKPAD_ACPI), @@ -9187,6 +9189,7 @@ static
>> const struct hda_device_id snd_hda_id_realtek[] = {
>>>  	HDA_CODEC_ENTRY(0x10ec0298, "ALC298", patch_alc269),
>>>  	HDA_CODEC_ENTRY(0x10ec0299, "ALC299", patch_alc269),
>>>  	HDA_CODEC_ENTRY(0x10ec0300, "ALC300", patch_alc269),
>>> +	HDA_CODEC_ENTRY(0x10ec0623, "ALC623", patch_alc269),
>>>  	HDA_CODEC_REV_ENTRY(0x10ec0861, 0x100340, "ALC660",
>> patch_alc861),
>>>  	HDA_CODEC_ENTRY(0x10ec0660, "ALC660-VD", patch_alc861vd),
>>>  	HDA_CODEC_ENTRY(0x10ec0861, "ALC861", patch_alc861),
>>> --
>>> 2.17.1
>>>
>>
>> ------Please consider the environment before printing this e-mail.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 22+ messages in thread

* RE: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
  2019-10-23 10:06       ` [alsa-devel] " Aaron Ma
@ 2019-10-24  7:20         ` Kailang
  -1 siblings, 0 replies; 22+ messages in thread
From: Kailang @ 2019-10-24  7:20 UTC (permalink / raw)
  To: Aaron Ma, Takashi Iwai; +Cc: perex, hui.wang, alsa-devel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 3557 bytes --]

Hi Takashi,

Attach patch was support ALC623.

BR,
Kailang

> -----Original Message-----
> From: Aaron Ma <aaron.ma@canonical.com>
> Sent: Wednesday, October 23, 2019 6:06 PM
> To: Kailang <kailang@realtek.com>; Takashi Iwai <tiwai@suse.de>
> Cc: perex@perex.cz; hui.wang@canonical.com; alsa-devel@alsa-project.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
> 
> On 10/23/19 4:44 PM, Kailang wrote:
> >
> >
> >> -----Original Message-----
> >> From: Takashi Iwai <tiwai@suse.de>
> >> Sent: Wednesday, October 23, 2019 12:08 AM
> >> To: Aaron Ma <aaron.ma@canonical.com>
> >> Cc: perex@perex.cz; Kailang <kailang@realtek.com>;
> >> hui.wang@canonical.com; alsa-devel@alsa-project.org;
> >> linux-kernel@vger.kernel.org
> >> Subject: Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec
> >> 0x623
> >>
> >> On Tue, 22 Oct 2019 17:38:55 +0200,
> >> Aaron Ma wrote:
> >>>
> >>> These 2 ThinkCentres installed a new realtek codec ID 0x623, it has
> >>> 2 front mics with the same location on pin 0x18 and 0x19.
> >>>
> >>> Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic location
> >>> to right, then pulseaudio can handle them.
> >>> One "Front Mic" and one "Mic" will be shown, and audio output works
> >>> fine.
> >>>
> >>> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> >>
> >> I'd like to have Kailang's review about the new codec before applying.
> >>
> >> Kailang, could you take a look?
> > OK.
> > I will post you the patch for ALC623 codec tomorrow.
> > Thanks.
> 
> Cc me too.
> 
> Thank you.
> Aaron
> 
> >
> >>
> >>
> >> thanks,
> >>
> >> Takashi
> >>
> >>> ---
> >>>  sound/pci/hda/patch_realtek.c | 3 +++
> >>>  1 file changed, 3 insertions(+)
> >>>
> >>> diff --git a/sound/pci/hda/patch_realtek.c
> >>> b/sound/pci/hda/patch_realtek.c index b000b36ac3c6..c34d8b435f58
> >>> 100644
> >>> --- a/sound/pci/hda/patch_realtek.c
> >>> +++ b/sound/pci/hda/patch_realtek.c
> >>> @@ -7186,6 +7186,8 @@ static const struct snd_pci_quirk
> >>> alc269_fixup_tbl[]
> >> = {
> >>>  	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station",
> >> ALC294_FIXUP_LENOVO_MIC_LOCATION),
> >>>  	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station",
> >> ALC294_FIXUP_LENOVO_MIC_LOCATION),
> >>>  	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station",
> >>> ALC283_FIXUP_HEADSET_MIC),
> >>> +	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station",
> >> ALC283_FIXUP_HEADSET_MIC),
> >>> +	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station",
> >>> +ALC283_FIXUP_HEADSET_MIC),
> >>>  	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80",
> >> ALC269_FIXUP_DMIC_THINKPAD_ACPI),
> >>>  	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210",
> >> ALC283_FIXUP_INT_MIC),
> >>>  	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70",
> >>> ALC269_FIXUP_DMIC_THINKPAD_ACPI), @@ -9187,6 +9189,7 @@ static
> >> const struct hda_device_id snd_hda_id_realtek[] = {
> >>>  	HDA_CODEC_ENTRY(0x10ec0298, "ALC298", patch_alc269),
> >>>  	HDA_CODEC_ENTRY(0x10ec0299, "ALC299", patch_alc269),
> >>>  	HDA_CODEC_ENTRY(0x10ec0300, "ALC300", patch_alc269),
> >>> +	HDA_CODEC_ENTRY(0x10ec0623, "ALC623", patch_alc269),
> >>>  	HDA_CODEC_REV_ENTRY(0x10ec0861, 0x100340, "ALC660",
> >> patch_alc861),
> >>>  	HDA_CODEC_ENTRY(0x10ec0660, "ALC660-VD", patch_alc861vd),
> >>>  	HDA_CODEC_ENTRY(0x10ec0861, "ALC861", patch_alc861),
> >>> --
> >>> 2.17.1
> >>>
> >>
> >> ------Please consider the environment before printing this e-mail.

[-- Attachment #2: 0000-add-support-alc623.patch --]
[-- Type: application/octet-stream, Size: 1990 bytes --]

From 3103f6683093e47368d87671f3726f1a11f9ef28 Mon Sep 17 00:00:00 2001
From: Kailang Yang <kailang@realtek.com>
Date: Thu, 24 Oct 2019 15:13:32 +0800
Subject: [PATCH] ALSA: hda/realtek - Add support for ALC623

Support new codec ALC623.

Signed-off-by: Kailang Yang <kailang@realtek.com>

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 085a2f95e076..a0c237cc13d4 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -409,6 +409,9 @@ static void alc_fill_eapd_coef(struct hda_codec *codec)
 	case 0x10ec0672:
 		alc_update_coef_idx(codec, 0xd, 0, 1<<14); /* EAPD Ctrl */
 		break;
+	case 0x10ec0623:
+		alc_update_coef_idx(codec, 0x19, 1<<13, 0);
+		break;
 	case 0x10ec0668:
 		alc_update_coef_idx(codec, 0x7, 3<<13, 0);
 		break;
@@ -2920,6 +2923,7 @@ enum {
 	ALC269_TYPE_ALC225,
 	ALC269_TYPE_ALC294,
 	ALC269_TYPE_ALC300,
+	ALC269_TYPE_ALC623,
 	ALC269_TYPE_ALC700,
 };
 
@@ -2955,6 +2959,7 @@ static int alc269_parse_auto_config(struct hda_codec *codec)
 	case ALC269_TYPE_ALC225:
 	case ALC269_TYPE_ALC294:
 	case ALC269_TYPE_ALC300:
+	case ALC269_TYPE_ALC623:
 	case ALC269_TYPE_ALC700:
 		ssids = alc269_ssids;
 		break;
@@ -8017,6 +8022,9 @@ static int patch_alc269(struct hda_codec *codec)
 		spec->codec_variant = ALC269_TYPE_ALC300;
 		spec->gen.mixer_nid = 0; /* no loopback on ALC300 */
 		break;
+	case 0x10ec0623:
+		spec->codec_variant = ALC269_TYPE_ALC623;
+		break;
 	case 0x10ec0700:
 	case 0x10ec0701:
 	case 0x10ec0703:
@@ -9218,6 +9226,7 @@ static const struct hda_device_id snd_hda_id_realtek[] = {
 	HDA_CODEC_ENTRY(0x10ec0298, "ALC298", patch_alc269),
 	HDA_CODEC_ENTRY(0x10ec0299, "ALC299", patch_alc269),
 	HDA_CODEC_ENTRY(0x10ec0300, "ALC300", patch_alc269),
+	HDA_CODEC_ENTRY(0x10ec0623, "ALC623", patch_alc269),
 	HDA_CODEC_REV_ENTRY(0x10ec0861, 0x100340, "ALC660", patch_alc861),
 	HDA_CODEC_ENTRY(0x10ec0660, "ALC660-VD", patch_alc861vd),
 	HDA_CODEC_ENTRY(0x10ec0861, "ALC861", patch_alc861),

^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [alsa-devel] [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
@ 2019-10-24  7:20         ` Kailang
  0 siblings, 0 replies; 22+ messages in thread
From: Kailang @ 2019-10-24  7:20 UTC (permalink / raw)
  To: Aaron Ma, Takashi Iwai; +Cc: hui.wang, alsa-devel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 3557 bytes --]

Hi Takashi,

Attach patch was support ALC623.

BR,
Kailang

> -----Original Message-----
> From: Aaron Ma <aaron.ma@canonical.com>
> Sent: Wednesday, October 23, 2019 6:06 PM
> To: Kailang <kailang@realtek.com>; Takashi Iwai <tiwai@suse.de>
> Cc: perex@perex.cz; hui.wang@canonical.com; alsa-devel@alsa-project.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
> 
> On 10/23/19 4:44 PM, Kailang wrote:
> >
> >
> >> -----Original Message-----
> >> From: Takashi Iwai <tiwai@suse.de>
> >> Sent: Wednesday, October 23, 2019 12:08 AM
> >> To: Aaron Ma <aaron.ma@canonical.com>
> >> Cc: perex@perex.cz; Kailang <kailang@realtek.com>;
> >> hui.wang@canonical.com; alsa-devel@alsa-project.org;
> >> linux-kernel@vger.kernel.org
> >> Subject: Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec
> >> 0x623
> >>
> >> On Tue, 22 Oct 2019 17:38:55 +0200,
> >> Aaron Ma wrote:
> >>>
> >>> These 2 ThinkCentres installed a new realtek codec ID 0x623, it has
> >>> 2 front mics with the same location on pin 0x18 and 0x19.
> >>>
> >>> Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic location
> >>> to right, then pulseaudio can handle them.
> >>> One "Front Mic" and one "Mic" will be shown, and audio output works
> >>> fine.
> >>>
> >>> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> >>
> >> I'd like to have Kailang's review about the new codec before applying.
> >>
> >> Kailang, could you take a look?
> > OK.
> > I will post you the patch for ALC623 codec tomorrow.
> > Thanks.
> 
> Cc me too.
> 
> Thank you.
> Aaron
> 
> >
> >>
> >>
> >> thanks,
> >>
> >> Takashi
> >>
> >>> ---
> >>>  sound/pci/hda/patch_realtek.c | 3 +++
> >>>  1 file changed, 3 insertions(+)
> >>>
> >>> diff --git a/sound/pci/hda/patch_realtek.c
> >>> b/sound/pci/hda/patch_realtek.c index b000b36ac3c6..c34d8b435f58
> >>> 100644
> >>> --- a/sound/pci/hda/patch_realtek.c
> >>> +++ b/sound/pci/hda/patch_realtek.c
> >>> @@ -7186,6 +7186,8 @@ static const struct snd_pci_quirk
> >>> alc269_fixup_tbl[]
> >> = {
> >>>  	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station",
> >> ALC294_FIXUP_LENOVO_MIC_LOCATION),
> >>>  	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station",
> >> ALC294_FIXUP_LENOVO_MIC_LOCATION),
> >>>  	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station",
> >>> ALC283_FIXUP_HEADSET_MIC),
> >>> +	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station",
> >> ALC283_FIXUP_HEADSET_MIC),
> >>> +	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station",
> >>> +ALC283_FIXUP_HEADSET_MIC),
> >>>  	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80",
> >> ALC269_FIXUP_DMIC_THINKPAD_ACPI),
> >>>  	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210",
> >> ALC283_FIXUP_INT_MIC),
> >>>  	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70",
> >>> ALC269_FIXUP_DMIC_THINKPAD_ACPI), @@ -9187,6 +9189,7 @@ static
> >> const struct hda_device_id snd_hda_id_realtek[] = {
> >>>  	HDA_CODEC_ENTRY(0x10ec0298, "ALC298", patch_alc269),
> >>>  	HDA_CODEC_ENTRY(0x10ec0299, "ALC299", patch_alc269),
> >>>  	HDA_CODEC_ENTRY(0x10ec0300, "ALC300", patch_alc269),
> >>> +	HDA_CODEC_ENTRY(0x10ec0623, "ALC623", patch_alc269),
> >>>  	HDA_CODEC_REV_ENTRY(0x10ec0861, 0x100340, "ALC660",
> >> patch_alc861),
> >>>  	HDA_CODEC_ENTRY(0x10ec0660, "ALC660-VD", patch_alc861vd),
> >>>  	HDA_CODEC_ENTRY(0x10ec0861, "ALC861", patch_alc861),
> >>> --
> >>> 2.17.1
> >>>
> >>
> >> ------Please consider the environment before printing this e-mail.

[-- Attachment #2: 0000-add-support-alc623.patch --]
[-- Type: application/octet-stream, Size: 1990 bytes --]

From 3103f6683093e47368d87671f3726f1a11f9ef28 Mon Sep 17 00:00:00 2001
From: Kailang Yang <kailang@realtek.com>
Date: Thu, 24 Oct 2019 15:13:32 +0800
Subject: [PATCH] ALSA: hda/realtek - Add support for ALC623

Support new codec ALC623.

Signed-off-by: Kailang Yang <kailang@realtek.com>

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 085a2f95e076..a0c237cc13d4 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -409,6 +409,9 @@ static void alc_fill_eapd_coef(struct hda_codec *codec)
 	case 0x10ec0672:
 		alc_update_coef_idx(codec, 0xd, 0, 1<<14); /* EAPD Ctrl */
 		break;
+	case 0x10ec0623:
+		alc_update_coef_idx(codec, 0x19, 1<<13, 0);
+		break;
 	case 0x10ec0668:
 		alc_update_coef_idx(codec, 0x7, 3<<13, 0);
 		break;
@@ -2920,6 +2923,7 @@ enum {
 	ALC269_TYPE_ALC225,
 	ALC269_TYPE_ALC294,
 	ALC269_TYPE_ALC300,
+	ALC269_TYPE_ALC623,
 	ALC269_TYPE_ALC700,
 };
 
@@ -2955,6 +2959,7 @@ static int alc269_parse_auto_config(struct hda_codec *codec)
 	case ALC269_TYPE_ALC225:
 	case ALC269_TYPE_ALC294:
 	case ALC269_TYPE_ALC300:
+	case ALC269_TYPE_ALC623:
 	case ALC269_TYPE_ALC700:
 		ssids = alc269_ssids;
 		break;
@@ -8017,6 +8022,9 @@ static int patch_alc269(struct hda_codec *codec)
 		spec->codec_variant = ALC269_TYPE_ALC300;
 		spec->gen.mixer_nid = 0; /* no loopback on ALC300 */
 		break;
+	case 0x10ec0623:
+		spec->codec_variant = ALC269_TYPE_ALC623;
+		break;
 	case 0x10ec0700:
 	case 0x10ec0701:
 	case 0x10ec0703:
@@ -9218,6 +9226,7 @@ static const struct hda_device_id snd_hda_id_realtek[] = {
 	HDA_CODEC_ENTRY(0x10ec0298, "ALC298", patch_alc269),
 	HDA_CODEC_ENTRY(0x10ec0299, "ALC299", patch_alc269),
 	HDA_CODEC_ENTRY(0x10ec0300, "ALC300", patch_alc269),
+	HDA_CODEC_ENTRY(0x10ec0623, "ALC623", patch_alc269),
 	HDA_CODEC_REV_ENTRY(0x10ec0861, 0x100340, "ALC660", patch_alc861),
 	HDA_CODEC_ENTRY(0x10ec0660, "ALC660-VD", patch_alc861vd),
 	HDA_CODEC_ENTRY(0x10ec0861, "ALC861", patch_alc861),

[-- Attachment #3: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
  2019-10-24  7:20         ` [alsa-devel] " Kailang
@ 2019-10-24 10:35           ` Takashi Iwai
  -1 siblings, 0 replies; 22+ messages in thread
From: Takashi Iwai @ 2019-10-24 10:35 UTC (permalink / raw)
  To: Kailang; +Cc: Aaron Ma, perex, hui.wang, alsa-devel, linux-kernel

On Thu, 24 Oct 2019 09:20:19 +0200,
Kailang wrote:
> 
> Hi Takashi,
> 
> Attach patch was support ALC623.

Thanks, applied now.

Aaron, could you rebase your patch and resubmit?


Takashi

> 
> BR,
> Kailang
> 
> > -----Original Message-----
> > From: Aaron Ma <aaron.ma@canonical.com>
> > Sent: Wednesday, October 23, 2019 6:06 PM
> > To: Kailang <kailang@realtek.com>; Takashi Iwai <tiwai@suse.de>
> > Cc: perex@perex.cz; hui.wang@canonical.com; alsa-devel@alsa-project.org;
> > linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
> > 
> > On 10/23/19 4:44 PM, Kailang wrote:
> > >
> > >
> > >> -----Original Message-----
> > >> From: Takashi Iwai <tiwai@suse.de>
> > >> Sent: Wednesday, October 23, 2019 12:08 AM
> > >> To: Aaron Ma <aaron.ma@canonical.com>
> > >> Cc: perex@perex.cz; Kailang <kailang@realtek.com>;
> > >> hui.wang@canonical.com; alsa-devel@alsa-project.org;
> > >> linux-kernel@vger.kernel.org
> > >> Subject: Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec
> > >> 0x623
> > >>
> > >> On Tue, 22 Oct 2019 17:38:55 +0200,
> > >> Aaron Ma wrote:
> > >>>
> > >>> These 2 ThinkCentres installed a new realtek codec ID 0x623, it has
> > >>> 2 front mics with the same location on pin 0x18 and 0x19.
> > >>>
> > >>> Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic location
> > >>> to right, then pulseaudio can handle them.
> > >>> One "Front Mic" and one "Mic" will be shown, and audio output works
> > >>> fine.
> > >>>
> > >>> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> > >>
> > >> I'd like to have Kailang's review about the new codec before applying.
> > >>
> > >> Kailang, could you take a look?
> > > OK.
> > > I will post you the patch for ALC623 codec tomorrow.
> > > Thanks.
> > 
> > Cc me too.
> > 
> > Thank you.
> > Aaron
> > 
> > >
> > >>
> > >>
> > >> thanks,
> > >>
> > >> Takashi
> > >>
> > >>> ---
> > >>>  sound/pci/hda/patch_realtek.c | 3 +++
> > >>>  1 file changed, 3 insertions(+)
> > >>>
> > >>> diff --git a/sound/pci/hda/patch_realtek.c
> > >>> b/sound/pci/hda/patch_realtek.c index b000b36ac3c6..c34d8b435f58
> > >>> 100644
> > >>> --- a/sound/pci/hda/patch_realtek.c
> > >>> +++ b/sound/pci/hda/patch_realtek.c
> > >>> @@ -7186,6 +7186,8 @@ static const struct snd_pci_quirk
> > >>> alc269_fixup_tbl[]
> > >> = {
> > >>>  	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station",
> > >> ALC294_FIXUP_LENOVO_MIC_LOCATION),
> > >>>  	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station",
> > >> ALC294_FIXUP_LENOVO_MIC_LOCATION),
> > >>>  	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station",
> > >>> ALC283_FIXUP_HEADSET_MIC),
> > >>> +	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station",
> > >> ALC283_FIXUP_HEADSET_MIC),
> > >>> +	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station",
> > >>> +ALC283_FIXUP_HEADSET_MIC),
> > >>>  	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80",
> > >> ALC269_FIXUP_DMIC_THINKPAD_ACPI),
> > >>>  	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210",
> > >> ALC283_FIXUP_INT_MIC),
> > >>>  	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70",
> > >>> ALC269_FIXUP_DMIC_THINKPAD_ACPI), @@ -9187,6 +9189,7 @@ static
> > >> const struct hda_device_id snd_hda_id_realtek[] = {
> > >>>  	HDA_CODEC_ENTRY(0x10ec0298, "ALC298", patch_alc269),
> > >>>  	HDA_CODEC_ENTRY(0x10ec0299, "ALC299", patch_alc269),
> > >>>  	HDA_CODEC_ENTRY(0x10ec0300, "ALC300", patch_alc269),
> > >>> +	HDA_CODEC_ENTRY(0x10ec0623, "ALC623", patch_alc269),
> > >>>  	HDA_CODEC_REV_ENTRY(0x10ec0861, 0x100340, "ALC660",
> > >> patch_alc861),
> > >>>  	HDA_CODEC_ENTRY(0x10ec0660, "ALC660-VD", patch_alc861vd),
> > >>>  	HDA_CODEC_ENTRY(0x10ec0861, "ALC861", patch_alc861),
> > >>> --
> > >>> 2.17.1
> > >>>
> > >>
> > >> ------Please consider the environment before printing this e-mail.
> [2 0000-add-support-alc623.patch <application/octet-stream (base64)>]
> 

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [alsa-devel] [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
@ 2019-10-24 10:35           ` Takashi Iwai
  0 siblings, 0 replies; 22+ messages in thread
From: Takashi Iwai @ 2019-10-24 10:35 UTC (permalink / raw)
  To: Kailang; +Cc: Aaron Ma, hui.wang, alsa-devel, linux-kernel

On Thu, 24 Oct 2019 09:20:19 +0200,
Kailang wrote:
> 
> Hi Takashi,
> 
> Attach patch was support ALC623.

Thanks, applied now.

Aaron, could you rebase your patch and resubmit?


Takashi

> 
> BR,
> Kailang
> 
> > -----Original Message-----
> > From: Aaron Ma <aaron.ma@canonical.com>
> > Sent: Wednesday, October 23, 2019 6:06 PM
> > To: Kailang <kailang@realtek.com>; Takashi Iwai <tiwai@suse.de>
> > Cc: perex@perex.cz; hui.wang@canonical.com; alsa-devel@alsa-project.org;
> > linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
> > 
> > On 10/23/19 4:44 PM, Kailang wrote:
> > >
> > >
> > >> -----Original Message-----
> > >> From: Takashi Iwai <tiwai@suse.de>
> > >> Sent: Wednesday, October 23, 2019 12:08 AM
> > >> To: Aaron Ma <aaron.ma@canonical.com>
> > >> Cc: perex@perex.cz; Kailang <kailang@realtek.com>;
> > >> hui.wang@canonical.com; alsa-devel@alsa-project.org;
> > >> linux-kernel@vger.kernel.org
> > >> Subject: Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec
> > >> 0x623
> > >>
> > >> On Tue, 22 Oct 2019 17:38:55 +0200,
> > >> Aaron Ma wrote:
> > >>>
> > >>> These 2 ThinkCentres installed a new realtek codec ID 0x623, it has
> > >>> 2 front mics with the same location on pin 0x18 and 0x19.
> > >>>
> > >>> Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic location
> > >>> to right, then pulseaudio can handle them.
> > >>> One "Front Mic" and one "Mic" will be shown, and audio output works
> > >>> fine.
> > >>>
> > >>> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> > >>
> > >> I'd like to have Kailang's review about the new codec before applying.
> > >>
> > >> Kailang, could you take a look?
> > > OK.
> > > I will post you the patch for ALC623 codec tomorrow.
> > > Thanks.
> > 
> > Cc me too.
> > 
> > Thank you.
> > Aaron
> > 
> > >
> > >>
> > >>
> > >> thanks,
> > >>
> > >> Takashi
> > >>
> > >>> ---
> > >>>  sound/pci/hda/patch_realtek.c | 3 +++
> > >>>  1 file changed, 3 insertions(+)
> > >>>
> > >>> diff --git a/sound/pci/hda/patch_realtek.c
> > >>> b/sound/pci/hda/patch_realtek.c index b000b36ac3c6..c34d8b435f58
> > >>> 100644
> > >>> --- a/sound/pci/hda/patch_realtek.c
> > >>> +++ b/sound/pci/hda/patch_realtek.c
> > >>> @@ -7186,6 +7186,8 @@ static const struct snd_pci_quirk
> > >>> alc269_fixup_tbl[]
> > >> = {
> > >>>  	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station",
> > >> ALC294_FIXUP_LENOVO_MIC_LOCATION),
> > >>>  	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station",
> > >> ALC294_FIXUP_LENOVO_MIC_LOCATION),
> > >>>  	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station",
> > >>> ALC283_FIXUP_HEADSET_MIC),
> > >>> +	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station",
> > >> ALC283_FIXUP_HEADSET_MIC),
> > >>> +	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station",
> > >>> +ALC283_FIXUP_HEADSET_MIC),
> > >>>  	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80",
> > >> ALC269_FIXUP_DMIC_THINKPAD_ACPI),
> > >>>  	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210",
> > >> ALC283_FIXUP_INT_MIC),
> > >>>  	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70",
> > >>> ALC269_FIXUP_DMIC_THINKPAD_ACPI), @@ -9187,6 +9189,7 @@ static
> > >> const struct hda_device_id snd_hda_id_realtek[] = {
> > >>>  	HDA_CODEC_ENTRY(0x10ec0298, "ALC298", patch_alc269),
> > >>>  	HDA_CODEC_ENTRY(0x10ec0299, "ALC299", patch_alc269),
> > >>>  	HDA_CODEC_ENTRY(0x10ec0300, "ALC300", patch_alc269),
> > >>> +	HDA_CODEC_ENTRY(0x10ec0623, "ALC623", patch_alc269),
> > >>>  	HDA_CODEC_REV_ENTRY(0x10ec0861, 0x100340, "ALC660",
> > >> patch_alc861),
> > >>>  	HDA_CODEC_ENTRY(0x10ec0660, "ALC660-VD", patch_alc861vd),
> > >>>  	HDA_CODEC_ENTRY(0x10ec0861, "ALC861", patch_alc861),
> > >>> --
> > >>> 2.17.1
> > >>>
> > >>
> > >> ------Please consider the environment before printing this e-mail.
> [2 0000-add-support-alc623.patch <application/octet-stream (base64)>]
> 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
  2019-10-24 10:35           ` [alsa-devel] " Takashi Iwai
@ 2019-10-24 10:54             ` Aaron Ma
  -1 siblings, 0 replies; 22+ messages in thread
From: Aaron Ma @ 2019-10-24 10:54 UTC (permalink / raw)
  To: Takashi Iwai, Kailang; +Cc: perex, hui.wang, alsa-devel, linux-kernel

On 10/24/19 6:35 PM, Takashi Iwai wrote:
> On Thu, 24 Oct 2019 09:20:19 +0200,
> Kailang wrote:
>>
>> Hi Takashi,
>>
>> Attach patch was support ALC623.
> 
> Thanks, applied now.
> 
> Aaron, could you rebase your patch and resubmit?
> 
> 

Yes I will.
One line of same changes.

Thanks,
Aaron

> Takashi
> 
>>
>> BR,
>> Kailang
>>
>>> -----Original Message-----
>>> From: Aaron Ma <aaron.ma@canonical.com>
>>> Sent: Wednesday, October 23, 2019 6:06 PM
>>> To: Kailang <kailang@realtek.com>; Takashi Iwai <tiwai@suse.de>
>>> Cc: perex@perex.cz; hui.wang@canonical.com; alsa-devel@alsa-project.org;
>>> linux-kernel@vger.kernel.org
>>> Subject: Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
>>>
>>> On 10/23/19 4:44 PM, Kailang wrote:
>>>>
>>>>
>>>>> -----Original Message-----
>>>>> From: Takashi Iwai <tiwai@suse.de>
>>>>> Sent: Wednesday, October 23, 2019 12:08 AM
>>>>> To: Aaron Ma <aaron.ma@canonical.com>
>>>>> Cc: perex@perex.cz; Kailang <kailang@realtek.com>;
>>>>> hui.wang@canonical.com; alsa-devel@alsa-project.org;
>>>>> linux-kernel@vger.kernel.org
>>>>> Subject: Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec
>>>>> 0x623
>>>>>
>>>>> On Tue, 22 Oct 2019 17:38:55 +0200,
>>>>> Aaron Ma wrote:
>>>>>>
>>>>>> These 2 ThinkCentres installed a new realtek codec ID 0x623, it has
>>>>>> 2 front mics with the same location on pin 0x18 and 0x19.
>>>>>>
>>>>>> Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic location
>>>>>> to right, then pulseaudio can handle them.
>>>>>> One "Front Mic" and one "Mic" will be shown, and audio output works
>>>>>> fine.
>>>>>>
>>>>>> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
>>>>>
>>>>> I'd like to have Kailang's review about the new codec before applying.
>>>>>
>>>>> Kailang, could you take a look?
>>>> OK.
>>>> I will post you the patch for ALC623 codec tomorrow.
>>>> Thanks.
>>>
>>> Cc me too.
>>>
>>> Thank you.
>>> Aaron
>>>
>>>>
>>>>>
>>>>>
>>>>> thanks,
>>>>>
>>>>> Takashi
>>>>>
>>>>>> ---
>>>>>>  sound/pci/hda/patch_realtek.c | 3 +++
>>>>>>  1 file changed, 3 insertions(+)
>>>>>>
>>>>>> diff --git a/sound/pci/hda/patch_realtek.c
>>>>>> b/sound/pci/hda/patch_realtek.c index b000b36ac3c6..c34d8b435f58
>>>>>> 100644
>>>>>> --- a/sound/pci/hda/patch_realtek.c
>>>>>> +++ b/sound/pci/hda/patch_realtek.c
>>>>>> @@ -7186,6 +7186,8 @@ static const struct snd_pci_quirk
>>>>>> alc269_fixup_tbl[]
>>>>> = {
>>>>>>  	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station",
>>>>> ALC294_FIXUP_LENOVO_MIC_LOCATION),
>>>>>>  	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station",
>>>>> ALC294_FIXUP_LENOVO_MIC_LOCATION),
>>>>>>  	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station",
>>>>>> ALC283_FIXUP_HEADSET_MIC),
>>>>>> +	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station",
>>>>> ALC283_FIXUP_HEADSET_MIC),
>>>>>> +	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station",
>>>>>> +ALC283_FIXUP_HEADSET_MIC),
>>>>>>  	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80",
>>>>> ALC269_FIXUP_DMIC_THINKPAD_ACPI),
>>>>>>  	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210",
>>>>> ALC283_FIXUP_INT_MIC),
>>>>>>  	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70",
>>>>>> ALC269_FIXUP_DMIC_THINKPAD_ACPI), @@ -9187,6 +9189,7 @@ static
>>>>> const struct hda_device_id snd_hda_id_realtek[] = {
>>>>>>  	HDA_CODEC_ENTRY(0x10ec0298, "ALC298", patch_alc269),
>>>>>>  	HDA_CODEC_ENTRY(0x10ec0299, "ALC299", patch_alc269),
>>>>>>  	HDA_CODEC_ENTRY(0x10ec0300, "ALC300", patch_alc269),
>>>>>> +	HDA_CODEC_ENTRY(0x10ec0623, "ALC623", patch_alc269),
>>>>>>  	HDA_CODEC_REV_ENTRY(0x10ec0861, 0x100340, "ALC660",
>>>>> patch_alc861),
>>>>>>  	HDA_CODEC_ENTRY(0x10ec0660, "ALC660-VD", patch_alc861vd),
>>>>>>  	HDA_CODEC_ENTRY(0x10ec0861, "ALC861", patch_alc861),
>>>>>> --
>>>>>> 2.17.1
>>>>>>
>>>>>
>>>>> ------Please consider the environment before printing this e-mail.
>> [2 0000-add-support-alc623.patch <application/octet-stream (base64)>]
>>

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [alsa-devel] [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
@ 2019-10-24 10:54             ` Aaron Ma
  0 siblings, 0 replies; 22+ messages in thread
From: Aaron Ma @ 2019-10-24 10:54 UTC (permalink / raw)
  To: Takashi Iwai, Kailang; +Cc: hui.wang, alsa-devel, linux-kernel

On 10/24/19 6:35 PM, Takashi Iwai wrote:
> On Thu, 24 Oct 2019 09:20:19 +0200,
> Kailang wrote:
>>
>> Hi Takashi,
>>
>> Attach patch was support ALC623.
> 
> Thanks, applied now.
> 
> Aaron, could you rebase your patch and resubmit?
> 
> 

Yes I will.
One line of same changes.

Thanks,
Aaron

> Takashi
> 
>>
>> BR,
>> Kailang
>>
>>> -----Original Message-----
>>> From: Aaron Ma <aaron.ma@canonical.com>
>>> Sent: Wednesday, October 23, 2019 6:06 PM
>>> To: Kailang <kailang@realtek.com>; Takashi Iwai <tiwai@suse.de>
>>> Cc: perex@perex.cz; hui.wang@canonical.com; alsa-devel@alsa-project.org;
>>> linux-kernel@vger.kernel.org
>>> Subject: Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
>>>
>>> On 10/23/19 4:44 PM, Kailang wrote:
>>>>
>>>>
>>>>> -----Original Message-----
>>>>> From: Takashi Iwai <tiwai@suse.de>
>>>>> Sent: Wednesday, October 23, 2019 12:08 AM
>>>>> To: Aaron Ma <aaron.ma@canonical.com>
>>>>> Cc: perex@perex.cz; Kailang <kailang@realtek.com>;
>>>>> hui.wang@canonical.com; alsa-devel@alsa-project.org;
>>>>> linux-kernel@vger.kernel.org
>>>>> Subject: Re: [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec
>>>>> 0x623
>>>>>
>>>>> On Tue, 22 Oct 2019 17:38:55 +0200,
>>>>> Aaron Ma wrote:
>>>>>>
>>>>>> These 2 ThinkCentres installed a new realtek codec ID 0x623, it has
>>>>>> 2 front mics with the same location on pin 0x18 and 0x19.
>>>>>>
>>>>>> Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic location
>>>>>> to right, then pulseaudio can handle them.
>>>>>> One "Front Mic" and one "Mic" will be shown, and audio output works
>>>>>> fine.
>>>>>>
>>>>>> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
>>>>>
>>>>> I'd like to have Kailang's review about the new codec before applying.
>>>>>
>>>>> Kailang, could you take a look?
>>>> OK.
>>>> I will post you the patch for ALC623 codec tomorrow.
>>>> Thanks.
>>>
>>> Cc me too.
>>>
>>> Thank you.
>>> Aaron
>>>
>>>>
>>>>>
>>>>>
>>>>> thanks,
>>>>>
>>>>> Takashi
>>>>>
>>>>>> ---
>>>>>>  sound/pci/hda/patch_realtek.c | 3 +++
>>>>>>  1 file changed, 3 insertions(+)
>>>>>>
>>>>>> diff --git a/sound/pci/hda/patch_realtek.c
>>>>>> b/sound/pci/hda/patch_realtek.c index b000b36ac3c6..c34d8b435f58
>>>>>> 100644
>>>>>> --- a/sound/pci/hda/patch_realtek.c
>>>>>> +++ b/sound/pci/hda/patch_realtek.c
>>>>>> @@ -7186,6 +7186,8 @@ static const struct snd_pci_quirk
>>>>>> alc269_fixup_tbl[]
>>>>> = {
>>>>>>  	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station",
>>>>> ALC294_FIXUP_LENOVO_MIC_LOCATION),
>>>>>>  	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station",
>>>>> ALC294_FIXUP_LENOVO_MIC_LOCATION),
>>>>>>  	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station",
>>>>>> ALC283_FIXUP_HEADSET_MIC),
>>>>>> +	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station",
>>>>> ALC283_FIXUP_HEADSET_MIC),
>>>>>> +	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station",
>>>>>> +ALC283_FIXUP_HEADSET_MIC),
>>>>>>  	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80",
>>>>> ALC269_FIXUP_DMIC_THINKPAD_ACPI),
>>>>>>  	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210",
>>>>> ALC283_FIXUP_INT_MIC),
>>>>>>  	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70",
>>>>>> ALC269_FIXUP_DMIC_THINKPAD_ACPI), @@ -9187,6 +9189,7 @@ static
>>>>> const struct hda_device_id snd_hda_id_realtek[] = {
>>>>>>  	HDA_CODEC_ENTRY(0x10ec0298, "ALC298", patch_alc269),
>>>>>>  	HDA_CODEC_ENTRY(0x10ec0299, "ALC299", patch_alc269),
>>>>>>  	HDA_CODEC_ENTRY(0x10ec0300, "ALC300", patch_alc269),
>>>>>> +	HDA_CODEC_ENTRY(0x10ec0623, "ALC623", patch_alc269),
>>>>>>  	HDA_CODEC_REV_ENTRY(0x10ec0861, 0x100340, "ALC660",
>>>>> patch_alc861),
>>>>>>  	HDA_CODEC_ENTRY(0x10ec0660, "ALC660-VD", patch_alc861vd),
>>>>>>  	HDA_CODEC_ENTRY(0x10ec0861, "ALC861", patch_alc861),
>>>>>> --
>>>>>> 2.17.1
>>>>>>
>>>>>
>>>>> ------Please consider the environment before printing this e-mail.
>> [2 0000-add-support-alc623.patch <application/octet-stream (base64)>]
>>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH v2] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
  2019-10-22 15:38 ` [alsa-devel] " Aaron Ma
@ 2019-10-24 11:18   ` Aaron Ma
  -1 siblings, 0 replies; 22+ messages in thread
From: Aaron Ma @ 2019-10-24 11:18 UTC (permalink / raw)
  To: perex, tiwai, kailang, hui.wang, alsa-devel, aaron.ma, linux-kernel

These 2 ThinkCentres installed a new realtek codec ID 0x623,
it has 2 front mics with the same location on pin 0x18 and 0x19.

Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic
location to right, then pulseaudio can handle them.
One "Front Mic" and one "Mic" will be shown, and audio output works
fine.

Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index a0c237cc13d4..173a7867bb45 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7221,6 +7221,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
 	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
 	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
 	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
 	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [alsa-devel] [PATCH v2] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
@ 2019-10-24 11:18   ` Aaron Ma
  0 siblings, 0 replies; 22+ messages in thread
From: Aaron Ma @ 2019-10-24 11:18 UTC (permalink / raw)
  To: perex, tiwai, kailang, hui.wang, alsa-devel, aaron.ma, linux-kernel

These 2 ThinkCentres installed a new realtek codec ID 0x623,
it has 2 front mics with the same location on pin 0x18 and 0x19.

Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic
location to right, then pulseaudio can handle them.
One "Front Mic" and one "Mic" will be shown, and audio output works
fine.

Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index a0c237cc13d4..173a7867bb45 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7221,6 +7221,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
 	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
 	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
 	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
 	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
-- 
2.17.1

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [PATCH v2] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
  2019-10-24 11:18   ` [alsa-devel] " Aaron Ma
@ 2019-10-24 11:30     ` Hui Wang
  -1 siblings, 0 replies; 22+ messages in thread
From: Hui Wang @ 2019-10-24 11:30 UTC (permalink / raw)
  To: Aaron Ma, perex, tiwai, kailang, alsa-devel, linux-kernel


On 2019/10/24 下午7:18, Aaron Ma wrote:
> These 2 ThinkCentres installed a new realtek codec ID 0x623,
> it has 2 front mics with the same location on pin 0x18 and 0x19.
>
> Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic
> location to right, then pulseaudio can handle them.
> One "Front Mic" and one "Mic" will be shown, and audio output works
> fine.
>
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> ---
>   sound/pci/hda/patch_realtek.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index a0c237cc13d4..173a7867bb45 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -7221,6 +7221,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>   	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
>   	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
>   	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
> +	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
> +	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),

Please sort them in numerical order, 0x3176 is ahead of 0x3178.

thanks

>   	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
>   	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
>   	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI),

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [alsa-devel] [PATCH v2] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
@ 2019-10-24 11:30     ` Hui Wang
  0 siblings, 0 replies; 22+ messages in thread
From: Hui Wang @ 2019-10-24 11:30 UTC (permalink / raw)
  To: Aaron Ma, perex, tiwai, kailang, alsa-devel, linux-kernel


On 2019/10/24 下午7:18, Aaron Ma wrote:
> These 2 ThinkCentres installed a new realtek codec ID 0x623,
> it has 2 front mics with the same location on pin 0x18 and 0x19.
>
> Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic
> location to right, then pulseaudio can handle them.
> One "Front Mic" and one "Mic" will be shown, and audio output works
> fine.
>
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> ---
>   sound/pci/hda/patch_realtek.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index a0c237cc13d4..173a7867bb45 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -7221,6 +7221,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>   	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
>   	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
>   	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
> +	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
> +	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),

Please sort them in numerical order, 0x3176 is ahead of 0x3178.

thanks

>   	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
>   	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
>   	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH v3] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
  2019-10-22 15:38 ` [alsa-devel] " Aaron Ma
@ 2019-10-24 11:44   ` Aaron Ma
  -1 siblings, 0 replies; 22+ messages in thread
From: Aaron Ma @ 2019-10-24 11:44 UTC (permalink / raw)
  To: perex, tiwai, kailang, hui.wang, alsa-devel, aaron.ma, linux-kernel

These 2 ThinkCentres installed a new realtek codec ID 0x623,
it has 2 front mics with the same location on pin 0x18 and 0x19.

Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic
location to right, then pulseaudio can handle them.
One "Front Mic" and one "Mic" will be shown, and audio output works
fine.

Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index a0c237cc13d4..80f66ba85f87 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7221,6 +7221,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
 	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
 	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
 	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
 	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [alsa-devel] [PATCH v3] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
@ 2019-10-24 11:44   ` Aaron Ma
  0 siblings, 0 replies; 22+ messages in thread
From: Aaron Ma @ 2019-10-24 11:44 UTC (permalink / raw)
  To: perex, tiwai, kailang, hui.wang, alsa-devel, aaron.ma, linux-kernel

These 2 ThinkCentres installed a new realtek codec ID 0x623,
it has 2 front mics with the same location on pin 0x18 and 0x19.

Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic
location to right, then pulseaudio can handle them.
One "Front Mic" and one "Mic" will be shown, and audio output works
fine.

Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index a0c237cc13d4..80f66ba85f87 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7221,6 +7221,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
 	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
 	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
 	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
 	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
-- 
2.17.1

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [PATCH v3] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
  2019-10-24 11:44   ` [alsa-devel] " Aaron Ma
@ 2019-10-24 12:23     ` Takashi Iwai
  -1 siblings, 0 replies; 22+ messages in thread
From: Takashi Iwai @ 2019-10-24 12:23 UTC (permalink / raw)
  To: Aaron Ma; +Cc: perex, tiwai, kailang, hui.wang, alsa-devel, linux-kernel

On Thu, 24 Oct 2019 13:44:39 +0200,
Aaron Ma wrote:
> 
> These 2 ThinkCentres installed a new realtek codec ID 0x623,
> it has 2 front mics with the same location on pin 0x18 and 0x19.
> 
> Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic
> location to right, then pulseaudio can handle them.
> One "Front Mic" and one "Mic" will be shown, and audio output works
> fine.
> 
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>

Applied, thanks.


Takashi

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [alsa-devel] [PATCH v3] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
@ 2019-10-24 12:23     ` Takashi Iwai
  0 siblings, 0 replies; 22+ messages in thread
From: Takashi Iwai @ 2019-10-24 12:23 UTC (permalink / raw)
  To: Aaron Ma; +Cc: alsa-devel, kailang, linux-kernel, tiwai, hui.wang

On Thu, 24 Oct 2019 13:44:39 +0200,
Aaron Ma wrote:
> 
> These 2 ThinkCentres installed a new realtek codec ID 0x623,
> it has 2 front mics with the same location on pin 0x18 and 0x19.
> 
> Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic
> location to right, then pulseaudio can handle them.
> One "Front Mic" and one "Mic" will be shown, and audio output works
> fine.
> 
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>

Applied, thanks.


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2019-10-24 12:24 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-22 15:38 [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623 Aaron Ma
2019-10-22 15:38 ` [alsa-devel] " Aaron Ma
2019-10-22 16:08 ` Takashi Iwai
2019-10-22 16:08   ` [alsa-devel] " Takashi Iwai
2019-10-23  8:44   ` Kailang
2019-10-23  8:44     ` [alsa-devel] " Kailang
2019-10-23 10:06     ` Aaron Ma
2019-10-23 10:06       ` [alsa-devel] " Aaron Ma
2019-10-24  7:20       ` Kailang
2019-10-24  7:20         ` [alsa-devel] " Kailang
2019-10-24 10:35         ` Takashi Iwai
2019-10-24 10:35           ` [alsa-devel] " Takashi Iwai
2019-10-24 10:54           ` Aaron Ma
2019-10-24 10:54             ` [alsa-devel] " Aaron Ma
2019-10-24 11:18 ` [PATCH v2] " Aaron Ma
2019-10-24 11:18   ` [alsa-devel] " Aaron Ma
2019-10-24 11:30   ` Hui Wang
2019-10-24 11:30     ` [alsa-devel] " Hui Wang
2019-10-24 11:44 ` [PATCH v3] " Aaron Ma
2019-10-24 11:44   ` [alsa-devel] " Aaron Ma
2019-10-24 12:23   ` Takashi Iwai
2019-10-24 12:23     ` [alsa-devel] " Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.