From: Jon Hunter <jonathanh@nvidia.com>
To: Arnd Bergmann <arnd@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>, <linux-kernel@vger.kernel.org>,
<linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] memory: tegra: fix unused-function warning
Date: Thu, 22 Jul 2021 18:22:57 +0100 [thread overview]
Message-ID: <84920cc2-f5ba-133b-8b2c-f7d2c69eaad3@nvidia.com> (raw)
In-Reply-To: <20210722090748.1157470-1-arnd@kernel.org>
On 22/07/2021 10:07, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The tegra186_mc_client_sid_override() is only called from
> an #ifdef block:
>
> drivers/memory/tegra/tegra186.c:74:13: error: 'tegra186_mc_client_sid_override' defined but not used [-Werror=unused-function]
> 74 | static void tegra186_mc_client_sid_override(struct tegra_mc *mc,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Add another #ifdef around the called function.
>
> Fixes: 393d66fd2cac ("memory: tegra: Implement SID override programming")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/memory/tegra/tegra186.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/memory/tegra/tegra186.c b/drivers/memory/tegra/tegra186.c
> index e65eac5764d4..3d153881abc1 100644
> --- a/drivers/memory/tegra/tegra186.c
> +++ b/drivers/memory/tegra/tegra186.c
> @@ -71,6 +71,7 @@ static int tegra186_mc_resume(struct tegra_mc *mc)
> return 0;
> }
>
> +#if IS_ENABLED(CONFIG_IOMMU_API)
> static void tegra186_mc_client_sid_override(struct tegra_mc *mc,
> const struct tegra_mc_client *client,
> unsigned int sid)
> @@ -108,6 +109,7 @@ static void tegra186_mc_client_sid_override(struct tegra_mc *mc,
> writel(sid, mc->regs + client->regs.sid.override);
> }
> }
> +#endif
>
> static int tegra186_mc_probe_device(struct tegra_mc *mc, struct device *dev)
> {
>
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Thanks for fixing!
Jon
--
nvpublic
next prev parent reply other threads:[~2021-07-22 17:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 9:07 [PATCH] memory: tegra: fix unused-function warning Arnd Bergmann
2021-07-22 17:22 ` Jon Hunter [this message]
2021-07-23 6:27 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84920cc2-f5ba-133b-8b2c-f7d2c69eaad3@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.