Re: [PATCH v6 4/4] perf-stat: add documentation for -b option

From: Song Liu <songliubraving@fb.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Mark Rutland <mark.rutland@arm.com>, Jiri Olsa <jolsa@redhat.com>,
	"Kernel Team" <Kernel-team@fb.com>
Subject: Re: [PATCH v6 4/4] perf-stat: add documentation for -b option
Date: Tue, 29 Dec 2020 16:59:00 +0000	[thread overview]
Message-ID: <84A7363C-5944-43CB-8902-3EAA5BBA1495@fb.com> (raw)
In-Reply-To: <CAM9d7chxLKqjhB3CoxPV8Oz9y6fzZBTZ-YhtEWc1dzf9s-iB3A@mail.gmail.com>

> On Dec 28, 2020, at 11:24 PM, Namhyung Kim <namhyung@kernel.org> wrote:
> 
> On Tue, Dec 29, 2020 at 2:41 AM Song Liu <songliubraving@fb.com> wrote:
>> 
>> Add documentation to perf-stat -b option, which stats event for BPF
>> programs.
>> 
>> Signed-off-by: Song Liu <songliubraving@fb.com>
>> ---
>> tools/perf/Documentation/perf-stat.txt | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>> 
>> diff --git a/tools/perf/Documentation/perf-stat.txt b/tools/perf/Documentation/perf-stat.txt
>> index 5d4a673d7621a..15b9a646e853d 100644
>> --- a/tools/perf/Documentation/perf-stat.txt
>> +++ b/tools/perf/Documentation/perf-stat.txt
>> @@ -75,6 +75,20 @@ report::
>> --tid=<tid>::
>>         stat events on existing thread id (comma separated list)
>> 
>> +-b::
>> +--bpf-prog::
>> +        stat events on existing bpf program id (comma separated list),
>> +        requiring root righs. For example:
> 
> Typo: rights
> 
> It'd be nice if it can show how we can get the id.

Thanks for the review! I fill fix these in the next version. 

Song