From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51868)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex@alex.org.uk>) id 1V1kEQ-0006sx-0i
	for qemu-devel@nongnu.org; Tue, 23 Jul 2013 17:34:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex@alex.org.uk>) id 1V1kEP-0002tw-2B
	for qemu-devel@nongnu.org; Tue, 23 Jul 2013 17:34:53 -0400
Received: from mail.avalus.com ([2001:41c8:10:1dd::10]:33125)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex@alex.org.uk>) id 1V1kEO-0002sW-TG
	for qemu-devel@nongnu.org; Tue, 23 Jul 2013 17:34:53 -0400
Date: Tue, 23 Jul 2013 22:34:43 +0100
From: Alex Bligh <alex@alex.org.uk>
Message-ID: <84D6A69D591191FF8735EF6B@nimrod.local>
In-Reply-To: <51EEF0FE.4090701@twiddle.net>
References: <1E8E204.8000201@redhat.com>
	<1374343603-29183-1-git-send-email-alex@alex.org.uk>
	<1374343603-29183-3-git-send-email-alex@alex.org.uk>
	<51EEF0FE.4090701@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Subject: Re: [Qemu-devel] [PATCHv2] [RFC 2/7] aio / timers: qemu-timer.c
 utility functions and add list of clocks
Reply-To: Alex Bligh <alex@alex.org.uk>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org, Alex Bligh <alex@alex.org.uk>, Paolo Bonzini <pbonzini@redhat.com>

Richard,

--On 23 July 2013 13:09:18 -0800 Richard Henderson <rth@twiddle.net> wrote:

> On 07/20/2013 10:06 AM, Alex Bligh wrote:
>> +int64_t qemu_clock_deadline_ns(QEMUClock *clock);
>> +int64_t qemu_clock_deadline_all_ns(void);
>> +int qemu_timeout_ns_to_ms(int64_t ns);
>> +gint qemu_g_poll_ns(GPollFD *fds, guint nfds, int64_t timeout);
>
> Why continue with the g_ prefix here?  Surely qemu_poll_ns is sufficient.

Only because it was a g_ type function (takes GPollFD*, guint, and returns
gint). Quite happy to make it a qemu_poll_ns. Perhaps I should make it take
uint and return int at the same time.

TBH I am confused as to why we use g_poll at all. I thought originally
we were using it for win32, but that doesn't use g_poll. Given poll is
POSIX, what platforms do we target which are glib, !win32, and !posix?
Using straight posix would be easier.

-- 
Alex Bligh