* [PATCH for v5.6] mc-entity.c: use & to check pad flags, not ==
@ 2020-02-04 18:19 Hans Verkuil
2020-02-04 18:23 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Hans Verkuil @ 2020-02-04 18:19 UTC (permalink / raw)
To: Linux Media Mailing List; +Cc: Laurent Pinchart, Sakari Ailus
These are bits so to test if a pad is a sink you use & but not ==.
It looks like the only reason this hasn't caused problems before is that
media_get_pad_index() is currently only used with pads that do not set the
MEDIA_PAD_FL_MUST_CONNECT flag. So a pad really had only the SINK or SOURCE
flag set and nothing else.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: <stable@vger.kernel.org> # for v5.3 and up
---
diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c
index 7c429ce98bae..0f1461ac00f0 100644
--- a/drivers/media/mc/mc-entity.c
+++ b/drivers/media/mc/mc-entity.c
@@ -639,9 +639,9 @@ int media_get_pad_index(struct media_entity *entity, bool is_sink,
return -EINVAL;
for (i = 0; i < entity->num_pads; i++) {
- if (entity->pads[i].flags == MEDIA_PAD_FL_SINK)
+ if (entity->pads[i].flags & MEDIA_PAD_FL_SINK)
pad_is_sink = true;
- else if (entity->pads[i].flags == MEDIA_PAD_FL_SOURCE)
+ else if (entity->pads[i].flags & MEDIA_PAD_FL_SOURCE)
pad_is_sink = false;
else
continue; /* This is an error! */
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH for v5.6] mc-entity.c: use & to check pad flags, not ==
2020-02-04 18:19 [PATCH for v5.6] mc-entity.c: use & to check pad flags, not == Hans Verkuil
@ 2020-02-04 18:23 ` Laurent Pinchart
2020-02-04 18:32 ` Hans Verkuil
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2020-02-04 18:23 UTC (permalink / raw)
To: Hans Verkuil; +Cc: Linux Media Mailing List, Sakari Ailus
Hi Hans,
Thank you for the patch.
On Tue, Feb 04, 2020 at 07:19:22PM +0100, Hans Verkuil wrote:
> These are bits so to test if a pad is a sink you use & but not ==.
>
> It looks like the only reason this hasn't caused problems before is that
> media_get_pad_index() is currently only used with pads that do not set the
> MEDIA_PAD_FL_MUST_CONNECT flag. So a pad really had only the SINK or SOURCE
> flag set and nothing else.
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> Cc: <stable@vger.kernel.org> # for v5.3 and up
> ---
> diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c
> index 7c429ce98bae..0f1461ac00f0 100644
> --- a/drivers/media/mc/mc-entity.c
> +++ b/drivers/media/mc/mc-entity.c
> @@ -639,9 +639,9 @@ int media_get_pad_index(struct media_entity *entity, bool is_sink,
> return -EINVAL;
>
> for (i = 0; i < entity->num_pads; i++) {
> - if (entity->pads[i].flags == MEDIA_PAD_FL_SINK)
> + if (entity->pads[i].flags & MEDIA_PAD_FL_SINK)
> pad_is_sink = true;
> - else if (entity->pads[i].flags == MEDIA_PAD_FL_SOURCE)
> + else if (entity->pads[i].flags & MEDIA_PAD_FL_SOURCE)
What if MEDIA_PAD_FL_SINK and MEDIA_PAD_FL_SOURCE are both set ? Is that
acceptable ?
> pad_is_sink = false;
> else
> continue; /* This is an error! */
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH for v5.6] mc-entity.c: use & to check pad flags, not ==
2020-02-04 18:23 ` Laurent Pinchart
@ 2020-02-04 18:32 ` Hans Verkuil
0 siblings, 0 replies; 3+ messages in thread
From: Hans Verkuil @ 2020-02-04 18:32 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Linux Media Mailing List, Sakari Ailus
On 2/4/20 7:23 PM, Laurent Pinchart wrote:
> Hi Hans,
>
> Thank you for the patch.
>
> On Tue, Feb 04, 2020 at 07:19:22PM +0100, Hans Verkuil wrote:
>> These are bits so to test if a pad is a sink you use & but not ==.
>>
>> It looks like the only reason this hasn't caused problems before is that
>> media_get_pad_index() is currently only used with pads that do not set the
>> MEDIA_PAD_FL_MUST_CONNECT flag. So a pad really had only the SINK or SOURCE
>> flag set and nothing else.
>>
>> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
>> Cc: <stable@vger.kernel.org> # for v5.3 and up
>> ---
>> diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c
>> index 7c429ce98bae..0f1461ac00f0 100644
>> --- a/drivers/media/mc/mc-entity.c
>> +++ b/drivers/media/mc/mc-entity.c
>> @@ -639,9 +639,9 @@ int media_get_pad_index(struct media_entity *entity, bool is_sink,
>> return -EINVAL;
>>
>> for (i = 0; i < entity->num_pads; i++) {
>> - if (entity->pads[i].flags == MEDIA_PAD_FL_SINK)
>> + if (entity->pads[i].flags & MEDIA_PAD_FL_SINK)
>> pad_is_sink = true;
>> - else if (entity->pads[i].flags == MEDIA_PAD_FL_SOURCE)
>> + else if (entity->pads[i].flags & MEDIA_PAD_FL_SOURCE)
>
> What if MEDIA_PAD_FL_SINK and MEDIA_PAD_FL_SOURCE are both set ? Is that
> acceptable ?
No, that's not allowed. v4l2-compliance checks against that.
Regards,
Hans
>
>> pad_is_sink = false;
>> else
>> continue; /* This is an error! */
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-04 18:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-04 18:19 [PATCH for v5.6] mc-entity.c: use & to check pad flags, not == Hans Verkuil
2020-02-04 18:23 ` Laurent Pinchart
2020-02-04 18:32 ` Hans Verkuil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.