From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14E49C433C1 for ; Mon, 29 Mar 2021 18:31:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D94A960230 for ; Mon, 29 Mar 2021 18:31:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231715AbhC2SbS (ORCPT ); Mon, 29 Mar 2021 14:31:18 -0400 Received: from mengyan1223.wang ([89.208.246.23]:53976 "EHLO mengyan1223.wang" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230435AbhC2Sau (ORCPT ); Mon, 29 Mar 2021 14:30:50 -0400 Received: from [IPv6:240e:35a:1037:8a00:70b2:e35d:833c:af3e] (unknown [IPv6:240e:35a:1037:8a00:70b2:e35d:833c:af3e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@mengyan1223.wang) by mengyan1223.wang (Postfix) with ESMTPSA id 2C1B065B30; Mon, 29 Mar 2021 14:30:34 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mengyan1223.wang; s=mail; t=1617042649; bh=CiLAhcBYdIBxO9trAzmTsXeaetQu3vlDdKujBncqKc8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=qOQg7r7unrFpq/RMBtE7nW5QP0kRgD5BV83yIwM/nIcVv8VVcSn5O6BoE+QKAtAVS pl0CfEKV9GMVxuczjH9ah1vbHlxP5Lg/FXopX6u6jetaREHIkwVZ1jMCIoAr3Pc2zM A96jZ+73VyKmx+gWNFVhqKrKU8n5JED9jNcJkjkT7Zqm2ckgWe5sakN0Wjt9h8JWyn 7E7+inKSzV3CFDA5Zu5DTCbl9boge165JDOCMnHsBpVG6ZzoMW3yfG1mjsvwZA1iAz MQ5LkeSKTUv//YFE13S6cx/XWf2FxanCb+dk5vr94jx1TC3L3MoDptqOmX5HwXtWux kOw/gPyVFc2Hg== Message-ID: <84b3911173ad6beb246ba0a77f93d888ee6b393e.camel@mengyan1223.wang> Subject: Re: [PATCH] drm/amdgpu: fix an underflow on non-4KB-page systems From: Xi Ruoyao To: Christian =?ISO-8859-1?Q?K=F6nig?= , Alex Deucher , Christian =?ISO-8859-1?Q?K=F6nig?= Cc: David Airlie , Felix Kuehling , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Dan =?ISO-8859-1?Q?Hor=E1k?= , amd-gfx@lists.freedesktop.org, Daniel Vetter , stable@vger.kernel.org Date: Tue, 30 Mar 2021 02:30:26 +0800 In-Reply-To: References: <20210329175348.26859-1-xry111@mengyan1223.wang> <9a11c873-a362-b5d1-6d9c-e937034e267d@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-03-30 02:21 +0800, Xi Ruoyao wrote: > On 2021-03-29 20:10 +0200, Christian König wrote: > > You need to identify the root cause of this, most likely start or last > > are not a multiple of AMDGPU_GPU_PAGES_IN_CPU_PAGE. > > I printk'ed the value of start & last, they are all a multiple of 4 > (AMDGPU_GPU_PAGES_IN_CPU_PAGE). > > However... `num_entries = last - start + 1` so it became some irrational > thing...  Either this line is wrong, or someone called > amdgpu_vm_bo_update_mapping with [start, last) instead of [start, last], which > is unexpected. I added BUG_ON(num_entries % AMDGPU_GPU_PAGES_IN_CPU_PAGE != 0), get: > Mar 30 02:28:27 xry111-A1901 kernel: [] > amdgpu_vm_bo_update_mapping.constprop.0+0x218/0xae8 > Mar 30 02:28:27 xry111-A1901 kernel: [] > amdgpu_vm_bo_update+0x270/0x4c0 > Mar 30 02:28:27 xry111-A1901 kernel: [] > amdgpu_gem_va_ioctl+0x40c/0x430 > Mar 30 02:28:27 xry111-A1901 kernel: [] > drm_ioctl_kernel+0xcc/0x120 > Mar 30 02:28:27 xry111-A1901 kernel: [] > drm_ioctl+0x220/0x408 > Mar 30 02:28:27 xry111-A1901 kernel: [] > amdgpu_drm_ioctl+0x58/0x98 > Mar 30 02:28:27 xry111-A1901 kernel: [] sys_ioctl+0xcc/0xe8 > Mar 30 02:28:27 xry111-A1901 kernel: [] > syscall_common+0x34/0x58 > > > > > > BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1549 > > > > > Fixes: a39f2a8d7066 ("drm/amdgpu: nuke amdgpu_vm_bo_split_mapping v2") > > > > > Reported-by: Xi Ruoyao > > > > > Reported-by: Dan Horák > > > > > Cc: stable@vger.kernel.org > > > > > Signed-off-by: Xi Ruoyao > > > > > --- > > > > >    drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- > > > > >    1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > > > > > b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > > > > > index ad91c0c3c423..cee0cc9c8085 100644 > > > > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > > > > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > > > > > @@ -1707,7 +1707,7 @@ static int amdgpu_vm_bo_update_mapping(struct > > > > > amdgpu_device *adev, > > > > >                  } > > > > >                  start = tmp; > > > > >    > > > > > -       } while (unlikely(start != last + 1)); > > > > > +       } while (unlikely(start < last + 1)); > > > > >    > > > > >          r = vm->update_funcs->commit(¶ms, fence); > > > > >    > > > > > > > > > > base-commit: a5e13c6df0e41702d2b2c77c8ad41677ebb065b3 > > > -- Xi Ruoyao School of Aerospace Science and Technology, Xidian University From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60E20C433C1 for ; Tue, 30 Mar 2021 06:26:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CAA361883 for ; Tue, 30 Mar 2021 06:26:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CAA361883 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mengyan1223.wang Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 368D56E49A; Tue, 30 Mar 2021 06:26:27 +0000 (UTC) Received: from mengyan1223.wang (mengyan1223.wang [89.208.246.23]) by gabe.freedesktop.org (Postfix) with ESMTPS id A7BC76E4B3; Mon, 29 Mar 2021 18:30:49 +0000 (UTC) Received: from [IPv6:240e:35a:1037:8a00:70b2:e35d:833c:af3e] (unknown [IPv6:240e:35a:1037:8a00:70b2:e35d:833c:af3e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@mengyan1223.wang) by mengyan1223.wang (Postfix) with ESMTPSA id 2C1B065B30; Mon, 29 Mar 2021 14:30:34 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mengyan1223.wang; s=mail; t=1617042649; bh=CiLAhcBYdIBxO9trAzmTsXeaetQu3vlDdKujBncqKc8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=qOQg7r7unrFpq/RMBtE7nW5QP0kRgD5BV83yIwM/nIcVv8VVcSn5O6BoE+QKAtAVS pl0CfEKV9GMVxuczjH9ah1vbHlxP5Lg/FXopX6u6jetaREHIkwVZ1jMCIoAr3Pc2zM A96jZ+73VyKmx+gWNFVhqKrKU8n5JED9jNcJkjkT7Zqm2ckgWe5sakN0Wjt9h8JWyn 7E7+inKSzV3CFDA5Zu5DTCbl9boge165JDOCMnHsBpVG6ZzoMW3yfG1mjsvwZA1iAz MQ5LkeSKTUv//YFE13S6cx/XWf2FxanCb+dk5vr94jx1TC3L3MoDptqOmX5HwXtWux kOw/gPyVFc2Hg== Message-ID: <84b3911173ad6beb246ba0a77f93d888ee6b393e.camel@mengyan1223.wang> Subject: Re: [PATCH] drm/amdgpu: fix an underflow on non-4KB-page systems From: Xi Ruoyao To: Christian =?ISO-8859-1?Q?K=F6nig?= , Alex Deucher , Christian =?ISO-8859-1?Q?K=F6nig?= Date: Tue, 30 Mar 2021 02:30:26 +0800 In-Reply-To: References: <20210329175348.26859-1-xry111@mengyan1223.wang> <9a11c873-a362-b5d1-6d9c-e937034e267d@gmail.com> User-Agent: Evolution 3.40.0 MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 30 Mar 2021 06:26:26 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Felix Kuehling , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Dan =?ISO-8859-1?Q?Hor=E1k?= , dri-devel@lists.freedesktop.org, stable@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gMjAyMS0wMy0zMCAwMjoyMSArMDgwMCwgWGkgUnVveWFvIHdyb3RlOgo+IE9uIDIwMjEtMDMt MjkgMjA6MTAgKzAyMDAsIENocmlzdGlhbiBLw7ZuaWcgd3JvdGU6Cj4gPiBZb3UgbmVlZCB0byBp ZGVudGlmeSB0aGUgcm9vdCBjYXVzZSBvZiB0aGlzLCBtb3N0IGxpa2VseSBzdGFydCBvciBsYXN0 IAo+ID4gYXJlIG5vdCBhIG11bHRpcGxlIG9mIEFNREdQVV9HUFVfUEFHRVNfSU5fQ1BVX1BBR0Uu Cj4gCj4gSSBwcmludGsnZWQgdGhlIHZhbHVlIG9mIHN0YXJ0ICYgbGFzdCwgdGhleSBhcmUgYWxs IGEgbXVsdGlwbGUgb2YgNAo+IChBTURHUFVfR1BVX1BBR0VTX0lOX0NQVV9QQUdFKS4KPiAKPiBI b3dldmVyLi4uIGBudW1fZW50cmllcyA9IGxhc3QgLSBzdGFydCArIDFgIHNvIGl0IGJlY2FtZSBz b21lIGlycmF0aW9uYWwKPiB0aGluZy4uLsKgIEVpdGhlciB0aGlzIGxpbmUgaXMgd3JvbmcsIG9y IHNvbWVvbmUgY2FsbGVkCj4gYW1kZ3B1X3ZtX2JvX3VwZGF0ZV9tYXBwaW5nIHdpdGggW3N0YXJ0 LCBsYXN0KSBpbnN0ZWFkIG9mIFtzdGFydCwgbGFzdF0sIHdoaWNoCj4gaXMgdW5leHBlY3RlZC4K CkkgYWRkZWQgQlVHX09OKG51bV9lbnRyaWVzICUgQU1ER1BVX0dQVV9QQUdFU19JTl9DUFVfUEFH RSAhPSAwKSwgZ2V0OgoKPiBNYXIgMzAgMDI6Mjg6MjcgeHJ5MTExLUExOTAxIGtlcm5lbDogWzxm ZmZmZmZmZjgzYzkwNzUwPl0KPiBhbWRncHVfdm1fYm9fdXBkYXRlX21hcHBpbmcuY29uc3Rwcm9w LjArMHgyMTgvMHhhZTgKPiBNYXIgMzAgMDI6Mjg6MjcgeHJ5MTExLUExOTAxIGtlcm5lbDogWzxm ZmZmZmZmZjgzYzkyMmI4Pl0KPiBhbWRncHVfdm1fYm9fdXBkYXRlKzB4MjcwLzB4NGMwCj4gTWFy IDMwIDAyOjI4OjI3IHhyeTExMS1BMTkwMSBrZXJuZWw6IFs8ZmZmZmZmZmY4M2M4MjNlYz5dCj4g YW1kZ3B1X2dlbV92YV9pb2N0bCsweDQwYy8weDQzMAo+IE1hciAzMCAwMjoyODoyNyB4cnkxMTEt QTE5MDEga2VybmVsOiBbPGZmZmZmZmZmODNjMWNhZTQ+XQo+IGRybV9pb2N0bF9rZXJuZWwrMHhj Yy8weDEyMAo+IE1hciAzMCAwMjoyODoyNyB4cnkxMTEtQTE5MDEga2VybmVsOiBbPGZmZmZmZmZm ODNjMWNmZDg+XQo+IGRybV9pb2N0bCsweDIyMC8weDQwOAo+IE1hciAzMCAwMjoyODoyNyB4cnkx MTEtQTE5MDEga2VybmVsOiBbPGZmZmZmZmZmODNjNWVhNDg+XQo+IGFtZGdwdV9kcm1faW9jdGwr MHg1OC8weDk4Cj4gTWFyIDMwIDAyOjI4OjI3IHhyeTExMS1BMTkwMSBrZXJuZWw6IFs8ZmZmZmZm ZmY4MzhmZWFjND5dIHN5c19pb2N0bCsweGNjLzB4ZTgKPiBNYXIgMzAgMDI6Mjg6MjcgeHJ5MTEx LUExOTAxIGtlcm5lbDogWzxmZmZmZmZmZjgzNmU3NGYwPl0KPiBzeXNjYWxsX2NvbW1vbisweDM0 LzB4NTgKPiAKCj4gPiA+ID4gPiBCdWdMaW5rOiBodHRwczovL2dpdGxhYi5mcmVlZGVza3RvcC5v cmcvZHJtL2FtZC8tL2lzc3Vlcy8xNTQ5Cj4gPiA+ID4gPiBGaXhlczogYTM5ZjJhOGQ3MDY2ICgi ZHJtL2FtZGdwdTogbnVrZSBhbWRncHVfdm1fYm9fc3BsaXRfbWFwcGluZyB2MiIpCj4gPiA+ID4g PiBSZXBvcnRlZC1ieTogWGkgUnVveWFvIDx4cnkxMTFAbWVuZ3lhbjEyMjMud2FuZz4KPiA+ID4g PiA+IFJlcG9ydGVkLWJ5OiBEYW4gSG9yw6FrIDxkYW5AZGFubnkuY3o+Cj4gPiA+ID4gPiBDYzog c3RhYmxlQHZnZXIua2VybmVsLm9yZwo+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogWGkgUnVveWFv IDx4cnkxMTFAbWVuZ3lhbjEyMjMud2FuZz4KPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gwqDCoCBk cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYyB8IDIgKy0KPiA+ID4gPiA+IMKg wqAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gPiA+ID4g PiAKPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRn cHVfdm0uYwo+ID4gPiA+ID4gYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0u Ywo+ID4gPiA+ID4gaW5kZXggYWQ5MWMwYzNjNDIzLi5jZWUwY2M5YzgwODUgMTAwNjQ0Cj4gPiA+ ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYwo+ID4gPiA+ ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZtLmMKPiA+ID4gPiA+ IEBAIC0xNzA3LDcgKzE3MDcsNyBAQCBzdGF0aWMgaW50IGFtZGdwdV92bV9ib191cGRhdGVfbWFw cGluZyhzdHJ1Y3QKPiA+ID4gPiA+IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4gPiA+ID4gPiDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgfQo+ID4gPiA+ID4gwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoHN0YXJ0ID0gdG1wOwo+ID4gPiA+ID4gwqDCoCAKPiA+ID4gPiA+ IC3CoMKgwqDCoMKgwqDCoH0gd2hpbGUgKHVubGlrZWx5KHN0YXJ0ICE9IGxhc3QgKyAxKSk7Cj4g PiA+ID4gPiArwqDCoMKgwqDCoMKgwqB9IHdoaWxlICh1bmxpa2VseShzdGFydCA8IGxhc3QgKyAx KSk7Cj4gPiA+ID4gPiDCoMKgIAo+ID4gPiA+ID4gwqDCoMKgwqDCoMKgwqDCoMKgciA9IHZtLT51 cGRhdGVfZnVuY3MtPmNvbW1pdCgmcGFyYW1zLCBmZW5jZSk7Cj4gPiA+ID4gPiDCoMKgIAo+ID4g PiA+ID4gCj4gPiA+ID4gPiBiYXNlLWNvbW1pdDogYTVlMTNjNmRmMGU0MTcwMmQyYjJjNzdjOGFk NDE2NzdlYmIwNjViMwo+ID4gCj4gCgotLSAKWGkgUnVveWFvIDx4cnkxMTFAbWVuZ3lhbjEyMjMu d2FuZz4KU2Nob29sIG9mIEFlcm9zcGFjZSBTY2llbmNlIGFuZCBUZWNobm9sb2d5LCBYaWRpYW4g VW5pdmVyc2l0eQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C203C433DB for ; Mon, 29 Mar 2021 19:28:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ECDB461935 for ; Mon, 29 Mar 2021 19:28:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECDB461935 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mengyan1223.wang Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 752E16E4F8; Mon, 29 Mar 2021 19:28:19 +0000 (UTC) Received: from mengyan1223.wang (mengyan1223.wang [89.208.246.23]) by gabe.freedesktop.org (Postfix) with ESMTPS id A7BC76E4B3; Mon, 29 Mar 2021 18:30:49 +0000 (UTC) Received: from [IPv6:240e:35a:1037:8a00:70b2:e35d:833c:af3e] (unknown [IPv6:240e:35a:1037:8a00:70b2:e35d:833c:af3e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@mengyan1223.wang) by mengyan1223.wang (Postfix) with ESMTPSA id 2C1B065B30; Mon, 29 Mar 2021 14:30:34 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mengyan1223.wang; s=mail; t=1617042649; bh=CiLAhcBYdIBxO9trAzmTsXeaetQu3vlDdKujBncqKc8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=qOQg7r7unrFpq/RMBtE7nW5QP0kRgD5BV83yIwM/nIcVv8VVcSn5O6BoE+QKAtAVS pl0CfEKV9GMVxuczjH9ah1vbHlxP5Lg/FXopX6u6jetaREHIkwVZ1jMCIoAr3Pc2zM A96jZ+73VyKmx+gWNFVhqKrKU8n5JED9jNcJkjkT7Zqm2ckgWe5sakN0Wjt9h8JWyn 7E7+inKSzV3CFDA5Zu5DTCbl9boge165JDOCMnHsBpVG6ZzoMW3yfG1mjsvwZA1iAz MQ5LkeSKTUv//YFE13S6cx/XWf2FxanCb+dk5vr94jx1TC3L3MoDptqOmX5HwXtWux kOw/gPyVFc2Hg== Message-ID: <84b3911173ad6beb246ba0a77f93d888ee6b393e.camel@mengyan1223.wang> Subject: Re: [PATCH] drm/amdgpu: fix an underflow on non-4KB-page systems From: Xi Ruoyao To: Christian =?ISO-8859-1?Q?K=F6nig?= , Alex Deucher , Christian =?ISO-8859-1?Q?K=F6nig?= Date: Tue, 30 Mar 2021 02:30:26 +0800 In-Reply-To: References: <20210329175348.26859-1-xry111@mengyan1223.wang> <9a11c873-a362-b5d1-6d9c-e937034e267d@gmail.com> User-Agent: Evolution 3.40.0 MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 29 Mar 2021 19:28:18 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Felix Kuehling , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Dan =?ISO-8859-1?Q?Hor=E1k?= , dri-devel@lists.freedesktop.org, Daniel Vetter , stable@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" T24gMjAyMS0wMy0zMCAwMjoyMSArMDgwMCwgWGkgUnVveWFvIHdyb3RlOgo+IE9uIDIwMjEtMDMt MjkgMjA6MTAgKzAyMDAsIENocmlzdGlhbiBLw7ZuaWcgd3JvdGU6Cj4gPiBZb3UgbmVlZCB0byBp ZGVudGlmeSB0aGUgcm9vdCBjYXVzZSBvZiB0aGlzLCBtb3N0IGxpa2VseSBzdGFydCBvciBsYXN0 IAo+ID4gYXJlIG5vdCBhIG11bHRpcGxlIG9mIEFNREdQVV9HUFVfUEFHRVNfSU5fQ1BVX1BBR0Uu Cj4gCj4gSSBwcmludGsnZWQgdGhlIHZhbHVlIG9mIHN0YXJ0ICYgbGFzdCwgdGhleSBhcmUgYWxs IGEgbXVsdGlwbGUgb2YgNAo+IChBTURHUFVfR1BVX1BBR0VTX0lOX0NQVV9QQUdFKS4KPiAKPiBI b3dldmVyLi4uIGBudW1fZW50cmllcyA9IGxhc3QgLSBzdGFydCArIDFgIHNvIGl0IGJlY2FtZSBz b21lIGlycmF0aW9uYWwKPiB0aGluZy4uLsKgIEVpdGhlciB0aGlzIGxpbmUgaXMgd3JvbmcsIG9y IHNvbWVvbmUgY2FsbGVkCj4gYW1kZ3B1X3ZtX2JvX3VwZGF0ZV9tYXBwaW5nIHdpdGggW3N0YXJ0 LCBsYXN0KSBpbnN0ZWFkIG9mIFtzdGFydCwgbGFzdF0sIHdoaWNoCj4gaXMgdW5leHBlY3RlZC4K CkkgYWRkZWQgQlVHX09OKG51bV9lbnRyaWVzICUgQU1ER1BVX0dQVV9QQUdFU19JTl9DUFVfUEFH RSAhPSAwKSwgZ2V0OgoKPiBNYXIgMzAgMDI6Mjg6MjcgeHJ5MTExLUExOTAxIGtlcm5lbDogWzxm ZmZmZmZmZjgzYzkwNzUwPl0KPiBhbWRncHVfdm1fYm9fdXBkYXRlX21hcHBpbmcuY29uc3Rwcm9w LjArMHgyMTgvMHhhZTgKPiBNYXIgMzAgMDI6Mjg6MjcgeHJ5MTExLUExOTAxIGtlcm5lbDogWzxm ZmZmZmZmZjgzYzkyMmI4Pl0KPiBhbWRncHVfdm1fYm9fdXBkYXRlKzB4MjcwLzB4NGMwCj4gTWFy IDMwIDAyOjI4OjI3IHhyeTExMS1BMTkwMSBrZXJuZWw6IFs8ZmZmZmZmZmY4M2M4MjNlYz5dCj4g YW1kZ3B1X2dlbV92YV9pb2N0bCsweDQwYy8weDQzMAo+IE1hciAzMCAwMjoyODoyNyB4cnkxMTEt QTE5MDEga2VybmVsOiBbPGZmZmZmZmZmODNjMWNhZTQ+XQo+IGRybV9pb2N0bF9rZXJuZWwrMHhj Yy8weDEyMAo+IE1hciAzMCAwMjoyODoyNyB4cnkxMTEtQTE5MDEga2VybmVsOiBbPGZmZmZmZmZm ODNjMWNmZDg+XQo+IGRybV9pb2N0bCsweDIyMC8weDQwOAo+IE1hciAzMCAwMjoyODoyNyB4cnkx MTEtQTE5MDEga2VybmVsOiBbPGZmZmZmZmZmODNjNWVhNDg+XQo+IGFtZGdwdV9kcm1faW9jdGwr MHg1OC8weDk4Cj4gTWFyIDMwIDAyOjI4OjI3IHhyeTExMS1BMTkwMSBrZXJuZWw6IFs8ZmZmZmZm ZmY4MzhmZWFjND5dIHN5c19pb2N0bCsweGNjLzB4ZTgKPiBNYXIgMzAgMDI6Mjg6MjcgeHJ5MTEx LUExOTAxIGtlcm5lbDogWzxmZmZmZmZmZjgzNmU3NGYwPl0KPiBzeXNjYWxsX2NvbW1vbisweDM0 LzB4NTgKPiAKCj4gPiA+ID4gPiBCdWdMaW5rOiBodHRwczovL2dpdGxhYi5mcmVlZGVza3RvcC5v cmcvZHJtL2FtZC8tL2lzc3Vlcy8xNTQ5Cj4gPiA+ID4gPiBGaXhlczogYTM5ZjJhOGQ3MDY2ICgi ZHJtL2FtZGdwdTogbnVrZSBhbWRncHVfdm1fYm9fc3BsaXRfbWFwcGluZyB2MiIpCj4gPiA+ID4g PiBSZXBvcnRlZC1ieTogWGkgUnVveWFvIDx4cnkxMTFAbWVuZ3lhbjEyMjMud2FuZz4KPiA+ID4g PiA+IFJlcG9ydGVkLWJ5OiBEYW4gSG9yw6FrIDxkYW5AZGFubnkuY3o+Cj4gPiA+ID4gPiBDYzog c3RhYmxlQHZnZXIua2VybmVsLm9yZwo+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogWGkgUnVveWFv IDx4cnkxMTFAbWVuZ3lhbjEyMjMud2FuZz4KPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gwqDCoCBk cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYyB8IDIgKy0KPiA+ID4gPiA+IMKg wqAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gPiA+ID4g PiAKPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRn cHVfdm0uYwo+ID4gPiA+ID4gYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0u Ywo+ID4gPiA+ID4gaW5kZXggYWQ5MWMwYzNjNDIzLi5jZWUwY2M5YzgwODUgMTAwNjQ0Cj4gPiA+ ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYwo+ID4gPiA+ ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZtLmMKPiA+ID4gPiA+ IEBAIC0xNzA3LDcgKzE3MDcsNyBAQCBzdGF0aWMgaW50IGFtZGdwdV92bV9ib191cGRhdGVfbWFw cGluZyhzdHJ1Y3QKPiA+ID4gPiA+IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4gPiA+ID4gPiDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgfQo+ID4gPiA+ID4gwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoHN0YXJ0ID0gdG1wOwo+ID4gPiA+ID4gwqDCoCAKPiA+ID4gPiA+ IC3CoMKgwqDCoMKgwqDCoH0gd2hpbGUgKHVubGlrZWx5KHN0YXJ0ICE9IGxhc3QgKyAxKSk7Cj4g PiA+ID4gPiArwqDCoMKgwqDCoMKgwqB9IHdoaWxlICh1bmxpa2VseShzdGFydCA8IGxhc3QgKyAx KSk7Cj4gPiA+ID4gPiDCoMKgIAo+ID4gPiA+ID4gwqDCoMKgwqDCoMKgwqDCoMKgciA9IHZtLT51 cGRhdGVfZnVuY3MtPmNvbW1pdCgmcGFyYW1zLCBmZW5jZSk7Cj4gPiA+ID4gPiDCoMKgIAo+ID4g PiA+ID4gCj4gPiA+ID4gPiBiYXNlLWNvbW1pdDogYTVlMTNjNmRmMGU0MTcwMmQyYjJjNzdjOGFk NDE2NzdlYmIwNjViMwo+ID4gCj4gCgotLSAKWGkgUnVveWFvIDx4cnkxMTFAbWVuZ3lhbjEyMjMu d2FuZz4KU2Nob29sIG9mIEFlcm9zcGFjZSBTY2llbmNlIGFuZCBUZWNobm9sb2d5LCBYaWRpYW4g VW5pdmVyc2l0eQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==