All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Han Xu <han.xu@nxp.com>, Jonathan Cameron <jic23@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
	"Sean Nyekjaer" <sean@geanix.com>, "Nuno Sá" <nuno.sa@analog.com>,
	"Matti Vaittinen" <mazziesaccount@gmail.com>,
	"Haibo Chen" <haibo.chen@nxp.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Clark Wang" <xiaoning.wang@nxp.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	imx@lists.linux.dev
Subject: Re: [PATCH v3 2/4] iio: accel: add the new entry in driver for fxls8967af
Date: Tue, 13 Dec 2022 19:53:30 +0100	[thread overview]
Message-ID: <84bd582c-1dde-822c-48b7-025887fd0203@linaro.org> (raw)
In-Reply-To: <20221213171536.1880089-3-han.xu@nxp.com>

On 13/12/2022 18:15, Han Xu wrote:
> Add this new device entry in the driver id table.
> 
> Signed-off-by: Han Xu <han.xu@nxp.com>
> 
> ---
> changes in v2
> - change chip info orders
> ---
>  drivers/iio/accel/fxls8962af-core.c | 7 +++++++
>  drivers/iio/accel/fxls8962af-i2c.c  | 2 ++
>  drivers/iio/accel/fxls8962af.h      | 1 +
>  3 files changed, 10 insertions(+)
> 
> diff --git a/drivers/iio/accel/fxls8962af-core.c b/drivers/iio/accel/fxls8962af-core.c
> index 98811e4e16bb..c3589c3084ee 100644
> --- a/drivers/iio/accel/fxls8962af-core.c
> +++ b/drivers/iio/accel/fxls8962af-core.c
> @@ -127,6 +127,7 @@
>  #define FXLS8962AF_DEVICE_ID			0x62
>  #define FXLS8964AF_DEVICE_ID			0x84
>  #define FXLS8974CF_DEVICE_ID			0x86
> +#define FXLS8967AF_DEVICE_ID			0x87
>  
>  /* Raw temp channel offset */
>  #define FXLS8962AF_TEMP_CENTER_VAL		25
> @@ -765,6 +766,12 @@ static const struct fxls8962af_chip_info fxls_chip_info_table[] = {
>  		.channels = fxls8962af_channels,
>  		.num_channels = ARRAY_SIZE(fxls8962af_channels),
>  	},
> +	[fxls8967af] = {
> +		.chip_id = FXLS8967AF_DEVICE_ID,
> +		.name = "fxls8967af",
> +		.channels = fxls8962af_channels,
> +		.num_channels = ARRAY_SIZE(fxls8962af_channels),
> +	},
>  	[fxls8974cf] = {
>  		.chip_id = FXLS8974CF_DEVICE_ID,
>  		.name = "fxls8974cf",
> diff --git a/drivers/iio/accel/fxls8962af-i2c.c b/drivers/iio/accel/fxls8962af-i2c.c
> index 17dd56756ff9..a8944b255a28 100644
> --- a/drivers/iio/accel/fxls8962af-i2c.c
> +++ b/drivers/iio/accel/fxls8962af-i2c.c
> @@ -30,6 +30,7 @@ static int fxls8962af_probe(struct i2c_client *client)
>  static const struct i2c_device_id fxls8962af_id[] = {
>  	{ "fxls8962af", fxls8962af },
>  	{ "fxls8964af", fxls8964af },
> +	{ "fxls8967af", fxls8967af },
>  	{ "fxls8974cf", fxls8974cf },
>  	{}
>  };
> @@ -38,6 +39,7 @@ MODULE_DEVICE_TABLE(i2c, fxls8962af_id);
>  static const struct of_device_id fxls8962af_of_match[] = {
>  	{ .compatible = "nxp,fxls8962af" },
>  	{ .compatible = "nxp,fxls8964af" },
> +	{ .compatible = "nxp,fxls8967af" },
>  	{ .compatible = "nxp,fxls8974cf" },

This is confusing. The I2C ID table has driver data, but OF ID table
hasn't. So are they compatible or not?

Best regards,
Krzysztof


  reply	other threads:[~2022-12-13 18:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13 17:15 [PATCH v3 0/4] FXLS8967AF and FXLS8974CF support Han Xu
2022-12-13 17:15 ` [PATCH v3 1/4] iio: accel: add fxls8974cf support Han Xu
2022-12-23 17:27   ` Jonathan Cameron
2022-12-13 17:15 ` [PATCH v3 2/4] iio: accel: add the new entry in driver for fxls8967af Han Xu
2022-12-13 18:53   ` Krzysztof Kozlowski [this message]
2022-12-14  9:32     ` Jonathan Cameron
2022-12-14  9:54       ` Krzysztof Kozlowski
2022-12-23 17:31         ` Jonathan Cameron
2022-12-23 17:28   ` Jonathan Cameron
2022-12-13 17:15 ` [PATCH 2/4] iio: accel: add the new entry in driver for FXLS8967AF Han Xu
2022-12-13 18:51   ` Krzysztof Kozlowski
2022-12-13 17:15 ` [PATCH v3 3/4] dt-bindings: iio: accel: fxls8962af: add new compatible string Han Xu
2022-12-13 18:54   ` Krzysztof Kozlowski
2022-12-14  9:54   ` Krzysztof Kozlowski
2022-12-19  9:39     ` Jonathan Cameron
2022-12-13 17:15 ` [PATCH v3 4/4] dt-bindings: iio: accel: fxls8974cf: " Han Xu
2022-12-14  9:54   ` Krzysztof Kozlowski
2022-12-13 18:50 ` [PATCH v3 0/4] FXLS8967AF and FXLS8974CF support Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84bd582c-1dde-822c-48b7-025887fd0203@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=haibo.chen@nxp.com \
    --cc=han.xu@nxp.com \
    --cc=imx@lists.linux.dev \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=mazziesaccount@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=nuno.sa@analog.com \
    --cc=robh+dt@kernel.org \
    --cc=sean@geanix.com \
    --cc=xiaoning.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.