From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Walker <danielwa@cisco.com>
Subject: Re: Marvell phy errata origins?
Date: Tue, 25 Sep 2018 08:16:30 -0700
Message-ID: <84bfdc12-800c-2f63-3eff-416cf560e18c@cisco.com>
References: <59691a35-a89c-f9ca-c7b0-73134a737f4c@cisco.com>
 <20170418140450.GB13724@lunn.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Florian Fainelli <f.fainelli@gmail.com>,
        Andy Fleming <afleming@freescale.com>,
        Harini Katakam <harini.katakam@xilinx.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        HEMANT RAMDASI <hramdasi@cisco.com>,
        "Julius Hemanth Pitti -X (jpitti - MONTA VISTA SOFTWARE INC at Cisco)"
        <jpitti@cisco.com>,
        "GokulChand Casheekar (gcasheek)" <gcasheek@cisco.com>
To: Andrew Lunn <andrew@lunn.ch>
Return-path: <netdev-owner@vger.kernel.org>
Received: from alln-iport-2.cisco.com ([173.37.142.89]:33818 "EHLO
        alln-iport-2.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729420AbeIYVeD (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 25 Sep 2018 17:34:03 -0400
In-Reply-To: <20170418140450.GB13724@lunn.ch>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 04/18/2017 07:04 AM, Andrew Lunn wrote:
> On Tue, Apr 18, 2017 at 06:16:33AM -0700, Daniel Walker wrote:
>>
>> Hi,
>>
>> Cisco is using a Marvell 88E1112 phy. It seems to be fairly similar
>> to the 88E1111 which Harini added a fix for.
> 
> Hi Daniel
> 
> If you look at Marvell reference drive, DSDT, they are actually quite
> different. Different virtual cable tester, different downshift
> configuration, different packet generator, different loopback. I would
> say they are different generations of PHY.
> 
>> In Harini's commit
>> message for ,
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/phy/marvell.c?id=3ec0a0f10ceb
>>
>> "This function has a sequence accessing Page 5 and Register 31, both
>> of which are not defined or reserved for this PHY"


I hope this this thread isn't too old to bring back to life. So it seems 
that Harini found that m88e1111 did not need this errata, and Cisco 
previously found that Harini's patch fixed m88e1112, we included it 
internally for that reason

Now I'm getting reports that this errata fixes issues we're seeing on 
m88e1111. We see an interrupt storm without the errata, despite the 
errata not being defined in the datasheet.

I would just send a patch adding the errata, but because Harini removed 
it I guess we really need to suss out what's going on.

I've added Gokul who reported the issue to me. Is it possible that 
Harini and Cisco have different m88e1111 phys? Maybe there's an issue 
with how they are hooked up ?

Daniel