From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2337C43381 for ; Sun, 31 Mar 2019 10:44:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B02F2070B for ; Sun, 31 Mar 2019 10:44:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KMju0iog"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=web.de header.i=@web.de header.b="TFz47sc1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B02F2070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=web.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yMZHysncr+xDx6LX4jgDl7HrJnd1DmUZM3zO60rkMTc=; b=KMju0iogl7NTP/ 5ZkIpT00aLsd94JfXR/+hy87De+nUI7c+ceaxwSx19fNIskIxQB7equSvPYsDXZYvHJuAT3nxpcQs I6daMdVFXXBZ/Db1wgN6R9zmXyIjTowfoxbvtzX4lD30HEqwwdPq/fgtSiVeBItzCxsMZRkyyr42w jz6s+DrcIfTfSVmC/gcdvvqtXVsnIC3KGiJEoYEUYugQlO8FVx7aV0BgVXfeFznGyrA1ZZ3ntcvLQ MMT54a9ptMN2FvFDhSNjEBNtiGmvQ/phDU7Y4mrmJVcAljCNEOXyloLL7AcdiIN3bUJGrsEQpIeIW iSJxQOaxWsIWCKkBYlNA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAXxO-0001XD-BV; Sun, 31 Mar 2019 10:44:54 +0000 Received: from mout.web.de ([212.227.17.11]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAXxK-0001Wh-An for linux-arm-kernel@lists.infradead.org; Sun, 31 Mar 2019 10:44:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1554029077; bh=tLUdFX1e/MZsM2sV5PELzfLePGtyEdX6N4hzqVeSXA4=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=TFz47sc1EZB5jrVAx4VQBgMk0t6RVySwu82xoNvRRM6uFPy64dteqSNRSho/z2djc QXt8UjWm8dZjliiM1cOPpWv2y8/Thg/GiTPD31dxx7ShjJ5f+wDQoM6xao6RMoYG2W euRmhRJFEDKgRAx+Vz3kNTSKoe7nffLsljG+j7uQ= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([77.183.111.36]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0Lpezi-1ghFL92kSc-00fVY6; Sun, 31 Mar 2019 12:44:37 +0200 Subject: Re: [RFC] ARM: dts: imx: Fix the AR803X phy-mode To: Fabio Estevam , shawnguo@kernel.org References: <20190330155051.9855-1-festevam@gmail.com> From: Soeren Moch Message-ID: <84c102c7-952f-fc46-5436-f7581880e98a@web.de> Date: Sun, 31 Mar 2019 12:44:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190330155051.9855-1-festevam@gmail.com> Content-Language: en-GB X-Provags-ID: V03:K1:pu5S9HKpzKZnlA4ONSEYiawfhxbWBoKN1ynRHX8pe+UQiKKqmwY ZufMVD13G2WXkdOkVkWvWhIQC3+TCcZJtpz6DwR3a44Sr11qoSQhKBogfXfB2yZi9CFzMnF Sz88veMEQATqAXAucMlW5Lyt2Lvzgk/ZHXR0b1USj+UJriLXkMVjRPZ+sTNbbD67BX9OU3N ckh4qmwJDMV/K6hu6/hBw== X-UI-Out-Filterresults: notjunk:1;V03:K0:B2NbJjD/eq0=:VfgWKDHRUrv7UujdEYc4r6 h9H19UxjSlDJN8bIeWTPzUmqjR9J+S8XTV/fSP0KHd3Vx9rdYAByXKMQ0IfuL8F8PxArRKO5k 5v2ZFxNrpyRe1a5td3EQJaMjlU73QELfk/qlaiEDV7SiRXfj28pOLRGgI6t0zlOwHjvZUViah mLXoBd1JySW9+krOyl4m+pAjGfoMfb1aExKsnKdMnA8xiDjQ571+tKoKt8QAHiY+w3IntIXAT F8KQCVuSwDINHCP8kCw6nu+jDVHjgCfswQTz/JrNYXReu2I2SH8Zk5/+QYyG5CeCNFBkmX0pK 6kY867Kr0/3CY8A8pasyyOXS9ejAXMTKSMbxqw5tSKBHpUBq1jUo01++ChVrsa69XWbAHlCSs 4eCuneE9EpnDZcsrA47zwPE3XciHtAZOsTMxxxvZE6i5k7zUk2j/W6AeBaE9L0X3RlwbL+Pnq gV1AXK1BRKdX4M7x2idNGHg9BYL8hSol/YaUfD0faym50PT0yi0Ge/Cnq4pGOadMOmXBGMK4u 99b48D9IeDMFTQpkJAeZZKkQQyEI4pNpeCpnGn0yfcmKenG2pYCYILDGGY9pMcbFGn2QSODy+ 4c8asP/GcNtEPrSz56IoaTxUr+7gjYU8VjdoH4OmG8MWX1OREIM2R8Wiqa5PwlxI3skJI733j 0TNqQ/xr1D3y9mKl9hiJ9wDrqwCnX5f1+Olj7Dw6A7vZ2LW5Pqt177GpF4UXbUJVCnvvMINtZ qLp3Ni8oUoQbir8af1NfbO7OB1Y4ijuM/WpQ4oMOBkNmQEUO8jUw8pNQigf33JonJUmkc3PtF ZXJOIzRIMfm8gPowJyw08ENbuc2La+MoznlDrL9FVVveeRZNW9kPoCHmN98bSmestsaNFikx/ EMWC6eDyyx38XHEYKXFJYMExAYZc97ix7XmdkKM8I5FXC5YzCyRvJTTSraIl9+ X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190331_034450_713277_B48E6DA4 X-CRM114-Status: GOOD ( 16.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, linux@armlinux.org.uk, stwiss.opensource@diasemi.com, linux-imx@nxp.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30.03.19 16:50, Fabio Estevam wrote: > Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode") > exposed an issue on imx DTS files using AR8031/AR8035 PHYs. > > The end result is that the boards can no longer obtain an IP address > via UDHCP, for example. > > Quoting Andrew Lunn: > > "The problem here is, all the DTs were broken since day 0. However, > because the PHY driver was also broken, nobody noticed and it > worked. Now that the PHY driver has been fixed, all the bugs in the > DTs now become an issue" > > To fix this problem, the phy-mode property needs to be "rgmii-id", which > has the following meaning as per > Documentation/devicetree/bindings/net/ethernet.txt: > > "RGMII with internal RX and TX delays provided by the PHY, the MAC should > not add the RX or TX delays in this case)" > > Tested on imx6-sabresd, imx6sx-sdb and imx7d-pico boards with > successfully restored networking. > > Signed-off-by: Fabio Estevam > --- > Hi, > > Marking it as RFC in the hope of getting some feedback as to how > to proceed with fixing this regression on 5.1-rc1. I can confirm this regression on a tbs2910 board, and also thatthis patch fixes this. Tested-by: Soeren Moch I also think it is the right solution to fix the broken dtbs, like in this patch, instead of adding more complicated backward compatibility stuff. Thanks, Soeren > > It's not possible to know if there are other imx boards in tree that use > AR803X, so here is an attempt. > > mx6-sabresd, imx6sx-sdb and imx7d-pico have been successfully tested. > > Thanks > > arch/arm/boot/dts/imx6q-tbs2910.dts | 2 +- > arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 +- > arch/arm/boot/dts/imx6qdl-sr-som.dtsi | 2 +- > arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 2 +- > arch/arm/boot/dts/imx6sx-sdb.dtsi | 2 +- > arch/arm/boot/dts/imx7d-pico.dtsi | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel