From: Daniel Borkmann <daniel@iogearbox.net>
To: Thomas Gleixner <tglx@linutronix.de>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
bpf <bpf@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: mb2q experience and couple issues
Date: Thu, 1 Oct 2020 15:20:46 +0200 [thread overview]
Message-ID: <84c7a204-3d2e-0573-05ad-bd14d9de4d47@iogearbox.net> (raw)
In-Reply-To: <87sgayfgwz.fsf@nanos.tec.linutronix.de>
On 10/1/20 11:13 AM, Thomas Gleixner wrote:
> On Wed, Sep 30 2020 at 11:12, Alexei Starovoitov wrote:
>> For the last couple years we've been using mb2q tool to normalize patches
>> and it worked wonderfully.
>
> Fun. I thought I'm the only user of it :)
We're using it pretty much daily since you've put it on korg :) It's in
a bunch of scripts^hacks we use for bpf trees:
https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/pw.git/
>> Recently we've hit few bugs:
>> curl -s https://patchwork.kernel.org/patch/11807443/mbox/ >
>> /tmp/mbox.i; ~/bin/mb2q --mboxout mbox.o /tmp/mbox.i
>> Drop Message w/o Message-ID: No subject
>> No patches found in mbox
>>
>> I've tried to debug it, but couldn't figure out what's going on.
>> The subject and message-id fields are parsed correctly,
>> but later something happens.
>> Could you please take a look?
>
> The problem is the mbox storage format. The mbox created by curl has a
> mail body which has a line starting with 'From' in the mail body:
>
> From the VAR btf_id, the verifier can also read the address of the
> ksym's corresponding kernel var from kallsyms and use that to fill
> dst_reg.
>
> The mailbox parser trips over that From and takes it as start of the
> next message.
>
> http://qmail.org/qmail-manual-html/man5/mbox.html
>
> Usually mailbox storage escapes a From at the start of a
> newline with '>':
>
> >From the VAR btf_id, the verifier can also read the address of the
> ksym's corresponding kernel var from kallsyms and use that to fill
> dst_reg.
>
> Yes, it's ugly and I haven't figured out a proper way to deal with
> that. There are quite some mbox formats out there and they all are
> incompatible with each other and all of them have different horrors.
>
> Let me think about it.
It seems these issues only appeared since maybe a month or so. Perhaps also
something changed on ozlabs/patchwork side.
Cheers,
Daniel
next prev parent reply other threads:[~2020-10-01 13:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 18:12 mb2q experience and couple issues Alexei Starovoitov
2020-10-01 9:13 ` Thomas Gleixner
2020-10-01 13:20 ` Daniel Borkmann [this message]
2020-10-01 13:30 ` Thomas Gleixner
2020-10-01 17:26 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84c7a204-3d2e-0573-05ad-bd14d9de4d47@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.