All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] bash: fix static build
Date: Sun, 24 Sep 2017 15:34:07 +0200	[thread overview]
Message-ID: <84c95fdc-b9cf-4008-2e8e-5c158f74c983@mind.be> (raw)
In-Reply-To: <e61b7469d3048416c7e3c681a75f773843fe48a6.1505759427.git.baruch@tkos.co.il>



On 18-09-17 20:30, Baruch Siach wrote:
> When building bash statically, configure does not initialize the
> SHOBJ_STATUS variable. The SHOBJ_STATUS make variable in
> examples/loadables/Makefile.in must resolve to either 'supported' or
> 'unsupported'. Otherwise, the install-$(SHOBJ_STATUS) target does not
> exist.
> 
> This leads to the following build failure:
> 
> make[2]: Entering directory '.../output/build/bash-4.4/examples/loadables'
> make[2]: *** No rule to make target 'install-', needed by 'install'.  Stop.
> make[2]: Leaving directory '.../output/build/bash-4.4/examples/loadables'
> Makefile:793: recipe for target 'install' failed
> 
> with the following defconfig:
> 
> BR2_arm=y
> BR2_STATIC_LIBS=y
> BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y
> BR2_PACKAGE_BASH=y
> 
> Set SHOBJ_STATUS in the configure environment as a workaround.
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

 Even though this doesn't fail the build (because the error is ignored), it's
pretty fragile. And SHOBJ_STATUS=unsupported is certainly correct for static
builds. So I applied after all.

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  parent reply	other threads:[~2017-09-24 13:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-18 18:30 [Buildroot] [PATCH] bash: fix static build Baruch Siach
2017-09-19 12:37 ` Peter Korsgaard
2017-09-19 18:19   ` Baruch Siach
2017-09-19 19:45     ` Peter Korsgaard
2017-09-24 13:34 ` Arnout Vandecappelle [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-08-12 13:15 Gustavo Zacarias
2013-08-13  9:50 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84c95fdc-b9cf-4008-2e8e-5c158f74c983@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.