From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebKk0-0002Hs-1l for qemu-devel@nongnu.org; Tue, 16 Jan 2018 01:29:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebKjw-0001Is-3J for qemu-devel@nongnu.org; Tue, 16 Jan 2018 01:29:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33322) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ebKjv-0001Ig-QC for qemu-devel@nongnu.org; Tue, 16 Jan 2018 01:28:56 -0500 References: <1513866427-27125-1-git-send-email-mst@redhat.com> <20171221223704-mutt-send-email-mst@kernel.org> <20171222014258-mutt-send-email-mst@kernel.org> <20180108200725-mutt-send-email-mst@kernel.org> <20180109011010.GI2131@umbus.fritz.box> <20180116044747-mutt-send-email-mst@kernel.org> From: Jason Wang Message-ID: <84d463e9-1cd6-f3aa-7554-f1ef95bdebc9@redhat.com> Date: Tue, 16 Jan 2018 14:28:46 +0800 MIME-Version: 1.0 In-Reply-To: <20180116044747-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 00/25] pc, pci, virtio: features, fixes, cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , David Gibson Cc: Peter Maydell , Thomas Huth , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , QEMU Developers , "dmitry@daynix.com >> Dmitry Fleytman" On 2018=E5=B9=B401=E6=9C=8816=E6=97=A5 10:48, Michael S. Tsirkin wrote: > On Tue, Jan 09, 2018 at 12:10:10PM +1100, David Gibson wrote: >> On Mon, Jan 08, 2018 at 08:10:23PM +0200, Michael S. Tsirkin wrote: >>> On Mon, Jan 08, 2018 at 09:14:41AM +0000, Peter Maydell wrote: >>>> On 21 December 2017 at 23:43, Michael S. Tsirkin wr= ote: >>>>>> you also need to drop "hw/pci: remove obsolete PCIDevice->init()" >>>>>> (applied in your tree as 18951fce55d5aa58cd1629b4cb704ee51bab4420) >>>>>> else the not-yet-QOM'ified NVME won't work anymore. >>>>> Done that too, thanks a lot >>>> Hi. I'm afraid this pullreq (merge of 880b1ff) has new runtime >>>> errors from the clang sanitizer: >>>> >>>> /home/petmay01/linaro/qemu-for-merges/hw/net/net_tx_pkt.c:201:27: >>>> runtime error: member access within misaligned address 0x55b4ffee824= 6 >>>> for type 'struct ip_header', which requires 4 byte alignment >>>> 0x55b4ffee8246: note: pointer points here >>>> 01 00 00 00 45 00 01 a9 01 00 00 00 40 11 78 45 00 00 00 00 ff f= f >>>> ff ff 00 00 00 00 00 00 00 00 >>>> ^ >>>> /home/petmay01/linaro/qemu-for-merges/hw/net/net_tx_pkt.c:201:27: >>>> runtime error: load of misaligned address 0x55b4ffee8246 for type >>>> 'uint8_t' (aka 'unsigned char'), which requires 4 byte alignment >>>> 0x55b4ffee8246: note: pointer points here >>>> 01 00 00 00 45 00 01 a9 01 00 00 00 40 11 78 45 00 00 00 00 ff f= f >>>> ff ff 00 00 00 00 00 00 00 00 >>>> ^ >>>> /home/petmay01/linaro/qemu-for-merges/hw/net/net_tx_pkt.c:208:65: >>>> runtime error: member access within misaligned address 0x55b4ffee824= 6 >>>> for type 'struct ip_header', which requires 4 byte alignment >>>> 0x55b4ffee8246: note: pointer points here >>>> 01 00 00 00 45 00 01 a9 01 00 00 00 40 11 78 45 00 00 00 00 ff f= f >>>> ff ff 00 00 00 00 00 00 00 00 >>>> ^ >>>> /home/petmay01/linaro/qemu-for-merges/hw/net/net_tx_pkt.c:210:13: >>>> runtime error: member access within misaligned address 0x55b4ffee824= 6 >>>> for type 'struct ip_header', which requires 4 byte alignment >>>> 0x55b4ffee8246: note: pointer points here >>>> 01 00 00 00 45 00 01 a9 01 00 00 00 40 11 78 45 00 00 00 00 ff f= f >>>> ff ff 00 00 00 00 00 00 00 00 >>>> ^ >>>> /home/petmay01/linaro/qemu-for-merges/hw/net/net_tx_pkt.c:210:13: >>>> runtime error: load of misaligned address 0x55b4ffee8246 for type >>>> 'uint8_t' (aka 'unsigned char'), which requires 4 byte alignment >>>> 0x55b4ffee8246: note: pointer points here >>>> 01 00 00 00 45 00 01 a9 01 00 00 00 40 11 78 45 00 00 00 00 ff f= f >>>> ff ff 00 00 00 00 00 00 00 00 >>>> ^ >>>> >>>> Sorry for the late report, I didn't quite have time >>>> to process the pull before Christmas holidays. >>>> >>>> thanks >>>> -- PMM >>> So I bisected and the reason is this commit: >>> >>> commit 18b20bb43a2f37f0c8ae23a3e9b3d9a4a05b6bd4 >>> Author: David Gibson >>> Date: Tue Dec 19 15:45:22 2017 +1100 >>> >>> tests/pxe-test: Add some extra tests >>> =20 >>> Previously virtio-net was only tested for ppc64 in "slow" mode. = That >>> doesn't make much sense since virtio-net is used much more often= in >>> practice than the spapr-vlan device which was tested always. So= , move >>> virtio-net to always be tested on ppc64. >>> =20 >>> We had no tests at all for the q35 machine, which doesn't seem w= ise >>> given its increasing prominence. Add a couple of tests for it, >>> including testing the newer e1000e adapter. >>> =20 >>> Signed-off-by: David Gibson >>> Reviewed-by: Thomas Huth >>> Reviewed-by: Michael S. Tsirkin >>> Signed-off-by: Michael S. Tsirkin >>> >>> :040000 040000 5a982bfea24b9ac3c651b84425a39b3c85f4871e 771af3fdfb277= 8c6d6ed6b1098d1e79c181d6fb0 M tests >>> >>> Pls either fix or drop e1000e test >> Feel free to drop this patch for now. I'll debug and repost it when I >> have a chance. >> >> --=20 >> David Gibson | I'll have my music baroque, and my code >> david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _ot= her_ >> | _way_ _around_! >> http://www.ozlabs.org/~dgibson > BTw, Jason, you might want to take a look. > I suspect it's a bug somewhere in the e1000e emulation. > Will have a look. cc Dmitry for more thoughts. Thanks