From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C51DFC388F9 for ; Thu, 22 Oct 2020 13:21:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E2F424178 for ; Thu, 22 Oct 2020 13:21:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="KYdK90La" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2899783AbgJVNVG (ORCPT ); Thu, 22 Oct 2020 09:21:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2899548AbgJVNTq (ORCPT ); Thu, 22 Oct 2020 09:19:46 -0400 Received: from mail-qk1-x74a.google.com (mail-qk1-x74a.google.com [IPv6:2607:f8b0:4864:20::74a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1441EC0613CE for ; Thu, 22 Oct 2020 06:19:45 -0700 (PDT) Received: by mail-qk1-x74a.google.com with SMTP id f126so987894qke.17 for ; Thu, 22 Oct 2020 06:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=9DI5u3KafPzj5V3i+niAdO1uhXW2it0RjumucIpkaOw=; b=KYdK90La20UFPuJ0fER+IgQyEcsxZKP6b9b4wzo9FrNthDqnAFuD/5RyVeAhzGtgFD 1rxDr3Tc3DpMi3VJMulxGYNmOXPyCZ44TXQZaLrnagTdrvXkZGmK0uz5CxJO/kcl5io3 867JSelEDG2IXELgOzI1dAaZAG7MmtKcjNEZw8rVk16HYclXkCIp562h7Clu9cWh/Wg5 5sMDUaz9GmxLB9D5wgH9F8tliUrf553LG/ujqa+Aw8uNtunaPRVtcHU0XXldn0KPABn4 67TodbIEgPzRL7xJwdjXnRZry1RJYdBDnHwRP6RxpKrDAAvx5/BmRHoHIKiIx5Jn7T5Q Z85g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=9DI5u3KafPzj5V3i+niAdO1uhXW2it0RjumucIpkaOw=; b=jBqeji616w8/cRYGD/0uyyHHpYlVZWId159RtjW2YEXkz8WMIss3oaRg0BYlki4XYC PyHbBmXBK0ycABaPdn+eIBAlWIENvA+FxDwIU49lqiYQhpdaDsdi5N+jO6mb+JAhkyGE qQRSt4RxmhxShRs1Xd4K/jX15kJS4AG4+qi5r1jq3gAMP7gIDZLbfRVOKFPKcWBZrNyK Wg/hWP7lAnnlrFUuQabiXgQs2rKWEZcL6i2Tz1iigc5gkIAlrDhUvs913IjM1qxyEh13 2rQkab00eiKDrSGw6uaX+uUaDhHyfMYerWUZzPwXkasnYKIDpLVblzeM5TsPOvnULLUd 9H8Q== X-Gm-Message-State: AOAM533yLzjK6OpnPNswuYAQ4C786weyw+fEmNSFfXkodrW2UFNghKF0 Iq6E62uES6VmZmPhCTJv4iDTPZDPm4NW2xsW X-Google-Smtp-Source: ABdhPJzpu4qsDmsSwhmtsakN67Db1oW3vqlMK/6JoYcULaWh7/ua/BL0cxNVhiDmj+hapXuFvoOwNe42CSDioYtU Sender: "andreyknvl via sendgmr" X-Received: from andreyknvl3.muc.corp.google.com ([2a00:79e0:15:13:7220:84ff:fe09:7e9d]) (user=andreyknvl job=sendgmr) by 2002:a0c:b5e1:: with SMTP id o33mr516199qvf.17.1603372784151; Thu, 22 Oct 2020 06:19:44 -0700 (PDT) Date: Thu, 22 Oct 2020 15:19:00 +0200 In-Reply-To: Message-Id: <84dc684519c5de460c58b85f0351c4f9ab57e897.1603372719.git.andreyknvl@google.com> Mime-Version: 1.0 References: X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog Subject: [PATCH RFC v2 08/21] kasan: remove __kasan_unpoison_stack From: Andrey Konovalov To: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Marco Elver Cc: Evgenii Stepanov , Kostya Serebryany , Peter Collingbourne , Serban Constantinescu , Andrey Ryabinin , Elena Petrova , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There's no need for __kasan_unpoison_stack() helper, as it's only currently used in a single place. Removing it also removes undeed arithmetic. No functional changes. Signed-off-by: Andrey Konovalov Link: https://linux-review.googlesource.com/id/Ie5ba549d445292fe629b4a96735e4034957bcc50 --- mm/kasan/common.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/mm/kasan/common.c b/mm/kasan/common.c index a3e67d49b893..9008fc6b0810 100644 --- a/mm/kasan/common.c +++ b/mm/kasan/common.c @@ -59,18 +59,12 @@ void kasan_disable_current(void) #endif /* CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS */ #if CONFIG_KASAN_STACK -static void __kasan_unpoison_stack(struct task_struct *task, const void *sp) -{ - void *base = task_stack_page(task); - size_t size = sp - base; - - kasan_unpoison_memory(base, size); -} - /* Unpoison the entire stack for a task. */ void kasan_unpoison_task_stack(struct task_struct *task) { - __kasan_unpoison_stack(task, task_stack_page(task) + THREAD_SIZE); + void *base = task_stack_page(task); + + kasan_unpoison_memory(base, THREAD_SIZE); } /* Unpoison the stack for the current task beyond a watermark sp value. */ -- 2.29.0.rc1.297.gfa9743e501-goog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7351AC388F7 for ; Thu, 22 Oct 2020 13:19:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C97A0221FE for ; Thu, 22 Oct 2020 13:19:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="KYdK90La" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C97A0221FE Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4279E6B0087; Thu, 22 Oct 2020 09:19:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38FB16B008A; Thu, 22 Oct 2020 09:19:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 078B46B0087; Thu, 22 Oct 2020 09:19:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0240.hostedemail.com [216.40.44.240]) by kanga.kvack.org (Postfix) with ESMTP id C27916B0088 for ; Thu, 22 Oct 2020 09:19:45 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 66F02362B for ; Thu, 22 Oct 2020 13:19:45 +0000 (UTC) X-FDA: 77399618730.22.seed51_2e06dff27251 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 4B8BE18038E60 for ; Thu, 22 Oct 2020 13:19:45 +0000 (UTC) X-HE-Tag: seed51_2e06dff27251 X-Filterd-Recvd-Size: 4787 Received: from mail-qk1-f202.google.com (mail-qk1-f202.google.com [209.85.222.202]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Thu, 22 Oct 2020 13:19:44 +0000 (UTC) Received: by mail-qk1-f202.google.com with SMTP id y8so999213qki.12 for ; Thu, 22 Oct 2020 06:19:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=9DI5u3KafPzj5V3i+niAdO1uhXW2it0RjumucIpkaOw=; b=KYdK90La20UFPuJ0fER+IgQyEcsxZKP6b9b4wzo9FrNthDqnAFuD/5RyVeAhzGtgFD 1rxDr3Tc3DpMi3VJMulxGYNmOXPyCZ44TXQZaLrnagTdrvXkZGmK0uz5CxJO/kcl5io3 867JSelEDG2IXELgOzI1dAaZAG7MmtKcjNEZw8rVk16HYclXkCIp562h7Clu9cWh/Wg5 5sMDUaz9GmxLB9D5wgH9F8tliUrf553LG/ujqa+Aw8uNtunaPRVtcHU0XXldn0KPABn4 67TodbIEgPzRL7xJwdjXnRZry1RJYdBDnHwRP6RxpKrDAAvx5/BmRHoHIKiIx5Jn7T5Q Z85g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=9DI5u3KafPzj5V3i+niAdO1uhXW2it0RjumucIpkaOw=; b=R3aownqWpCif4MSE6mAivcGWCKdmAfWlstK47PMR2ckIKgytj21NYase2JWPTK4ugH oe2fCAlLNyHfnQhiAmZxfLpUQ+AJ3VGRPOYdMxxiKnZE0btZURF1jHH26euBL0htCNBh noCtN6mxSK193kBegmMedVIw5lp+cKCJj8xx46+eZesAlY9VqjCl2ygiJtLfKpK9okRJ /BET3GMooppcgTE0LnAzWoOvTQHbPYFwLfgqJhgeycOIogNoOL/IdpCzUJcJHilVi6vl MYXcL025NAhPlXa5Mru8NtVEkbt6DqAJ3ojsZDWJMOKf2LszLZj2OwFiuOeDfRdj8psS VQ3g== X-Gm-Message-State: AOAM532asKRGv+PNXr/88NKHDb1H4boOUqV7Xg0tc/eNSJUjeTDk27E7 IP3ANtrugGqQThoegmPUfRHzMnkTeMa1qPI9 X-Google-Smtp-Source: ABdhPJzpu4qsDmsSwhmtsakN67Db1oW3vqlMK/6JoYcULaWh7/ua/BL0cxNVhiDmj+hapXuFvoOwNe42CSDioYtU X-Received: from andreyknvl3.muc.corp.google.com ([2a00:79e0:15:13:7220:84ff:fe09:7e9d]) (user=andreyknvl job=sendgmr) by 2002:a0c:b5e1:: with SMTP id o33mr516199qvf.17.1603372784151; Thu, 22 Oct 2020 06:19:44 -0700 (PDT) Date: Thu, 22 Oct 2020 15:19:00 +0200 In-Reply-To: Message-Id: <84dc684519c5de460c58b85f0351c4f9ab57e897.1603372719.git.andreyknvl@google.com> Mime-Version: 1.0 References: X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog Subject: [PATCH RFC v2 08/21] kasan: remove __kasan_unpoison_stack From: Andrey Konovalov To: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Marco Elver Cc: Evgenii Stepanov , Kostya Serebryany , Peter Collingbourne , Serban Constantinescu , Andrey Ryabinin , Elena Petrova , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: There's no need for __kasan_unpoison_stack() helper, as it's only currently used in a single place. Removing it also removes undeed arithmetic. No functional changes. Signed-off-by: Andrey Konovalov Link: https://linux-review.googlesource.com/id/Ie5ba549d445292fe629b4a96735e4034957bcc50 --- mm/kasan/common.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/mm/kasan/common.c b/mm/kasan/common.c index a3e67d49b893..9008fc6b0810 100644 --- a/mm/kasan/common.c +++ b/mm/kasan/common.c @@ -59,18 +59,12 @@ void kasan_disable_current(void) #endif /* CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS */ #if CONFIG_KASAN_STACK -static void __kasan_unpoison_stack(struct task_struct *task, const void *sp) -{ - void *base = task_stack_page(task); - size_t size = sp - base; - - kasan_unpoison_memory(base, size); -} - /* Unpoison the entire stack for a task. */ void kasan_unpoison_task_stack(struct task_struct *task) { - __kasan_unpoison_stack(task, task_stack_page(task) + THREAD_SIZE); + void *base = task_stack_page(task); + + kasan_unpoison_memory(base, THREAD_SIZE); } /* Unpoison the stack for the current task beyond a watermark sp value. */ -- 2.29.0.rc1.297.gfa9743e501-goog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41266C388F2 for ; Thu, 22 Oct 2020 13:23:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C47EF20848 for ; Thu, 22 Oct 2020 13:23:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cAJU0R1W"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="KYdK90La" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C47EF20848 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:From:Subject:References:Mime-Version:Message-Id: In-Reply-To:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ejx4Srwlbiq5dtuKCECYlaEMasJP1rkHXXJsGOd5Q1c=; b=cAJU0R1Wg3P48LqEMeHJ+IcnO l3/swtgW4YyWXDjR/nHmDDkpcRHcD54k4Px1DFuzGAiT0F5DZiF5rKsry9h9XCeQsu8SqP9hvXvto IRZMgsYjMUo1jaxUO/l0G+R3LhjeoD4ciOMkQvENDLwcUwJR4kS1pVsh40gmXKcQFUQCSIZ3QG0ei lgcjos2NGPM6xNTWtfsZP98NJIAiaIGwV3MKm8SZGEkybQkYncU6qe1HH/NowR+CqQwNepUmj3Hhm y7cmRCeUfguE2KHd+bNeUQXBWbBw5YiinxEeHZOV91O3huXfpQcDvqygUKyUGHdUqsdYNbSXaoZM0 LcN3zg4ig==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVaXT-0004Tv-7J; Thu, 22 Oct 2020 13:21:55 +0000 Received: from mail-qk1-x74a.google.com ([2607:f8b0:4864:20::74a]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVaVQ-0003jU-Kk for linux-arm-kernel@lists.infradead.org; Thu, 22 Oct 2020 13:19:57 +0000 Received: by mail-qk1-x74a.google.com with SMTP id k12so986681qkj.18 for ; Thu, 22 Oct 2020 06:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=9DI5u3KafPzj5V3i+niAdO1uhXW2it0RjumucIpkaOw=; b=KYdK90La20UFPuJ0fER+IgQyEcsxZKP6b9b4wzo9FrNthDqnAFuD/5RyVeAhzGtgFD 1rxDr3Tc3DpMi3VJMulxGYNmOXPyCZ44TXQZaLrnagTdrvXkZGmK0uz5CxJO/kcl5io3 867JSelEDG2IXELgOzI1dAaZAG7MmtKcjNEZw8rVk16HYclXkCIp562h7Clu9cWh/Wg5 5sMDUaz9GmxLB9D5wgH9F8tliUrf553LG/ujqa+Aw8uNtunaPRVtcHU0XXldn0KPABn4 67TodbIEgPzRL7xJwdjXnRZry1RJYdBDnHwRP6RxpKrDAAvx5/BmRHoHIKiIx5Jn7T5Q Z85g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=9DI5u3KafPzj5V3i+niAdO1uhXW2it0RjumucIpkaOw=; b=Ac7apijX89uchb5yWA5Ivzy0FcN2MOOkAgM9dWUD/5WYubb9MX6wsqwxBz5vmjwC+a YqfO+tDsFLhC9kbw8hOFUlJqnJmJDymYjKtVG2QRD5m1l7o+BMFELDLfRvUwua1etYre BzPNvw1hjky5iJBDNK/rBO6+Ikp4mKF4D9W/60Fb+nU4fgfokVAmTWNMpj4NpQaoxprJ cfJ57qiYi5VAopTk6mRhQBCoJvQdIKSKR+Xng9Ha2BApTUcNmymH6FRJ9KO+CFs2rIGp 3P7Y+rIulkcf0Za0yRMBwzX0cSQgD8M7Z/Fc73tGnVx62A1BViG/sla/2xw71g3m/Vnu RJkQ== X-Gm-Message-State: AOAM533MEFEqoUARj13rOa5qSRAVYakHZDaMZ78xaE3zKmgMs+FKmSK9 1qZXcCnHlxi6vXAQrbN06c0ajLJV/vPA3gHA X-Google-Smtp-Source: ABdhPJzpu4qsDmsSwhmtsakN67Db1oW3vqlMK/6JoYcULaWh7/ua/BL0cxNVhiDmj+hapXuFvoOwNe42CSDioYtU X-Received: from andreyknvl3.muc.corp.google.com ([2a00:79e0:15:13:7220:84ff:fe09:7e9d]) (user=andreyknvl job=sendgmr) by 2002:a0c:b5e1:: with SMTP id o33mr516199qvf.17.1603372784151; Thu, 22 Oct 2020 06:19:44 -0700 (PDT) Date: Thu, 22 Oct 2020 15:19:00 +0200 In-Reply-To: Message-Id: <84dc684519c5de460c58b85f0351c4f9ab57e897.1603372719.git.andreyknvl@google.com> Mime-Version: 1.0 References: X-Mailer: git-send-email 2.29.0.rc1.297.gfa9743e501-goog Subject: [PATCH RFC v2 08/21] kasan: remove __kasan_unpoison_stack From: Andrey Konovalov To: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Marco Elver X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201022_091948_732883_D3C0A404 X-CRM114-Status: GOOD ( 12.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Branislav Rankov , Elena Petrova , linux-mm@kvack.org, Andrey Konovalov , Kevin Brodsky , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Kostya Serebryany , linux-arm-kernel@lists.infradead.org, Serban Constantinescu , Andrey Ryabinin , Andrew Morton , Peter Collingbourne , Evgenii Stepanov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There's no need for __kasan_unpoison_stack() helper, as it's only currently used in a single place. Removing it also removes undeed arithmetic. No functional changes. Signed-off-by: Andrey Konovalov Link: https://linux-review.googlesource.com/id/Ie5ba549d445292fe629b4a96735e4034957bcc50 --- mm/kasan/common.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/mm/kasan/common.c b/mm/kasan/common.c index a3e67d49b893..9008fc6b0810 100644 --- a/mm/kasan/common.c +++ b/mm/kasan/common.c @@ -59,18 +59,12 @@ void kasan_disable_current(void) #endif /* CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS */ #if CONFIG_KASAN_STACK -static void __kasan_unpoison_stack(struct task_struct *task, const void *sp) -{ - void *base = task_stack_page(task); - size_t size = sp - base; - - kasan_unpoison_memory(base, size); -} - /* Unpoison the entire stack for a task. */ void kasan_unpoison_task_stack(struct task_struct *task) { - __kasan_unpoison_stack(task, task_stack_page(task) + THREAD_SIZE); + void *base = task_stack_page(task); + + kasan_unpoison_memory(base, THREAD_SIZE); } /* Unpoison the stack for the current task beyond a watermark sp value. */ -- 2.29.0.rc1.297.gfa9743e501-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel