From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH v2 12/18] xen: setup Xen specific data for PVH Date: Mon, 29 Oct 2018 15:19:34 +0100 Message-ID: <84ede595-1603-9f1c-743b-5a03e5dcda04@suse.com> References: <20181009110317.6022-1-jgross@suse.com> <20181009110317.6022-13-jgross@suse.com> <20181019161015.d6u47uwvvxgiu7lm@mac.bytemobile.com> <20181029125724.mpqrtdiz3waus5w2@mac.bytemobile.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181029125724.mpqrtdiz3waus5w2@mac.bytemobile.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: hans@knorrie.org, grub-devel@gnu.org, daniel.kiper@oracle.com, xen-devel@lists.xen.org, phcoder@gmail.com List-Id: xen-devel@lists.xenproject.org T24gMjkvMTAvMjAxOCAxMzo1NywgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToKPiBPbiBGcmksIE9j dCAxOSwgMjAxOCBhdCAwNjozOTo1MFBNICswMjAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOgo+PiBP biAxOS8xMC8yMDE4IDE4OjEwLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOgo+Pj4gT24gVHVlLCBP Y3QgMDksIDIwMTggYXQgMDE6MDM6MTFQTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToKPj4+ PiBJbml0aWFsaXplIHRoZSBuZWVkZWQgWGVuIHNwZWNpZmljIGRhdGEuIFRoaXMgaXM6Cj4+Pj4K Pj4+PiAtIHRoZSBYZW4gc3RhcnQgb2YgZGF5IHBhZ2UgY29udGFpbmluZyB0aGUgY29uc29sZSBh bmQgWGVuc3RvcmUgcmluZwo+Pj4+ICAgcGFnZSBQRk4gYW5kIGV2ZW50IGNoYW5uZWwKPj4+PiAt IHRoZSBncmFudCB0YWJsZQo+Pj4+IC0gdGhlIHNoYXJlZCBpbmZvIHBhZ2UKPj4+Pgo+Pj4+IFNl dCB0aGUgUlNEUCBhZGRyZXNzIGZvciB0aGUgZ3Vlc3QgZnJvbSB0aGUgc3RhcnRfaW5mbyBwYWdl IHBhc3NlZAo+Pj4+IGFzIGJvb3QgcGFyYW1ldGVyLgo+Pj4+Cj4+Pj4gU2lnbmVkLW9mZi1ieTog SnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgo+Pj4+IC0tLQo+Pj4+ICBncnViLWNvcmUv a2Vybi9pMzg2L3hlbi9wdmguYyB8IDEwNyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysKPj4+PiAgMSBmaWxlIGNoYW5nZWQsIDEwNyBpbnNlcnRpb25zKCspCj4+Pj4K Pj4+PiBkaWZmIC0tZ2l0IGEvZ3J1Yi1jb3JlL2tlcm4vaTM4Ni94ZW4vcHZoLmMgYi9ncnViLWNv cmUva2Vybi9pMzg2L3hlbi9wdmguYwo+Pj4+IGluZGV4IGI0OTMzYjQ1NC4uOTNlZDY4MjQ1IDEw MDY0NAo+Pj4+IC0tLSBhL2dydWItY29yZS9rZXJuL2kzODYveGVuL3B2aC5jCj4+Pj4gKysrIGIv Z3J1Yi1jb3JlL2tlcm4vaTM4Ni94ZW4vcHZoLmMKPj4+PiBAQCAtMjQsNiArMjQsNyBAQAo+Pj4+ ICAjaW5jbHVkZSA8Z3J1Yi94ZW4uaD4KPj4+PiAgI2luY2x1ZGUgPGdydWIvaTM4Ni9saW51eC5o Pgo+Pj4+ICAjaW5jbHVkZSA8Z3J1Yi9tYWNoaW5lL2tlcm5lbC5oPgo+Pj4+ICsjaW5jbHVkZSA8 eGVuL2h2bS9wYXJhbXMuaD4KPj4+PiAgI2luY2x1ZGUgPHhlbi9tZW1vcnkuaD4KPj4+PiAgCj4+ Pj4gIHN0cnVjdCB4ZW5fbWFjaGluZV9tbWFwX2VudHJ5Cj4+Pj4gQEAgLTM5LDYgKzQwLDcgQEAg c3RhdGljIHN0cnVjdCB7IGNoYXIgX2VudHJ5WzMyXTsgfSBoeXBlcmNhbGxfcGFnZVsxMjhdCj4+ Pj4gICAgX19hdHRyaWJ1dGVfXyAoKGFsaWduZWQgKEdSVUJfWEVOX1BBR0VfU0laRSkpKTsKPj4+ PiAgCj4+Pj4gIHN0YXRpYyBncnViX3VpbnQzMl90IHhlbl9jcHVpZF9iYXNlOwo+Pj4+ICtzdGF0 aWMgc3RydWN0IHN0YXJ0X2luZm8gZ3J1Yl94ZW5fc3RhcnRfcGFnZTsKPj4+PiAgc3RhdGljIHN0 cnVjdCB4ZW5fbWFjaGluZV9tbWFwX2VudHJ5IG1hcFsxMjhdOwo+Pj4+ICBzdGF0aWMgdW5zaWdu ZWQgaW50IG5yX21hcF9lbnRyaWVzOwo+Pj4+ICAKPj4+PiBAQCAtMTA0LDYgKzEwNiwzNiBAQCBn cnViX3hlbl9oeXBlcmNhbGwgKGdydWJfdWludDMyX3QgY2FsbG5vLCBncnViX3VpbnQzMl90IGEw LAo+Pj4+ICAgIHJldHVybiBfX3JlczsKPj4+PiAgfQo+Pj4+ICAKPj4+PiArc3RhdGljIGdydWJf dWludDMyX3QKPj4+PiArZ3J1Yl94ZW5fZ2V0X3BhcmFtIChpbnQgaWR4KQo+Pj4+ICt7Cj4+Pj4g KyAgc3RydWN0IHhlbl9odm1fcGFyYW0geGh2Owo+Pj4+ICsgIGludCByOwo+Pj4+ICsKPj4+PiAr ICB4aHYuZG9taWQgPSBET01JRF9TRUxGOwo+Pj4+ICsgIHhodi5pbmRleCA9IGlkeDsKPj4+PiAr ICByID0gZ3J1Yl94ZW5faHlwZXJjYWxsIChfX0hZUEVSVklTT1JfaHZtX29wLCBIVk1PUF9nZXRf cGFyYW0sCj4+Pj4gKwkJCSAgKGdydWJfdWludDMyX3QpICgmeGh2KSwgMCwgMCwgMCwgMCk7Cj4+ Pj4gKyAgaWYgKHIgPCAwKQo+Pj4+ICsgICAgZ3J1Yl94ZW5fZWFybHlfaGFsdCAoKTsKPj4+PiAr ICByZXR1cm4geGh2LnZhbHVlOwo+Pj4+ICt9Cj4+Pj4gKwo+Pj4+ICtzdGF0aWMgdm9pZCAqCj4+ Pj4gK2dydWJfeGVuX2FkZF9waHlzbWFwICh1bnNpZ25lZCBpbnQgc3BhY2UsIHZvaWQgKmFkZHIp Cj4+Pj4gK3sKPj4+PiArICBzdHJ1Y3QgeGVuX2FkZF90b19waHlzbWFwIHhhdHA7Cj4+Pj4gKwo+ Pj4+ICsgIHhhdHAuZG9taWQgPSBET01JRF9TRUxGOwo+Pj4+ICsgIHhhdHAuaWR4ID0gMDsKPj4+ PiArICB4YXRwLnNwYWNlID0gc3BhY2U7Cj4+Pj4gKyAgeGF0cC5ncGZuID0gKGdydWJfYWRkcl90 KSBhZGRyID4+IEdSVUJfWEVOX0xPR19QQUdFX1NJWkU7Cj4+Pj4gKyAgaWYgKGdydWJfeGVuX2h5 cGVyY2FsbCAoX19IWVBFUlZJU09SX21lbW9yeV9vcCwgWEVOTUVNX2FkZF90b19waHlzbWFwLAo+ Pj4+ICsJCQkgIChncnViX3VpbnQzMl90KSAoJnhhdHApLCAwLCAwLCAwLCAwKSkKPj4+PiArICAg IGdydWJfeGVuX2Vhcmx5X2hhbHQgKCk7Cj4+Pj4gKyAgcmV0dXJuIGFkZHI7Cj4+Pj4gK30KPj4+ PiArCj4+Pj4gIHN0YXRpYyB2b2lkCj4+Pj4gIGdydWJfeGVuX3NvcnRfbW1hcCAodm9pZCkKPj4+ PiAgewo+Pj4+IEBAIC0xOTAsMTIgKzIyMiw4NyBAQCBncnViX3hlbl9nZXRfbW1hcCAodm9pZCkK Pj4+PiAgICBncnViX3hlbl9zb3J0X21tYXAgKCk7Cj4+Pj4gIH0KPj4+PiAgCj4+Pj4gK3N0YXRp YyBncnViX3VpbnQ2NF90Cj4+Pj4gK2dydWJfeGVuX2ZpbmRfcGFnZSAoZ3J1Yl91aW50NjRfdCBz dGFydCkKPj4+PiArewo+Pj4+ICsgIHVuc2lnbmVkIGludCBpLCBqOwo+Pj4+ICsgIGdydWJfdWlu dDY0X3QgbGFzdCA9IHN0YXJ0Owo+Pj4+ICsKPj4+PiArICAvKiBUcnkgdG8gZmluZCBhIGU4MjAg bWFwIGhvbGUgYmVsb3cgNEcuICovCj4+Pgo+Pj4gRG9pbmcgdGhpcyBpcyBraW5kIG9mIGRhbmdl cm91cywgd2hhdCBpZiB5b3UgZW5kIHVwIHBsYWNpbmcgc29tZXRoaW5nCj4+PiBvbiB0b3Agb2Yg YW4gTU1JTyByZWdpb24gKGVpdGhlciBlbXVsYXRlZCBvciBmcm9tIGEgcmVhbCBwYXNzdGhyb3Vn aAo+Pj4gZGV2aWNlKT8KPj4KPj4gU2hvdWxkbid0IHRob3NlIGJlIG1hcmtlZCBhcyAiUmVzZXJ2 ZWQiIGluIHRoZSBtZW1vcnkgbWFwPwo+IAo+IEkgZG9uJ3QgdGhpbmsgQkFScyBhcmUgZ3VhcmFu dGVlZCB0byBiZSBpbiBhcmVhcyBtYXJrZWQgYXMgcmVzZXJ2ZWQgaW4KPiB0aGUgbWVtb3J5IG1h cC4gVW5sZXNzIHlvdSBhbHNvIHNjYW4gZm9yIFBDSSBkZXZpY2VzIGFuZCBtYWtlIHN1cmUKPiB0 aGVyZSdzIG5vIGRldmljZSB3aXRoIGEgQkFSIGluIHRoZSBhcmVhIHlvdSBhcmUgYXR0ZW1wdGlu ZyB0bwo+IHBvcHVsYXRlIEkgdGhpbmsgdGhlIGFib3ZlIGlzIG5vdCBzYWZlLgoKU28gZWl0aGVy IEkgY2FuIGFkZCBzY2FubmluZyB0aGUgUENJIGJ1cyAod2hpY2ggd291bGRuJ3QgYmUgdG9vCmhh cmQgSU1PKSwgb3Igd2UgcmVxdWlyZSBYZW4gdG9vbHMgdG8gYWRkIG1lbW9yeSBtYXAgZW50cmll cyB3aXRoCiJSZXNlcnZlZCIgYXR0cmlidXRlIGZvciBwYXNzZWQtdGhyb3VnaCBQQ0kgZGV2aWNl J3MgTU1JTy1hcmVhcwood2UgY2FuIHN0aWxsIGRvIHRoYXQgYXMgUENJIHBhc3MtdGhyb3VnaCBm b3IgUFZIIGlzbid0IHBvc3NpYmxlCnlldCBBRkFJSykuCgoKSnVlcmdlbgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlz dApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0 Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gH8OQ-0004xb-0J for mharc-grub-devel@gnu.org; Mon, 29 Oct 2018 10:19:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gH8ON-0004tw-Ca for grub-devel@gnu.org; Mon, 29 Oct 2018 10:19:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gH8OJ-0004Zd-LM for grub-devel@gnu.org; Mon, 29 Oct 2018 10:19:43 -0400 Received: from mx2.suse.de ([195.135.220.15]:55924 helo=mx1.suse.de) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gH8OJ-0004W4-7o for grub-devel@gnu.org; Mon, 29 Oct 2018 10:19:39 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 2B2F9AF59; Mon, 29 Oct 2018 14:19:35 +0000 (UTC) Subject: Re: [Xen-devel] [PATCH v2 12/18] xen: setup Xen specific data for PVH To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: grub-devel@gnu.org, hans@knorrie.org, phcoder@gmail.com, daniel.kiper@oracle.com, xen-devel@lists.xen.org References: <20181009110317.6022-1-jgross@suse.com> <20181009110317.6022-13-jgross@suse.com> <20181019161015.d6u47uwvvxgiu7lm@mac.bytemobile.com> <20181029125724.mpqrtdiz3waus5w2@mac.bytemobile.com> From: Juergen Gross Openpgp: preference=signencrypt Autocrypt: addr=jgross@suse.com; prefer-encrypt=mutual; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNHkp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmRlPsLAeQQTAQIAIwUCU4xw6wIbAwcL CQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJELDendYovxMvi4UH/Ri+OXlObzqMANruTd4N zmVBAZgx1VW6jLc8JZjQuJPSsd/a+bNr3BZeLV6lu4Pf1Yl2Log129EX1KWYiFFvPbIiq5M5 kOXTO8Eas4CaScCvAZ9jCMQCgK3pFqYgirwTgfwnPtxFxO/F3ZcS8jovza5khkSKL9JGq8Nk czDTruQ/oy0WUHdUr9uwEfiD9yPFOGqp4S6cISuzBMvaAiC5YGdUGXuPZKXLpnGSjkZswUzY d9BVSitRL5ldsQCg6GhDoEAeIhUC4SQnT9SOWkoDOSFRXZ+7+WIBGLiWMd+yKDdRG5RyP/8f 3tgGiB6cyuYfPDRGsELGjUaTUq3H2xZgIPfOwE0EU4xwFgEIAMsx+gDjgzAY4H1hPVXgoLK8 B93sTQFN9oC6tsb46VpxyLPfJ3T1A6Z6MVkLoCejKTJ3K9MUsBZhxIJ0hIyvzwI6aYJsnOew cCiCN7FeKJ/oA1RSUemPGUcIJwQuZlTOiY0OcQ5PFkV5YxMUX1F/aTYXROXgTmSaw0aC1Jpo w7Ss1mg4SIP/tR88/d1+HwkJDVW1RSxC1PWzGizwRv8eauImGdpNnseneO2BNWRXTJumAWDD pYxpGSsGHXuZXTPZqOOZpsHtInFyi5KRHSFyk2Xigzvh3b9WqhbgHHHE4PUVw0I5sIQt8hJq 5nH5dPqz4ITtCL9zjiJsExHuHKN3NZsAEQEAAcLAXwQYAQIACQUCU4xwFgIbDAAKCRCw3p3W KL8TL0P4B/9YWver5uD/y/m0KScK2f3Z3mXJhME23vGBbMNlfwbr+meDMrJZ950CuWWnQ+d+ Ahe0w1X7e3wuLVODzjcReQ/v7b4JD3wwHxe+88tgB9byc0NXzlPJWBaWV01yB2/uefVKryAf AHYEd0gCRhx7eESgNBe3+YqWAQawunMlycsqKa09dBDL1PFRosF708ic9346GLHRc6Vj5SRA UTHnQqLetIOXZm3a2eQ1gpQK9MmruO86Vo93p39bS1mqnLLspVrL4rhoyhsOyh0Hd28QCzpJ wKeHTd0MAWAirmewHXWPco8p1Wg+V+5xfZzuQY0f4tQxvOpXpt4gQ1817GQ5/Ed/wsDtBBgB CAAgFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAlrd8NACGwIAgQkQsN6d1ii/Ey92IAQZFggA HRYhBFMtsHpB9jjzHji4HoBcYbtP2GO+BQJa3fDQAAoJEIBcYbtP2GO+TYsA/30H/0V6cr/W V+J/FCayg6uNtm3MJLo4rE+o4sdpjjsGAQCooqffpgA+luTT13YZNV62hAnCLKXH9n3+ZAgJ RtAyDWk1B/0SMDVs1wxufMkKC3Q/1D3BYIvBlrTVKdBYXPxngcRoqV2J77lscEvkLNUGsu/z W2pf7+P3mWWlrPMJdlbax00vevyBeqtqNKjHstHatgMZ2W0CFC4hJ3YEetuRBURYPiGzuJXU pAd7a7BdsqWC4o+GTm5tnGrCyD+4gfDSpkOT53S/GNO07YkPkm/8J4OBoFfgSaCnQ1izwgJQ jIpcG2fPCI2/hxf2oqXPYbKr1v4Z1wthmoyUgGN0LPTIm+B5vdY82wI5qe9uN6UOGyTH2B3p hRQUWqCwu2sqkI3LLbTdrnyDZaixT2T0f4tyF5Lfs+Ha8xVMhIyzNb1byDI5FKCb Message-ID: <84ede595-1603-9f1c-743b-5a03e5dcda04@suse.com> Date: Mon, 29 Oct 2018 15:19:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181029125724.mpqrtdiz3waus5w2@mac.bytemobile.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 195.135.220.15 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 14:19:44 -0000 On 29/10/2018 13:57, Roger Pau Monn=C3=A9 wrote: > On Fri, Oct 19, 2018 at 06:39:50PM +0200, Juergen Gross wrote: >> On 19/10/2018 18:10, Roger Pau Monn=C3=A9 wrote: >>> On Tue, Oct 09, 2018 at 01:03:11PM +0200, Juergen Gross wrote: >>>> Initialize the needed Xen specific data. This is: >>>> >>>> - the Xen start of day page containing the console and Xenstore ring >>>> page PFN and event channel >>>> - the grant table >>>> - the shared info page >>>> >>>> Set the RSDP address for the guest from the start_info page passed >>>> as boot parameter. >>>> >>>> Signed-off-by: Juergen Gross >>>> --- >>>> grub-core/kern/i386/xen/pvh.c | 107 +++++++++++++++++++++++++++++++= +++++++++++ >>>> 1 file changed, 107 insertions(+) >>>> >>>> diff --git a/grub-core/kern/i386/xen/pvh.c b/grub-core/kern/i386/xen= /pvh.c >>>> index b4933b454..93ed68245 100644 >>>> --- a/grub-core/kern/i386/xen/pvh.c >>>> +++ b/grub-core/kern/i386/xen/pvh.c >>>> @@ -24,6 +24,7 @@ >>>> #include >>>> #include >>>> #include >>>> +#include >>>> #include >>>> =20 >>>> struct xen_machine_mmap_entry >>>> @@ -39,6 +40,7 @@ static struct { char _entry[32]; } hypercall_page[= 128] >>>> __attribute__ ((aligned (GRUB_XEN_PAGE_SIZE))); >>>> =20 >>>> static grub_uint32_t xen_cpuid_base; >>>> +static struct start_info grub_xen_start_page; >>>> static struct xen_machine_mmap_entry map[128]; >>>> static unsigned int nr_map_entries; >>>> =20 >>>> @@ -104,6 +106,36 @@ grub_xen_hypercall (grub_uint32_t callno, grub_= uint32_t a0, >>>> return __res; >>>> } >>>> =20 >>>> +static grub_uint32_t >>>> +grub_xen_get_param (int idx) >>>> +{ >>>> + struct xen_hvm_param xhv; >>>> + int r; >>>> + >>>> + xhv.domid =3D DOMID_SELF; >>>> + xhv.index =3D idx; >>>> + r =3D grub_xen_hypercall (__HYPERVISOR_hvm_op, HVMOP_get_param, >>>> + (grub_uint32_t) (&xhv), 0, 0, 0, 0); >>>> + if (r < 0) >>>> + grub_xen_early_halt (); >>>> + return xhv.value; >>>> +} >>>> + >>>> +static void * >>>> +grub_xen_add_physmap (unsigned int space, void *addr) >>>> +{ >>>> + struct xen_add_to_physmap xatp; >>>> + >>>> + xatp.domid =3D DOMID_SELF; >>>> + xatp.idx =3D 0; >>>> + xatp.space =3D space; >>>> + xatp.gpfn =3D (grub_addr_t) addr >> GRUB_XEN_LOG_PAGE_SIZE; >>>> + if (grub_xen_hypercall (__HYPERVISOR_memory_op, XENMEM_add_to_phy= smap, >>>> + (grub_uint32_t) (&xatp), 0, 0, 0, 0)) >>>> + grub_xen_early_halt (); >>>> + return addr; >>>> +} >>>> + >>>> static void >>>> grub_xen_sort_mmap (void) >>>> { >>>> @@ -190,12 +222,87 @@ grub_xen_get_mmap (void) >>>> grub_xen_sort_mmap (); >>>> } >>>> =20 >>>> +static grub_uint64_t >>>> +grub_xen_find_page (grub_uint64_t start) >>>> +{ >>>> + unsigned int i, j; >>>> + grub_uint64_t last =3D start; >>>> + >>>> + /* Try to find a e820 map hole below 4G. */ >>> >>> Doing this is kind of dangerous, what if you end up placing something >>> on top of an MMIO region (either emulated or from a real passthrough >>> device)? >> >> Shouldn't those be marked as "Reserved" in the memory map? >=20 > I don't think BARs are guaranteed to be in areas marked as reserved in > the memory map. Unless you also scan for PCI devices and make sure > there's no device with a BAR in the area you are attempting to > populate I think the above is not safe. So either I can add scanning the PCI bus (which wouldn't be too hard IMO), or we require Xen tools to add memory map entries with "Reserved" attribute for passed-through PCI device's MMIO-areas (we can still do that as PCI pass-through for PVH isn't possible yet AFAIK). Juergen