From: "Chubb, Peter (Data61, Kensington NSW)" <Peter.Chubb@data61.csiro.au>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Hannes Reinecke" <hare@suse.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
"qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
"Jason Wang" <jasowang@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Max Reitz" <mreitz@redhat.com>,
"Andrew Jeffery" <andrew@aj.id.au>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"Peter Chubb" <peter.chubb@nicta.com.au>,
"Cédric Le Goater" <clg@kaod.org>,
"Kevin Wolf" <kwolf@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Joel Stanley" <joel@jms.id.au>
Subject: Re: [PATCH 0/6] Fix more GCC9 -O3 warnings
Date: Tue, 17 Dec 2019 21:49:35 +0000 [thread overview]
Message-ID: <84fthiaahd.wl-Peter.Chubb@data61.csiro.au> (raw)
In-Reply-To: <20191217173252.4672-1-philmd@redhat.com>
>>>>> "Philippe" == Philippe Mathieu-Daudé <philmd@redhat.com> writes:
Philippe> Fix some trivial warnings when building with -O3.
For compatibility with lint and other older checkers, it'd be good to keep
this as /* FALLTHROUGH */ (which gcc should accept according to its
manual).
Fixing the comments' placement is a different matter, and should be
done. Seems to me that until gcc started warning for this, noone had
actually run a checker, and the comments were just for human info.
Peter C
--
Dr Peter Chubb Tel: +61 2 9490 5852 http://ts.data61.csiro.au/
Trustworthy Systems Group Data61 (formerly NICTA)
next prev parent reply other threads:[~2019-12-17 21:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 17:32 [PATCH 0/6] Fix more GCC9 -O3 warnings Philippe Mathieu-Daudé
2019-12-17 17:39 ` Philippe Mathieu-Daudé
2020-01-23 11:28 ` Alex Bennée
2020-01-23 17:55 ` Philippe Mathieu-Daudé
2020-01-23 18:26 ` Alex Bennée
2019-12-17 21:49 ` Chubb, Peter (Data61, Kensington NSW) [this message]
2019-12-18 6:05 ` Markus Armbruster
2020-01-18 19:24 ` Paolo Bonzini
2020-01-20 19:02 ` Philippe Mathieu-Daudé
2020-01-21 10:49 ` Paolo Bonzini
2019-12-17 17:34 Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84fthiaahd.wl-Peter.Chubb@data61.csiro.au \
--to=peter.chubb@data61.csiro.au \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=fam@euphon.net \
--cc=hare@suse.com \
--cc=jasowang@redhat.com \
--cc=joel@jms.id.au \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.chubb@nicta.com.au \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.