All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Wiles, Keith" <keith.wiles@intel.com>
To: Matan Azrad <matan@mellanox.com>
Cc: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
	"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
	"Thomas Monjalon" <thomas@monjalon.net>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH 1/2] eal: add API to align integer to	previous	power of 2
Date: Mon, 19 Feb 2018 13:55:33 +0000	[thread overview]
Message-ID: <8522C580-BFB3-4D1B-A331-45DA05427D50@intel.com> (raw)
In-Reply-To: <AM4PR0501MB265726E53B5A1F52499B9E47D2C80@AM4PR0501MB2657.eurprd05.prod.outlook.com>



> On Feb 19, 2018, at 12:03 AM, Matan Azrad <matan@mellanox.com> wrote:
> 
> 
>> 
>> Is this the type of API that needs to be marked experimental,
> 
> I think it is relevant to any exposed API(not only for internal libraries).
> 
>> we should be able to prove these functions, correct?
> 
> Don't we need to prove any function in DPDK?
> What is your point?


My point is this is a inline function and can not be placed in the .map file as a external API. These simple type of APIs are easy to prove and making them experimental seems to just cause an extra step. If the functions are not required that is a different problem or if the API is really only ever used by a single function or module of files then it should be moved to the module/file and made locate to the module/file.

> 
>>> Matan
>> 
>> Regards,
>> Keith

Regards,
Keith

  reply	other threads:[~2018-02-19 13:55 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-17 10:49 [PATCH 1/2] eal: add API to align integer to previous power of 2 Pavan Nikhilesh
2018-02-17 10:49 ` [PATCH 2/2] test: update common auto test Pavan Nikhilesh
2018-02-18  6:11 ` [PATCH 1/2] eal: add API to align integer to previous power of 2 Matan Azrad
     [not found]   ` <28F3DAA5-CCAB-4D2E-A6C9-FEB685A619C8@intel.com>
2018-02-19  6:03     ` Matan Azrad
2018-02-19 13:55       ` Wiles, Keith [this message]
2018-02-19 14:13         ` Matan Azrad
2018-02-19 14:21           ` Wiles, Keith
2018-02-19 16:18           ` Thomas Monjalon
2018-02-19  8:36   ` Pavan Nikhilesh
2018-02-19 11:36 ` [PATCH v2 " Pavan Nikhilesh
2018-02-19 11:36   ` [PATCH v2 2/2] test: update common auto test Pavan Nikhilesh
2018-02-19 12:09   ` [PATCH v2 1/2] eal: add API to align integer to previous power of 2 Matan Azrad
2018-02-26 19:10     ` Pavan Nikhilesh
2018-02-27 19:30       ` Matan Azrad
2018-04-04 10:16 ` [PATCH v3 " Pavan Nikhilesh
2018-04-04 10:16   ` [PATCH v3 2/2] test: update common auto test Pavan Nikhilesh
2018-04-04 12:49     ` Thomas Monjalon
2018-04-04 12:54       ` Pavan Nikhilesh
2018-04-04 16:10   ` [PATCH v3 1/2] eal: add API to align integer to previous power of 2 Matan Azrad
2018-04-04 16:42     ` Pavan Nikhilesh
2018-04-04 17:11       ` Matan Azrad
2018-04-04 17:51         ` Pavan Nikhilesh
2018-04-04 18:10           ` Matan Azrad
2018-04-04 18:15             ` Pavan Nikhilesh
2018-04-04 18:23               ` Matan Azrad
2018-04-04 18:36                 ` Pavan Nikhilesh
2018-04-04 19:41                   ` Matan Azrad
2018-04-04 13:20 ` [PATCH v4] " Pavan Nikhilesh
2018-04-04 15:23   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8522C580-BFB3-4D1B-A331-45DA05427D50@intel.com \
    --to=keith.wiles@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=matan@mellanox.com \
    --cc=pbhagavatula@caviumnetworks.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.