All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jinlong Chen <nickyc975@zju.edu.cn>
To: axboe@kernel.dk
Cc: hch@lst.de, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, nickyc975@zju.edu.cn
Subject: [PATCH 2/4] elevator: replace continue with else-if in elv_iosched_show
Date: Fri, 25 Nov 2022 23:53:12 +0800	[thread overview]
Message-ID: <852b18c086ef08baec99d08479a3558a3d5db70f.1669391142.git.nickyc975@zju.edu.cn> (raw)
In-Reply-To: <cover.1669391142.git.nickyc975@zju.edu.cn>

else-if is more readable than continue here.

Signed-off-by: Jinlong Chen <nickyc975@zju.edu.cn>
---
 block/elevator.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/block/elevator.c b/block/elevator.c
index 308bee253564..ffa750976d25 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -776,11 +776,9 @@ ssize_t elv_iosched_show(struct request_queue *q, char *name)
 
 	spin_lock(&elv_list_lock);
 	list_for_each_entry(e, &elv_list, list) {
-		if (e == cur) {
+		if (e == cur)
 			len += sprintf(name+len, "[%s] ", cur->elevator_name);
-			continue;
-		}
-		if (elv_support_features(q, e))
+		else if (elv_support_features(q, e))
 			len += sprintf(name+len, "%s ", e->elevator_name);
 	}
 	spin_unlock(&elv_list_lock);
-- 
2.34.1


  parent reply	other threads:[~2022-11-25 15:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-25 15:53 [PATCH 0/4] random improvements and cleanups for elevator.c Jinlong Chen
2022-11-25 15:53 ` [PATCH 1/4] elevator: print none at first in elv_iosched_show even if the queue has a scheduler Jinlong Chen
2022-11-29  8:30   ` Christoph Hellwig
2022-11-25 15:53 ` Jinlong Chen [this message]
2022-11-29  8:33   ` [PATCH 2/4] elevator: replace continue with else-if in elv_iosched_show Christoph Hellwig
2022-11-29 10:51     ` Jinlong Chen
2022-11-25 15:53 ` [PATCH 3/4] elevator: repalce "len+name" with "name+len" " Jinlong Chen
2022-11-29  8:33   ` Christoph Hellwig
2022-11-25 15:53 ` [PATCH 4/4] elevator: use bool instead of int as the return type of elv_iosched_allow_bio_merge Jinlong Chen
2022-11-29  8:34   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=852b18c086ef08baec99d08479a3558a3d5db70f.1669391142.git.nickyc975@zju.edu.cn \
    --to=nickyc975@zju.edu.cn \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.