From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27F0FC433EF for ; Fri, 25 Feb 2022 13:30:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241384AbiBYNbW (ORCPT ); Fri, 25 Feb 2022 08:31:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241369AbiBYNbP (ORCPT ); Fri, 25 Feb 2022 08:31:15 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FFA72275A5 for ; Fri, 25 Feb 2022 05:30:41 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id y5so1682225wmi.0 for ; Fri, 25 Feb 2022 05:30:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=iCYug2uN0yJ0h5qzrzM0t/ZXG7y0pW69zdo3//wJ5Mc=; b=Iz/C4kfIg+QU3WpdVAdERt4dHyjlNNmL0wic5dOiAa2/KqYsxtSwe/Xosjkk2QmiZU 8ryyBpvt8iNhB254uJeBq90QEsX8cWGXS8YcWBMjUH2iWu/2UItIYU0qDGVKCdEObZo4 426WHxKm1HRvHqkWld/rVUJ4k43SvcEkPjifb6JeKZUzRmifV18ZJYgQTfQGC59Ewh/f 5kQQWOMynPpZOME2jygah+5n4SJ8rRBuRMf96P3q4s38/eob6pzdWzH4I1pbPxun86su PylozFcPJ87NWL7Stzbx/8tmSSJCD2qL49xvM7G77NOhRLt4UQEq8HqsPW0LUKlFLn/a v8tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=iCYug2uN0yJ0h5qzrzM0t/ZXG7y0pW69zdo3//wJ5Mc=; b=uWVapzcE+i70nB18WtWcbc8BMtQW5mvmK++WYVzb8g1s4pzOPloitewinFBI5QOCf5 S/EZHsSb+DG337+TEK8xFf/VLwgYIz3zfz1yvFnpMIEK6d0RxjaVdKHRJz4m2c/lQi6Q R1pnqt5hCBIEXE8ag45sC8/yF4nLVKnGhh5E4cuyFzTA1O4VFp8mI8Mah8sFySm0DjN4 Ttnu9UWj/hLmuFrhMpNITBezxCiL0kuzVV5koToK9uBj3364FRUNJiFED6O+bc+pjkch nsBZ/wEW3GQXSfESsxzVsUHScoSSSSpCCBI3b8H88tIYxx6DdLPA4yQv5UnF061OT+IJ GzmA== X-Gm-Message-State: AOAM532BKACe4TO/ZCfL9eUTEiISj38w+mfxZiYeJEXo23h3G0K6ed+2 bdhmqDcZZp3AEGM8cGo0gG0z9w== X-Google-Smtp-Source: ABdhPJxNOwK0M2yG7dyNvpA4W4t769Dz57u4tDUZ5Yawlwr+ZqoHjyWnaBVu9T+EYcXrNna7M8ECuA== X-Received: by 2002:a05:600c:211a:b0:380:d7b5:6e3a with SMTP id u26-20020a05600c211a00b00380d7b56e3amr2732823wml.125.1645795839794; Fri, 25 Feb 2022 05:30:39 -0800 (PST) Received: from [192.168.86.34] (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.googlemail.com with ESMTPSA id a8-20020a056000100800b001e30ef6f9basm3305843wrx.18.2022.02.25.05.30.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Feb 2022 05:30:39 -0800 (PST) Message-ID: <852e35f6-ec8b-ddc6-f81f-f666e899b543@linaro.org> Date: Fri, 25 Feb 2022 13:30:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH V3 2/3] dt-bindings: nvmem: brcm,nvram: add basic NVMEM cells Content-Language: en-US To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Rob Herring Cc: Krzysztof Kozlowski , Florian Fainelli , Hauke Mehrtens , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= References: <20220124160300.25131-1-zajec5@gmail.com> <20220218070729.3256-1-zajec5@gmail.com> <20220218070729.3256-3-zajec5@gmail.com> From: Srinivas Kandagatla In-Reply-To: <20220218070729.3256-3-zajec5@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/02/2022 07:07, Rafał Miłecki wrote: > From: Rafał Miłecki > > NVRAM doesn't have cells at hardcoded addresses. They are stored in > internal struct (custom & dynamic format). It's still important to > define relevant cells in DT so NVMEM consumers can reference them. > > Update binding to allow including basic cells as NVMEM device subnodes. > > Signed-off-by: Rafał Miłecki Applied thanks, --srini > --- > V2: Add children nodes description per Rob's request > V3: Document NVMEM cells as properties > --- > .../devicetree/bindings/nvmem/brcm,nvram.yaml | 25 +++++++++++++++++-- > 1 file changed, 23 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > index 8c3f0cd22821..25033de3ef6b 100644 > --- a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > +++ b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > @@ -14,6 +14,8 @@ description: | > NVRAM can be accessed on Broadcom BCM47xx MIPS and Northstar ARM Cortex-A9 > devices usiong I/O mapped memory. > > + NVRAM variables can be defined as NVMEM device subnodes. > + > maintainers: > - Rafał Miłecki > > @@ -27,11 +29,30 @@ properties: > reg: > maxItems: 1 > > + board_id: > + type: object > + description: Board identification name > + > + et0macaddr: > + type: object > + description: First Ethernet interface's MAC address > + > + et1macaddr: > + type: object > + description: Second Ethernet interface's MAC address > + > + et2macaddr: > + type: object > + description: Third Ethernet interface's MAC address > + > unevaluatedProperties: false > > examples: > - | > nvram@1eff0000 { > - compatible = "brcm,nvram"; > - reg = <0x1eff0000 0x10000>; > + compatible = "brcm,nvram"; > + reg = <0x1eff0000 0x10000>; > + > + mac: et0macaddr { > + }; > }; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FA3CC433EF for ; Fri, 25 Feb 2022 13:32:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AYlSVNEGWiB3AJcKp0S/mcuMgdqrAZxth9f/XrIixPI=; b=KDzP+KGCkvkGMT xL2g7fs9G6ohwTd2WwuFOFLX+4eJ8Jxh57aGll5s/NWCxghKeayXIBN0GpcknP0eU+6wvZh9Yv4kY roQ9LSIRECzSHTZXEJ0yOXCGrE9KiMpJRzr15U7NZjIRDC7x3eBWMTaDhjXcn/xfeVeBBJJexSdgL tjj5wSD4Hu/rEG3WYPteqYNM3UCNVUd4C3tvt2pTeuWnBpi0XPtWDfkFLMhSvA8Edhe/ML9kXhY6/ FWzkF2lxFioLJHdWhM0THllaPoFybt54YgNp4PLf31tmichhsQ+cQYzTg51IlVWwPZEq2HJ1vLAyL ZlmC/5HykGKTK1r2BrfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNagb-0057B6-Gy; Fri, 25 Feb 2022 13:31:05 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNagD-005735-Sb for linux-arm-kernel@lists.infradead.org; Fri, 25 Feb 2022 13:30:44 +0000 Received: by mail-wm1-x32b.google.com with SMTP id v2-20020a7bcb42000000b0037b9d960079so1722425wmj.0 for ; Fri, 25 Feb 2022 05:30:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=iCYug2uN0yJ0h5qzrzM0t/ZXG7y0pW69zdo3//wJ5Mc=; b=Iz/C4kfIg+QU3WpdVAdERt4dHyjlNNmL0wic5dOiAa2/KqYsxtSwe/Xosjkk2QmiZU 8ryyBpvt8iNhB254uJeBq90QEsX8cWGXS8YcWBMjUH2iWu/2UItIYU0qDGVKCdEObZo4 426WHxKm1HRvHqkWld/rVUJ4k43SvcEkPjifb6JeKZUzRmifV18ZJYgQTfQGC59Ewh/f 5kQQWOMynPpZOME2jygah+5n4SJ8rRBuRMf96P3q4s38/eob6pzdWzH4I1pbPxun86su PylozFcPJ87NWL7Stzbx/8tmSSJCD2qL49xvM7G77NOhRLt4UQEq8HqsPW0LUKlFLn/a v8tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=iCYug2uN0yJ0h5qzrzM0t/ZXG7y0pW69zdo3//wJ5Mc=; b=EFCcnH11x9cS/JuCQKhtts0oG9gwQhHoVwll7cquQpw7h6kG5og7Il5dz8UDnSWyoX pIlh7O8O5bgTO9vnYovEzwBrq98qi1wheA5NBjk186J3sNdDfcbV8y+5wCYdXj1R1Ib2 gvh3IHdyHToxNZ9RjbRPEhXSauPKxt0kl42/EzkpfmhGfLd0lU/xKrvxKG2oEaYUalvN 3OQGs2pZVEpKTDFVsDOxNRcCfAvwQlAkY3dxnuqJ33WIIDRIbTHq3cJ7eLU4k4wluhwj 29qp8/0ABXj9s804tdtZSuZPmo6tMQOVjPNA/yPbp5ZMU4aEDxlI2RUFB8PP2bHRfQXH mDFA== X-Gm-Message-State: AOAM533mQoKlmUEpg35MF5wuDd+/z5p+2ms5yO8A3o3ds3tFPy/hJ+6d gAjS5r28am+Usq764WtU/oV8EQ== X-Google-Smtp-Source: ABdhPJxNOwK0M2yG7dyNvpA4W4t769Dz57u4tDUZ5Yawlwr+ZqoHjyWnaBVu9T+EYcXrNna7M8ECuA== X-Received: by 2002:a05:600c:211a:b0:380:d7b5:6e3a with SMTP id u26-20020a05600c211a00b00380d7b56e3amr2732823wml.125.1645795839794; Fri, 25 Feb 2022 05:30:39 -0800 (PST) Received: from [192.168.86.34] (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.googlemail.com with ESMTPSA id a8-20020a056000100800b001e30ef6f9basm3305843wrx.18.2022.02.25.05.30.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Feb 2022 05:30:39 -0800 (PST) Message-ID: <852e35f6-ec8b-ddc6-f81f-f666e899b543@linaro.org> Date: Fri, 25 Feb 2022 13:30:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH V3 2/3] dt-bindings: nvmem: brcm,nvram: add basic NVMEM cells Content-Language: en-US To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Rob Herring Cc: Krzysztof Kozlowski , Florian Fainelli , Hauke Mehrtens , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= References: <20220124160300.25131-1-zajec5@gmail.com> <20220218070729.3256-1-zajec5@gmail.com> <20220218070729.3256-3-zajec5@gmail.com> From: Srinivas Kandagatla In-Reply-To: <20220218070729.3256-3-zajec5@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220225_053041_996952_C637AF21 X-CRM114-Status: GOOD ( 18.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAxOC8wMi8yMDIyIDA3OjA3LCBSYWZhxYIgTWnFgmVja2kgd3JvdGU6Cj4gRnJvbTogUmFm YcWCIE1pxYJlY2tpIDxyYWZhbEBtaWxlY2tpLnBsPgo+IAo+IE5WUkFNIGRvZXNuJ3QgaGF2ZSBj ZWxscyBhdCBoYXJkY29kZWQgYWRkcmVzc2VzLiBUaGV5IGFyZSBzdG9yZWQgaW4KPiBpbnRlcm5h bCBzdHJ1Y3QgKGN1c3RvbSAmIGR5bmFtaWMgZm9ybWF0KS4gSXQncyBzdGlsbCBpbXBvcnRhbnQg dG8KPiBkZWZpbmUgcmVsZXZhbnQgY2VsbHMgaW4gRFQgc28gTlZNRU0gY29uc3VtZXJzIGNhbiBy ZWZlcmVuY2UgdGhlbS4KPiAKPiBVcGRhdGUgYmluZGluZyB0byBhbGxvdyBpbmNsdWRpbmcgYmFz aWMgY2VsbHMgYXMgTlZNRU0gZGV2aWNlIHN1Ym5vZGVzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFJh ZmHFgiBNacWCZWNraSA8cmFmYWxAbWlsZWNraS5wbD4KCkFwcGxpZWQgdGhhbmtzLAoKLS1zcmlu aQoKPiAtLS0KPiBWMjogQWRkIGNoaWxkcmVuIG5vZGVzIGRlc2NyaXB0aW9uIHBlciBSb2IncyBy ZXF1ZXN0Cj4gVjM6IERvY3VtZW50IE5WTUVNIGNlbGxzIGFzIHByb3BlcnRpZXMKPiAtLS0KPiAg IC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL252bWVtL2JyY20sbnZyYW0ueWFtbCB8IDI1ICsrKysr KysrKysrKysrKysrLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCAyIGRl bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvbnZtZW0vYnJjbSxudnJhbS55YW1sIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL252bWVtL2JyY20sbnZyYW0ueWFtbAo+IGluZGV4IDhjM2YwY2QyMjgyMS4uMjUwMzNk ZTNlZjZiIDEwMDY0NAo+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9u dm1lbS9icmNtLG52cmFtLnlhbWwKPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvbnZtZW0vYnJjbSxudnJhbS55YW1sCj4gQEAgLTE0LDYgKzE0LDggQEAgZGVzY3JpcHRp b246IHwKPiAgICAgTlZSQU0gY2FuIGJlIGFjY2Vzc2VkIG9uIEJyb2FkY29tIEJDTTQ3eHggTUlQ UyBhbmQgTm9ydGhzdGFyIEFSTSBDb3J0ZXgtQTkKPiAgICAgZGV2aWNlcyB1c2lvbmcgSS9PIG1h cHBlZCBtZW1vcnkuCj4gICAKPiArICBOVlJBTSB2YXJpYWJsZXMgY2FuIGJlIGRlZmluZWQgYXMg TlZNRU0gZGV2aWNlIHN1Ym5vZGVzLgo+ICsKPiAgIG1haW50YWluZXJzOgo+ICAgICAtIFJhZmHF giBNacWCZWNraSA8cmFmYWxAbWlsZWNraS5wbD4KPiAgIAo+IEBAIC0yNywxMSArMjksMzAgQEAg cHJvcGVydGllczoKPiAgICAgcmVnOgo+ICAgICAgIG1heEl0ZW1zOiAxCj4gICAKPiArICBib2Fy ZF9pZDoKPiArICAgIHR5cGU6IG9iamVjdAo+ICsgICAgZGVzY3JpcHRpb246IEJvYXJkIGlkZW50 aWZpY2F0aW9uIG5hbWUKPiArCj4gKyAgZXQwbWFjYWRkcjoKPiArICAgIHR5cGU6IG9iamVjdAo+ ICsgICAgZGVzY3JpcHRpb246IEZpcnN0IEV0aGVybmV0IGludGVyZmFjZSdzIE1BQyBhZGRyZXNz Cj4gKwo+ICsgIGV0MW1hY2FkZHI6Cj4gKyAgICB0eXBlOiBvYmplY3QKPiArICAgIGRlc2NyaXB0 aW9uOiBTZWNvbmQgRXRoZXJuZXQgaW50ZXJmYWNlJ3MgTUFDIGFkZHJlc3MKPiArCj4gKyAgZXQy bWFjYWRkcjoKPiArICAgIHR5cGU6IG9iamVjdAo+ICsgICAgZGVzY3JpcHRpb246IFRoaXJkIEV0 aGVybmV0IGludGVyZmFjZSdzIE1BQyBhZGRyZXNzCj4gKwo+ICAgdW5ldmFsdWF0ZWRQcm9wZXJ0 aWVzOiBmYWxzZQo+ICAgCj4gICBleGFtcGxlczoKPiAgICAgLSB8Cj4gICAgICAgbnZyYW1AMWVm ZjAwMDAgewo+IC0gICAgICAgICAgICBjb21wYXRpYmxlID0gImJyY20sbnZyYW0iOwo+IC0gICAg ICAgICAgICByZWcgPSA8MHgxZWZmMDAwMCAweDEwMDAwPjsKPiArICAgICAgICBjb21wYXRpYmxl ID0gImJyY20sbnZyYW0iOwo+ICsgICAgICAgIHJlZyA9IDwweDFlZmYwMDAwIDB4MTAwMDA+Owo+ ICsKPiArICAgICAgICBtYWM6IGV0MG1hY2FkZHIgewo+ICsgICAgICAgIH07Cj4gICAgICAgfTsK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFy bS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1r ZXJuZWwK