Hi Andrew!

On 11/10/22 01:13, Andrew Clayton wrote:
> While looking at which systems provide memmem(3) I have been able to
> discern the following:
> 
>    musl libc since v0.9.7
>    bionic since Android 9
> 
>    FreeBSD since 6.0
>    OpenBSD since 5.4
>    NetBSD
>    macOS
>    Illumos

Although for the page itself I wouldn't add the dates, I think it's useful to 
include the years of those releases in the commit message (when known).

musl 0.9.7 is from 2012.
FreeBSD 6 is from 2005.
OpenBSD 5.4 is from 2013.

Please include that, if you don't mind.

> 
> For macOS and Illumos I checked the memmem(3) man page on those systems.
> For the rest there are links below to on-line man pages or commit logs.
> 
> Where I could determine what version memmem(3) was introduced, I've
> noted that in the man page.
> 
> Link: <http://git.musl-libc.org/cgit/musl/commit/src/string/memmem.c?id=c86f2974e2acd330be2d587173dd4dd56db82e22>
> Link: <https://android.googlesource.com/platform/bionic/+/android-9.0.0_r3/libc/bionic/memmem.cpp>
> Link: <https://www.freebsd.org/cgi/man.cgi?query=memmem&sektion=3&format=html>
> Link: <https://man.openbsd.org/memmem.3>
> Link: <https://anonhg.netbsd.org/src/diff/96a37d536271/common/lib/libc/string/memmem.c>
> Suggested-by: Alejandro Colomar <alx@kernel.org>
> Signed-off-by: Andrew Clayton <andrew@digital-domain.net>
> ---
>   man3/memmem.3 | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/man3/memmem.3 b/man3/memmem.3
> index 134dffab0..1f58ffffd 100644
> --- a/man3/memmem.3
> +++ b/man3/memmem.3
> @@ -58,7 +58,9 @@ T}	Thread safety	MT-Safe
>   .sp 1
>   .SH STANDARDS
>   This function is not specified in POSIX.1,
> -but is present on a number of other systems.
> +but is present on a number of other systems,
> +including: musl libc 0.9.7 & bionic Android 9;

I prefer 'and' rather than '&'.

> +FreeBSD 6.0, OpenBSD 5.4, NetBSD, macOS & Illumos.

Also, we use Oxford commas in the project, which means having a comma before the 
'and' if there are at least 3 items in the list.

For the commit message, it's interesting to note macOS and Bionic, for 
speleology purposes.  However, I'm opposed to adding them to the page itself 
because of the following:

-  macOS is not free software.  I refuse to reference nonfree software on this 
project.
-  Android is not a real Unix system, in that you can't even program in C in 
there, unless you're Google or have hacked your system.  It's not friendly to us 
programmers, so we don't need to be friendly to it.  I don't want to be 
cluttering the pages with information that is irrelevant to normal users.

Thank you for the patch!

Cheers,

Alex

>   .SH BUGS
>   .\" This function was broken in Linux libraries up to and including libc 5.0.9;
>   .\" there the

-- 
<http://www.alejandro-colomar.es/>