From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752156AbeA0Ihf (ORCPT ); Sat, 27 Jan 2018 03:37:35 -0500 Received: from mail-eopbgr20138.outbound.protection.outlook.com ([40.107.2.138]:37856 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751849AbeA0Ihd (ORCPT ); Sat, 27 Jan 2018 03:37:33 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peda@axentia.se; Subject: Re: [RFC PATCH 0/2] check I2C device id for pca984x chips To: Adrian Fiergolski Cc: Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180122113657.32094-1-peda@axentia.se> <04535e9d-9ba4-2f27-e94c-12d877d26cda@cern.ch> From: Peter Rosin Organization: Axentia Technologies AB Message-ID: <8549b310-ecfe-e60b-c7fc-fab7db2fd2f2@axentia.se> Date: Sat, 27 Jan 2018 09:37:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <04535e9d-9ba4-2f27-e94c-12d877d26cda@cern.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [85.226.244.23] X-ClientProxiedBy: HE1PR0502CA0022.eurprd05.prod.outlook.com (2603:10a6:3:e3::32) To AM4PR0202MB2772.eurprd02.prod.outlook.com (2603:10a6:200:8c::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: da67d001-952d-4553-821e-08d5656133c6 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(7021125)(4534165)(7022125)(4603075)(4627221)(201702281549075)(7048125)(7024125)(7027125)(7028125)(7023125)(5600026)(4604075)(2017052603307)(7153060)(7193020);SRVR:AM4PR0202MB2772; X-Microsoft-Exchange-Diagnostics: 1;AM4PR0202MB2772;3:WNdCOx5nRd+ZPHCnb0X/tVE29OeDq2eoX9OW2lVNTJgWPUlHLqyFYm5MOoFzug+DfG9bucqq2CbBu+EbnYeSFrhuZKzWdTj21sV+Bt41aX1e67bTyH09+hCDMYmFvvcrF5kcIki+KF39FYElcqzuqPebh33QGZpqEdcfMdyd6jhsuEGeHl33soxn7O73rcWh8uFcpPHquwuXcIXGMYzMswobLLJZfOzDKojE02g4+iz2qXv2d+32hSzVlXFyQNy1;25:4R+YP9J//yY3hkUsKwh4Y5PrSPoiwos0SitfrXr2cZV4tR3901hAqkv2p3DfsSgDmrtcJZF9k8I9PlW+GwmS70QP1lLenCdl8TJtHFlfhGIJtqqe4ITFlXFkF1ar6rDJHDMDCFIOy26ppPB7md8vuw+S1KAZ79OOtlDG4DsoV/M7ygCPQ4zB5KBe1P2tsLqrPoWqMXtzx/jfb1Gi89cUXveDZ20JkEtQt2obsKbCQXi+bHICSZn/QfL7/iDekDvtf0lTZAfLpR93NZCW0MiXHnkrEX+3glxINIQBXpePcXCsOSwGvKSQC5Rqq2gWBGHmPe6tbzLlJecf2BIK1mAlNQ==;31:9LpXSFyfBcOIC+R04OJG/FwiwS7s/nAQ6GAdCa2qnTU7RP86oNgtkugYUAjdY0jAylZSgsKphH7EoZHPLBMH2P92KZl5kbjaX5XQXbdb+HWOXz5hPQ0mixTPd8WG7lwjGnVQgjcHnrxJmy+2U9Kg2UKovwyOhCmmexnFgm/q2TP7Ul6hSr8gf8Vl/UzA4eXcdZa1kBsxLdK76EVqRLuZor/OtGyLMWr+90IM9HtGLQg= X-MS-TrafficTypeDiagnostic: AM4PR0202MB2772: X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(166708455590820); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(8121501046)(5005006)(3231084)(2400081)(944501161)(93006095)(93001095)(10201501046)(3002001)(6041288)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(2016111802025)(6072148)(6043046)(201708071742011);SRVR:AM4PR0202MB2772;BCL:0;PCL:0;RULEID:;SRVR:AM4PR0202MB2772; X-Microsoft-Exchange-Diagnostics: 1;AM4PR0202MB2772;4:rOLeCd3+86AyLPNk39Ah/cx1uwJELrZ4b2w4Gwn0JLu09LM+Z3sIF4F0JqXbXfGKjBrmGPlk8zI0/nzdQHXOKz8uYxX/yd6EzEaAaAXwaWVg8E5HCSzFZbV81moNcLcTgpikv54SlzsKWrTP9kPNegPflnAL+LJnePHwviRF8WXOMtyhwDWVxxgpaHZhHcchBszrESTA0s/DLGZnLjbZaNA2LtbVuiMcJYxZqAn+2MnGawTo4/Jt+o30NbBSNiPieTYW6b5RJPwUl06++NrNpRUUwbR90AfMkMPJR1sEqzFEhNCQktWrO/nnX/YQwKRS X-Forefront-PRVS: 056544FBEE X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6049001)(396003)(346002)(39380400002)(39830400003)(366004)(376002)(189003)(199004)(377424004)(16576012)(31696002)(316002)(50466002)(31686004)(230700001)(68736007)(81166006)(81156014)(8676002)(64126003)(36756003)(2906002)(117156002)(74482002)(16526019)(186003)(478600001)(58126008)(25786009)(4326008)(3846002)(6116002)(77096007)(966005)(3260700006)(26005)(83506002)(52116002)(7736002)(53546011)(305945005)(105586002)(76176011)(23676004)(6246003)(2486003)(59450400001)(86362001)(47776003)(66066001)(106356001)(65806001)(65956001)(5660300001)(6306002)(36916002)(6486002)(97736004)(6916009)(8936002)(6666003)(52146003)(386003)(65826007)(229853002)(53936002)(2950100002)(217873001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:AM4PR0202MB2772;H:[192.168.13.3];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTRQUjAyMDJNQjI3NzI7MjM6YThsbzVFcVllQ2J5QkVaZlAwSDJuTTV5?= =?utf-8?B?N1g3SkVGNWF1Zmo5d1QrQ0U2ekJTZDdXQzZ4Ykc4akN4clgrNjhldTBNelZ2?= =?utf-8?B?ZGluVXZYdlZFUDBvYlNRaEoralY1YUs0N1dRTWNpa0VtcHQraWZTRi9yWFMz?= =?utf-8?B?bHMxaTB3b0U0WEJOQ0xoSlpuRmRPVHIxVlZkSkhVYm8ybHVxL2pvZVFuV3BC?= =?utf-8?B?dm1BRG5DbitFdUMwZXRROVJFT0dNZjF1TEYzOEUxbGh5eFdsTm9hUGtCdmVC?= =?utf-8?B?QWVoYzVRMnU1bjVueWdxVVFTQWFmdE4rbXZ0ckVwdWh0N21zR3NHWW9PWi94?= =?utf-8?B?NzBsaEIzcy92cjhaY1RsT3E1WktJc2NNdmRIbkdrYU93M3B4eVZ3YmFYdWVQ?= =?utf-8?B?bE50eVJId05Vbk1HVlZZTFBPeWxaN0pMMHA5ZDFibC92bmxDNjhHTVJCV3lu?= =?utf-8?B?eGV0dGNVMU9tK1J5NnBIK2pwTXFpcVNJOVNTbDhiNGorblNHbXNISmdKbVlH?= =?utf-8?B?ZStuaGo3UEtYRHEzMkxoRVNXOWVvTnA0OEtSd1kySVA3Y21KTGFFTU4zbWs5?= =?utf-8?B?YWI2MmFqVUxRNmJ6cUZWWWZJSzFVQThmTDRzb2RLeXpISHFaSW9RN2Fjdm9R?= =?utf-8?B?S2ZrNHliellsSG8xUjh0Z3B6WUtVcE9WdU9KSGdNR1VLc21NeWlRQlZ1TTJK?= =?utf-8?B?S3JXNnFhSlhDSTJaOURuNi9WMk9ORUZhait6eU9RSlNnbXhIdVQ2WGZmOEhC?= =?utf-8?B?SFdGU3ZhNU42QlNNY0VGKzg1UXZLeEJLa0EyNllkdEZCUUFvcDFkYnhTM2N5?= =?utf-8?B?OGFpaDV6L094V2wzNDdxb1VWWlZvNVF1V1dsb1hoeTF2NW9nM3RINWpFSDFY?= =?utf-8?B?bHVra0FVMGxjYlJRYUozNGs1ZXYyOXZGRnVSbHRROHB0VW5wQk02SEFuQm1p?= =?utf-8?B?a2xDNzE0TW51ZU1oc0xDdWNiUVJ6dGxOOW9SdlBOa1UwdkVuODZiZkhFbFp5?= =?utf-8?B?MTkwUFloVnUxclFaQXJBUXhBOHhQZGR5Z0gyRGtGcFNBU01qc0ljTXpnVzQ1?= =?utf-8?B?Y2RGTTQyWUpyRzFBRmN3WFhiUmR4YXJCY2FJQU9BTms0OTEra2lycHd1dk1n?= =?utf-8?B?NVdkdGlkVGtxby9MbTZXTnYya0Q2MVIzYXpkNFVCR1B3bjNGQ3orWHp6VjM2?= =?utf-8?B?enFNN3dIWmhkb2dzdyt1cWNpRnNRWHErV0VXZ0tYcER0MUw5dlpETlRDbGVT?= =?utf-8?B?WVFGaERUUXhpNi9Qc3M1WW11K2phZ2FoR3o2dmVqNE1XeGdobVNYZjFEY2Iv?= =?utf-8?B?b04zN21RL0NRRUZIY3FXYkpoYjNjUEZPU2NoOS90SkJlbzhWWlpZSExESzMz?= =?utf-8?B?bXhuNUV4eEE2SDVWN0FDeUx6YW4wQWVPcFNmYXZVdXRvNEFvNVZqY2RzbnBj?= =?utf-8?B?UlpaR3BDTzhOeWtJWHlBdG11ZjRuanNqMk90Qkl4ZmFIUWxPM1RzU2FGdEVN?= =?utf-8?B?WENWODlBM2tYRGs3d2VSSmpHOUVMSUc1R1lXSHFqVExOQ3FPWndnZTl2N21R?= =?utf-8?B?a09KTmpaRVNmclJvOVA1OVJJVWhneGNlZW5QTm0xaE05SlUxemd4SW1LTWlo?= =?utf-8?B?UUxDZ0FqZ25yRmxrcDJnVnoyaXFKRlN2TGgwczg0bW56TTVoNlJjSklScGdQ?= =?utf-8?B?cDNmM1AwSHVlcFVwRCs2c0c5V0picVpzSXgzN2ViTjZ5aTQzV0xqcktmQm9h?= =?utf-8?B?Q2FlNlpxcGtzYklqOFhlZzRtb05VYmdoNWhvc25iNmlia1dsZ3F4NExxV1Zk?= =?utf-8?B?b0xCNWVUMnBSZ21iSXJhVTdoUEhMczI2VXdwY2h5VjZxSlhwM3IrTTZEZXpE?= =?utf-8?B?bUYyNkZ6NC9yeTNUcmUzcmRZbFRDNVBabHB0SEM2UVNIaEREM09zaXNkVCtp?= =?utf-8?B?bTNDRmk3MXh5YXd6L1J0M2VCUU0wMWtTalJ0Q2w1WlVobEJiN0k3ZTUwL09j?= =?utf-8?B?OVRWaXMveHpwUVpCcVlLUVRRMUVVckVVYWpGeHovTEhxcEtmMFA4NDEraHg5?= =?utf-8?B?UmxBVmVUd1JLTmI0RUdnSlFCQjZUQnlzUlpwbnoyVXRndmZWZjBtUXpmbUVD?= =?utf-8?Q?wJ1DtBXwcIIXvKgpibnPdrLso=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM4PR0202MB2772;6:Y6aRjWYVlEuS65p+aV7Y0cFf+bxyaXEsUPYFxYU3LpDI2+zh1VKZRENP/Q2iLbWgtA84GbSg/XPeWys+AVhayBLTg1/jsWImgr43U4byWf8OfwYaqrSDMbzX253RpsjCJc3XQk3aLy+Vm+5vdFvahGmvM9t26HfRXFbiT9tjL7O/JcAJlc5LWOTptq5K4PMjlyBxkKZvZP2cKy7ZyZh+mVMg3dRnav+nfQgD6z3bIMhRAZZcqGXuRGSRcedheXC1zSFGYC7Dsg1IZplxHOfLHqU/ZgzJ0cs73hQhx8SSuRHkf5F9eTA4Dvdvm7Z4cVbHUHcuyD2fAR2x3kYUwF5rbdVB+eZQPBBekvpByPhsuj4=;5:tfIvVt0y+oYs2yCVBAosL6AwOr8CtxKOMJ/25jPp1YSbyewsGldiRDTEv7Csjp2mn4K4+niAkwbAAsnZHtnmvljesvA4HObOT2PhyD8F7h2hbcRZ93jK7OMMz+lz/+KXIkEpILM84hHPIGnYLc4sFttXw5NVFmDAiJUAbZP+RIM=;24:VQ2+5+pgA6qUwEHTg3MSzKz3xSRMWhJ7xbqSRIZ5ftQB+mmhdTvTwFOsaj/sNtYjh9McdQk1aVNIEbloqk3IvQi+8Qc2IdGiWTTdxk2jDVY=;7:JQn8b51hiHOniOGhrENPtEXu1K98YsdAUST4dCPVjGDnDRh4wTlXzzsJyFVj8erypEtrM3bFEBlbT3D/bxokGnoG9Gj2H7Y5qrN3Ajz4lxLAU88LoB8sNYSLUushso+IJTlRCunc7m3XuIN8JX/bsC89BRNt4BkjsRXwLBa8kMsFdgZGSNgthpqsnm0dc4gvNZHkHT6uinX1iInFHDtDIXmULjtxT9nk95xOQV24yhH1pOX30cZxx9eVMTAQ1g84 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2018 08:37:29.4392 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: da67d001-952d-4553-821e-08d5656133c6 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0202MB2772 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-01-26 17:33, Adrian Fiergolski wrote: > Hi Peter, > > Sorry for the late reply. No problem. > Yes, it's true I have one of the chip. However, my yocto based build system > depends on https://github.com/Xilinx/linux-xlnx and it's in version > 4.9.0-xilinx-v2017.3. > Apparently, there were some bigger changes in i2c core between this > version and > upstream, thus your patches don't apply. I think the core changes fail to apply mostly because of the file renaming that has been going on, and that it should be fairly trivial to adapt. But I don't know for certain... > Next week I will try to align only me i2c subdirectory with upstream. > Provided it compiles, I will > try then to apply and confirm your patches. I'm looking forward to feedback, thanks! Cheers, Peter > Regards, > Adrian > > On 22.01.2018 at 12:36, Peter Rosin wrote: >> Hi! >> >> This series tries to check the I2C device id, but instead of open >> coding the check in the pca954x driver, I have a new function in >> the core doing the work. >> >> The code is only compile-tested, hence the RFC, and I would really >> like a Tested-by: tag from Adrian who presumably have one of these >> chips. >> >> Also, I'm not sure if I should list all manufacturers that I know >> about in the header, or if I should settle for the one that is >> actually used and leave the others to be added by whomever needs >> them... >> >> Cheers, >> peda >> >> Peter Rosin (2): >> i2c: add i2c_get_device_id() to get the standard i2c device id >> i2c: mux: pca954x: verify the device id of the pca984x chips >> >> drivers/i2c/i2c-core-base.c | 33 ++++++++++++++++++++++++++++ >> drivers/i2c/muxes/i2c-mux-pca954x.c | 43 +++++++++++++++++++++++++++++++++++++ >> include/linux/i2c.h | 30 ++++++++++++++++++++++++++ >> 3 files changed, 106 insertions(+) >> >