From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30D69C433EF for ; Fri, 17 Jun 2022 08:44:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381267AbiFQIon (ORCPT ); Fri, 17 Jun 2022 04:44:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1381272AbiFQIoh (ORCPT ); Fri, 17 Jun 2022 04:44:37 -0400 X-Greylist: delayed 491 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 17 Jun 2022 01:44:31 PDT Received: from uho.ysoft.cz (uho.ysoft.cz [81.19.3.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 528916970C; Fri, 17 Jun 2022 01:44:31 -0700 (PDT) Received: from [10.1.8.252] (unknown [10.1.8.252]) by uho.ysoft.cz (Postfix) with ESMTP id 3431AA02A1; Fri, 17 Jun 2022 10:36:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ysoft.com; s=20160406-ysoft-com; t=1655454977; bh=P9SsROK1piUBycTfz5CAL2bjuDVk9jOnqysDli5yILI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=NKd47B8Nb5QPetXhvZ9t/FDQLHL72xPSR1aeGo2k8dc0d/sDRW6aj9Fts1APj0bU+ a+0vfE0YsOmN25NoL7SUzd5xKrqSq3QWrVnWwJ0esR/fZm+WoDYq1tRHiX3zlYlDLt o2r1/WmPHiCUxEOIsPVoNukf8V3wJXNFqPAW7PUk= Message-ID: <854d5705-93a3-18f2-a16d-b2245cf2c085@ysoft.com> Date: Fri, 17 Jun 2022 10:36:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [RESEND PATCH v2 0/9] imx: thermal: Allow trip point configuration from DT Content-Language: en-US To: Francesco Dolcini , Jacky Bai Cc: Daniel Lezcano , Rob Herring , "Rafael J. Wysocki" , Krzysztof Kozlowski , Shawn Guo , Marco Felsch , Anson Huang , Amit Kucheria , Zhang Rui , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" , Pengutronix Kernel Team , Sascha Hauer , Fabio Estevam , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" References: <20220617071411.187542-1-francesco.dolcini@toradex.com> <20220617074220.GA187629@francesco-nb.int.toradex.com> <20220617075533.GA190158@francesco-nb.int.toradex.com> From: =?UTF-8?B?TWljaGFsIFZva8OhxI0=?= In-Reply-To: <20220617075533.GA190158@francesco-nb.int.toradex.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Francesco, On 17. 06. 22 9:55, Francesco Dolcini wrote: > On Fri, Jun 17, 2022 at 07:51:53AM +0000, Jacky Bai wrote: >>> On Fri, Jun 17, 2022 at 07:31:25AM +0000, Jacky Bai wrote: >>>>> Subject: [RESEND PATCH v2 0/9] imx: thermal: Allow trip point >>>>> configuration from DT >>>>> >>>>> This series allows to specify the imx thermal drivers trip point >>>>> from the device tree, without this change the threshold are >>>>> hard-coded and this might not be correct given the thermal design of the >>> final system. >>>>> >>>> >>>> The threshold is set dynamically based on the part market temp grade. >>>> I am little confused why need to specify it in DT? I saw in 'PATCH >>>> 5/9', you provide a threshold table based temp grade, why not use the >>>> threshold from ' imx_init_temp_grade'? >>> >>> The problem with the existing temperature thresholds is that they are >>> hard-coded into the driver, there is no way to change those to match the >>> actual final system thermal design. AFAIK you can change the trip point from user space if you build with THERMAL_WRITABLE_TRIPS so in fact you can adapt it to the final system design. We did exactly that when we swapped imx6 dual for imx6 quad but did not have enough space for adequate heat sink. I do not want to question usefulness of this series though, I agree with the idea. Michal From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 838EAC43334 for ; Fri, 17 Jun 2022 08:49:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qQqsrileUIcoTDhMSax4J93bg/m6KsPVIueeQiH0tLc=; b=d8BqZ9HQxXNaXn G4HUIBzayN7pCuN4MLXUbPqY+/uxlAJfUzMEHDf9YfmIvzus/blGIGVGO1sH4Q3HZyEty3dcekASj aVdXF+LvnTS1cINbOGGkASVGwDYW73ffHT8InHG5bf2gWkbwHqW895SBXUEf+JwO2i3C/vJ9GkjFB JVyCX3d/XGl3KrLyuP5rUV23C2kDR5A/yZMByww7Gy07I+iwuJDNw6NpVFF1yxg4f16OgYlxMmJeM P9lAQHVnBd4MeQE9q7X3l13O0Gnff7adZjnS51R0s23YQNJG0pMYl7iWdbr/GEXlQeYCLJwTxI6sx emd7UTU8aVwEpJa4EzEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o27e9-006S73-Am; Fri, 17 Jun 2022 08:48:05 +0000 Received: from uho.ysoft.cz ([81.19.3.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o27Sr-006MXi-P2 for linux-arm-kernel@lists.infradead.org; Fri, 17 Jun 2022 08:36:28 +0000 Received: from [10.1.8.252] (unknown [10.1.8.252]) by uho.ysoft.cz (Postfix) with ESMTP id 3431AA02A1; Fri, 17 Jun 2022 10:36:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ysoft.com; s=20160406-ysoft-com; t=1655454977; bh=P9SsROK1piUBycTfz5CAL2bjuDVk9jOnqysDli5yILI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=NKd47B8Nb5QPetXhvZ9t/FDQLHL72xPSR1aeGo2k8dc0d/sDRW6aj9Fts1APj0bU+ a+0vfE0YsOmN25NoL7SUzd5xKrqSq3QWrVnWwJ0esR/fZm+WoDYq1tRHiX3zlYlDLt o2r1/WmPHiCUxEOIsPVoNukf8V3wJXNFqPAW7PUk= Message-ID: <854d5705-93a3-18f2-a16d-b2245cf2c085@ysoft.com> Date: Fri, 17 Jun 2022 10:36:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [RESEND PATCH v2 0/9] imx: thermal: Allow trip point configuration from DT Content-Language: en-US To: Francesco Dolcini , Jacky Bai Cc: Daniel Lezcano , Rob Herring , "Rafael J. Wysocki" , Krzysztof Kozlowski , Shawn Guo , Marco Felsch , Anson Huang , Amit Kucheria , Zhang Rui , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" , Pengutronix Kernel Team , Sascha Hauer , Fabio Estevam , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" References: <20220617071411.187542-1-francesco.dolcini@toradex.com> <20220617074220.GA187629@francesco-nb.int.toradex.com> <20220617075533.GA190158@francesco-nb.int.toradex.com> From: =?UTF-8?B?TWljaGFsIFZva8OhxI0=?= In-Reply-To: <20220617075533.GA190158@francesco-nb.int.toradex.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220617_013626_365710_65BD3C5B X-CRM114-Status: GOOD ( 10.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Francesco, On 17. 06. 22 9:55, Francesco Dolcini wrote: > On Fri, Jun 17, 2022 at 07:51:53AM +0000, Jacky Bai wrote: >>> On Fri, Jun 17, 2022 at 07:31:25AM +0000, Jacky Bai wrote: >>>>> Subject: [RESEND PATCH v2 0/9] imx: thermal: Allow trip point >>>>> configuration from DT >>>>> >>>>> This series allows to specify the imx thermal drivers trip point >>>>> from the device tree, without this change the threshold are >>>>> hard-coded and this might not be correct given the thermal design of the >>> final system. >>>>> >>>> >>>> The threshold is set dynamically based on the part market temp grade. >>>> I am little confused why need to specify it in DT? I saw in 'PATCH >>>> 5/9', you provide a threshold table based temp grade, why not use the >>>> threshold from ' imx_init_temp_grade'? >>> >>> The problem with the existing temperature thresholds is that they are >>> hard-coded into the driver, there is no way to change those to match the >>> actual final system thermal design. AFAIK you can change the trip point from user space if you build with THERMAL_WRITABLE_TRIPS so in fact you can adapt it to the final system design. We did exactly that when we swapped imx6 dual for imx6 quad but did not have enough space for adequate heat sink. I do not want to question usefulness of this series though, I agree with the idea. Michal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel