From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EA2FECAAA1 for ; Thu, 15 Sep 2022 13:30:55 +0000 (UTC) Received: from localhost ([::1]:57652 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYoxC-0007tX-Gn for qemu-devel@archiver.kernel.org; Thu, 15 Sep 2022 09:30:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYjH2-00035I-Qa; Thu, 15 Sep 2022 03:27:00 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:5171) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYjGz-0004Tm-Jw; Thu, 15 Sep 2022 03:27:00 -0400 Received: from canpemm500009.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4MSpcQ28bvzBsKF; Thu, 15 Sep 2022 15:24:38 +0800 (CST) Received: from [10.67.102.169] (10.67.102.169) by canpemm500009.china.huawei.com (7.192.105.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 15 Sep 2022 15:26:41 +0800 CC: , , , , , , , , , , , Subject: Re: [PATCH v2 0/8] AArch64/HMAT support and tests To: Hesham Almatary , , References: <20220719094950.1049516-1-hesham.almatary@huawei.com> Message-ID: <854fc789-b0ba-c692-af4e-7acaf94eb25f@huawei.com> Date: Thu, 15 Sep 2022 15:26:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20220719094950.1049516-1-hesham.almatary@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.102.169] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500009.china.huawei.com (7.192.105.203) X-CFilter-Loop: Reflected Received-SPF: pass client-ip=45.249.212.189; envelope-from=yangyicong@huawei.com; helo=szxga03-in.huawei.com X-Spam_score_int: -57 X-Spam_score: -5.8 X-Spam_bar: ----- X-Spam_report: (-5.8 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-1.583, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 15 Sep 2022 09:22:10 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reply-to: Yicong Yang From: Yicong Yang via On 2022/7/19 17:49, Hesham Almatary wrote: > This patchset adds support for AArch64/HMAT including a test. > It relies on other two patch sets from: > > Brice Goglin: to support -numa without initiators on q35/x86. > https://lore.kernel.org/all/ed23accb-2c8b-90f4-a7a3-f81cc57bf678@inria.fr/ > Xiang Chen: to enable/support HMAT on AArch64. > https://lore.kernel.org/all/1643102134-15506-1-git-send-email-chenxiang66@hisilicon.com/ > > I further add a test with ACPI/HMAT tables that uses the two > patch sets. > Hi Hesham, I've used this feature locally for a period on aarch64 and it works fine. Also tested the qemu test added based on v7.1.0-rc4 and `make test` show: 108/130 qemu:qtest+qtest-aarch64 / qtest-aarch64/bios-tables-test OK 99.80s 7 subtests passed Wish to see this in mainline! Tested-by: Yicong Yang Thanks! > Changes from v1: > - Generate APIC and PPTT ACPI tables for AArch64/virt > - Avoid using legacy syntax in numa/bios tests > - Delete unchanged FACP tables > > Brice Goglin (4): > hmat acpi: Don't require initiator value in -numa > tests: acpi: add and whitelist *.hmat-noinitiator expected blobs > tests: acpi: q35: add test for hmat nodes without initiators > tests: acpi: q35: update expected blobs *.hmat-noinitiators expected > HMAT: > > Hesham Almatary (3): > tests: Add HMAT AArch64/virt empty table files > tests: acpi: aarch64/virt: add a test for hmat nodes with no initiators > tests: virt: Update expected *.acpihmatvirt tables > > Xiang Chen (1): > hw/arm/virt: Enable HMAT on arm virt machine > > hw/arm/Kconfig | 1 + > hw/arm/virt-acpi-build.c | 7 ++ > hw/core/machine.c | 4 +- > tests/data/acpi/q35/APIC.acpihmat-noinitiator | Bin 0 -> 144 bytes > tests/data/acpi/q35/DSDT.acpihmat-noinitiator | Bin 0 -> 8553 bytes > tests/data/acpi/q35/HMAT.acpihmat-noinitiator | Bin 0 -> 288 bytes > tests/data/acpi/q35/SRAT.acpihmat-noinitiator | Bin 0 -> 312 bytes > tests/data/acpi/virt/APIC.acpihmatvirt | Bin 0 -> 396 bytes > tests/data/acpi/virt/DSDT.acpihmatvirt | Bin 0 -> 5282 bytes > tests/data/acpi/virt/HMAT.acpihmatvirt | Bin 0 -> 288 bytes > tests/data/acpi/virt/PPTT.acpihmatvirt | Bin 0 -> 196 bytes > tests/data/acpi/virt/SRAT.acpihmatvirt | Bin 0 -> 240 bytes > tests/qtest/bios-tables-test.c | 109 ++++++++++++++++++ > 13 files changed, 118 insertions(+), 3 deletions(-) > create mode 100644 tests/data/acpi/q35/APIC.acpihmat-noinitiator > create mode 100644 tests/data/acpi/q35/DSDT.acpihmat-noinitiator > create mode 100644 tests/data/acpi/q35/HMAT.acpihmat-noinitiator > create mode 100644 tests/data/acpi/q35/SRAT.acpihmat-noinitiator > create mode 100644 tests/data/acpi/virt/APIC.acpihmatvirt > create mode 100644 tests/data/acpi/virt/DSDT.acpihmatvirt > create mode 100644 tests/data/acpi/virt/HMAT.acpihmatvirt > create mode 100644 tests/data/acpi/virt/PPTT.acpihmatvirt > create mode 100644 tests/data/acpi/virt/SRAT.acpihmatvirt >