From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] eal: add function to return number of detected sockets Date: Tue, 06 Feb 2018 10:47:13 +0100 Message-ID: <8555507.QN0AfJDokS@xps> References: <3cf7f9aa904a5ba53ba63d7c32539e8b78638939.1513946317.git.anatoly.burakov@intel.com> <4220934.KFJTx7yznj@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Burakov, Anatoly" Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id ED9481B173 for ; Tue, 6 Feb 2018 10:47:17 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/02/2018 10:28, Burakov, Anatoly: > On 05-Feb-18 10:45 PM, Thomas Monjalon wrote: > > 05/02/2018 18:39, Burakov, Anatoly: > >> On 05-Feb-18 4:37 PM, Anatoly Burakov wrote: > >>> During lcore scan, find maximum socket ID and store it. > >>> > >>> Signed-off-by: Anatoly Burakov > >>> --- > >>> > >>> Notes: > >>> v3: > >>> - Added ABI backwards compatibility > >>> > >>> v2: > >>> - checkpatch changes > >>> - check socket before deciding if the core is not to be used > >>> > >>> lib/librte_eal/common/eal_common_lcore.c | 37 +++++++++++++++++++++---------- > >>> lib/librte_eal/common/include/rte_eal.h | 25 +++++++++++++++++++++ > >>> lib/librte_eal/common/include/rte_lcore.h | 8 +++++++ > >>> lib/librte_eal/linuxapp/eal/eal.c | 27 +++++++++++++++++++++- > >>> lib/librte_eal/rte_eal_version.map | 9 +++++++- > >>> 5 files changed, 92 insertions(+), 14 deletions(-) > >>> > >> > >> This patch does not break ABI, but does it in a very ugly way. Is it > >> worth it? > > > > I think we agreed to not get this patch in 18.02. > > Did you change your mind? > > > > Sorry, how do i mark this patch as for 18.05? Is it a patch header? So your answer is "yes, it is for 18.05" :) Next time, you could add 18.05 near "PATCH v3", or say it in annotations.