All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 3/4] qmp: Allow setting -action parameters on the fly
Date: Tue, 8 Dec 2020 15:59:54 -0500	[thread overview]
Message-ID: <855b56c2-dd9e-287d-8794-ec68a19f0f8c@oracle.com> (raw)
In-Reply-To: <1aeb78a5-4ddc-348a-505a-6e9a20d1331d@redhat.com>



On 12/8/2020 2:58 PM, Paolo Bonzini wrote:
> On 08/12/20 20:57, Paolo Bonzini wrote:
>> On 08/12/20 20:14, Alejandro Jimenez wrote:
>>>   ##
>>> +# @reboot-set-action:
>>> +#
>>> +# Set reboot action
>>> +#
>>> +# Since: 6.0
>>> +##
>>> +{ 'command': 'reboot-set-action', 'data' : {'action': 
>>> 'RebootAction'} }
>>> +
>>> +##
>>> +# @shutdown-set-action:
>>> +#
>>> +# Set shutdown action
>>> +#
>>> +# Since: 6.0
>>> +##
>>> +{ 'command': 'shutdown-set-action', 'data' : {'action': 
>>> 'ShutdownAction'} }
>>> +
>>> +##
>>> +# @panic-set-action:
>>> +#
>>> +# Set panic action
>>> +#
>>> +# Since: 6.0
>>> +##
>>> +{ 'command': 'panic-set-action', 'data' : {'action': 'PanicAction'} }
>>> +
>>> +##
>>
>> What about a single action-set command with arguments reboot, 
>> shutdown and panic?
>
> (and watchdog, of course)?
Just to make sure I understand the request: an action-set QMP command 
would need to take two arguments: an event 
(reboot|shutdown|panic|watchdog), and a valid action for that event 
type, akin to what set_runstate_action() does. I'll work on it.

Alejandro
>
> Paolo



  reply	other threads:[~2020-12-08 22:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08 19:14 [PATCH 0/4] Add a new -action parameter Alejandro Jimenez
2020-12-08 19:14 ` [PATCH 1/4] vl: Add an -action option to respond to guest events Alejandro Jimenez
2020-12-08 19:14 ` [PATCH 2/4] vl: Add option to avoid stopping VM upon guest panic Alejandro Jimenez
2020-12-08 19:14 ` [PATCH 3/4] qmp: Allow setting -action parameters on the fly Alejandro Jimenez
2020-12-08 19:57   ` Paolo Bonzini
2020-12-08 19:58     ` Paolo Bonzini
2020-12-08 20:59       ` Alejandro Jimenez [this message]
2020-12-08 19:14 ` [PATCH 4/4] qtest/pvpanic: Test panic option that allows VM to continue Alejandro Jimenez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=855b56c2-dd9e-287d-8794-ec68a19f0f8c@oracle.com \
    --to=alejandro.j.jimenez@oracle.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.