From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 590F9C433EF for ; Wed, 13 Apr 2022 06:01:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232771AbiDMGDs (ORCPT ); Wed, 13 Apr 2022 02:03:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230025AbiDMGDo (ORCPT ); Wed, 13 Apr 2022 02:03:44 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E4E5252BC for ; Tue, 12 Apr 2022 23:01:23 -0700 (PDT) Received: from kwepemi100008.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4KdX0v3s8pzBsLw; Wed, 13 Apr 2022 13:57:03 +0800 (CST) Received: from kwepemm600017.china.huawei.com (7.193.23.234) by kwepemi100008.china.huawei.com (7.221.188.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 13 Apr 2022 14:01:21 +0800 Received: from [10.174.179.234] (10.174.179.234) by kwepemm600017.china.huawei.com (7.193.23.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 13 Apr 2022 14:01:20 +0800 Message-ID: <855ea9f7-5f0a-68a3-eece-6e9c1b27e90b@huawei.com> Date: Wed, 13 Apr 2022 14:01:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [RFC PATCH -next V3 1/6] x86: fix function define in copy_mc_to_user To: Kefeng Wang , Mark Rutland , James Morse , Andrew Morton , Thomas Gleixner , "Ingo Molnar" , Borislav Petkov , Robin Murphy , Dave Hansen , "Catalin Marinas" , Will Deacon , "Alexander Viro" , , "H . Peter Anvin" CC: , , , Xie XiuQi References: <20220412072552.2526871-1-tongtiangen@huawei.com> <20220412072552.2526871-2-tongtiangen@huawei.com> From: Tong Tiangen In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.234] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600017.china.huawei.com (7.193.23.234) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/4/12 19:49, Kefeng Wang 写道: > > On 2022/4/12 15:25, Tong Tiangen wrote: >> X86 has it's implementation of copy_mc_to_user but not use #define to >> declare. >> >> This may cause problems, for example, if other architectures open >> CONFIG_ARCH_HAS_COPY_MC, but want to use copy_mc_to_user() outside the >> architecture, the code add to include/linux/uaddess.h is as follows: >> >>      #ifndef copy_mc_to_user >>      static inline unsigned long __must_check >>      copy_mc_to_user(void *dst, const void *src, size_t cnt) >>      { >>         ... >>      } >>      #endif >> >> Then this definition will conflict with the implementation of X86 and >> cause >> compilation errors. > Does powerpc need this define? Oh, missing that, will do next version. >> >> Fixes: ec6347bb4339 ("x86, powerpc: Rename memcpy_mcsafe() to >> copy_mc_to_{user, kernel}()") >> Signed-off-by: Tong Tiangen >> --- >>   arch/x86/include/asm/uaccess.h | 1 + >>   1 file changed, 1 insertion(+) >> >> diff --git a/arch/x86/include/asm/uaccess.h >> b/arch/x86/include/asm/uaccess.h >> index f78e2b3501a1..e18c5f098025 100644 >> --- a/arch/x86/include/asm/uaccess.h >> +++ b/arch/x86/include/asm/uaccess.h >> @@ -415,6 +415,7 @@ copy_mc_to_kernel(void *to, const void *from, >> unsigned len); >>   unsigned long __must_check >>   copy_mc_to_user(void *to, const void *from, unsigned len); >> +#define copy_mc_to_user copy_mc_to_user >>   #endif >>   /* > . From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE6C6C433EF for ; Wed, 13 Apr 2022 06:02:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=69SHQynsiD5Bzcp1iaZqpcBKat/2oPEIsV2oWMrZ00o=; b=D0XutatROjcbJ6 e0PAKkGAVoWtewB4MD8axL9AeeHKZaMzPJSzPoWDfgLWVd/pJI0hplI5F5ZsvX4kQv9neo6dah9/Y 5+CFRYS8DsPd4tDz7VAH5OJH7Bb2Rrr0MSEnUsjm9u1x1GfkYnc4N+7F3uVEslgXFZxxcKnSa2EdM UAeM4ryR2KsX/68kkl6bPnI/PcG4JkaLtblGW1NTtXS/Y9+XmhmN6XY/fszFHgO4q13MvuCNNSQTi aMoMXOory4d4dRcePkhHEjm/5fzn6bU2C14e/TCBITjxtx+xhdSM5rXbk7pIGBx40mzsRHOCpIXmD /2YB24ad51955zcZjiCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neW4J-00GxQo-1Y; Wed, 13 Apr 2022 06:01:31 +0000 Received: from szxga03-in.huawei.com ([45.249.212.189]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neW4C-00GxLu-DQ for linux-arm-kernel@lists.infradead.org; Wed, 13 Apr 2022 06:01:26 +0000 Received: from kwepemi100008.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4KdX0v3s8pzBsLw; Wed, 13 Apr 2022 13:57:03 +0800 (CST) Received: from kwepemm600017.china.huawei.com (7.193.23.234) by kwepemi100008.china.huawei.com (7.221.188.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 13 Apr 2022 14:01:21 +0800 Received: from [10.174.179.234] (10.174.179.234) by kwepemm600017.china.huawei.com (7.193.23.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 13 Apr 2022 14:01:20 +0800 Message-ID: <855ea9f7-5f0a-68a3-eece-6e9c1b27e90b@huawei.com> Date: Wed, 13 Apr 2022 14:01:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [RFC PATCH -next V3 1/6] x86: fix function define in copy_mc_to_user To: Kefeng Wang , Mark Rutland , James Morse , Andrew Morton , Thomas Gleixner , "Ingo Molnar" , Borislav Petkov , Robin Murphy , Dave Hansen , "Catalin Marinas" , Will Deacon , "Alexander Viro" , , "H . Peter Anvin" CC: , , , Xie XiuQi References: <20220412072552.2526871-1-tongtiangen@huawei.com> <20220412072552.2526871-2-tongtiangen@huawei.com> From: Tong Tiangen In-Reply-To: X-Originating-IP: [10.174.179.234] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600017.china.huawei.com (7.193.23.234) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_230124_740331_1E8118E5 X-CRM114-Status: UNSURE ( 9.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgrlnKggMjAyMi80LzEyIDE5OjQ5LCBLZWZlbmcgV2FuZyDlhpnpgZM6Cj4gCj4gT24gMjAyMi80 LzEyIDE1OjI1LCBUb25nIFRpYW5nZW4gd3JvdGU6Cj4+IFg4NiBoYXMgaXQncyBpbXBsZW1lbnRh dGlvbiBvZiBjb3B5X21jX3RvX3VzZXIgYnV0IG5vdCB1c2UgI2RlZmluZSB0bwo+PiBkZWNsYXJl Lgo+Pgo+PiBUaGlzIG1heSBjYXVzZSBwcm9ibGVtcywgZm9yIGV4YW1wbGUsIGlmIG90aGVyIGFy Y2hpdGVjdHVyZXMgb3Blbgo+PiBDT05GSUdfQVJDSF9IQVNfQ09QWV9NQywgYnV0IHdhbnQgdG8g dXNlIGNvcHlfbWNfdG9fdXNlcigpIG91dHNpZGUgdGhlCj4+IGFyY2hpdGVjdHVyZSwgdGhlIGNv ZGUgYWRkIHRvIGluY2x1ZGUvbGludXgvdWFkZGVzcy5oIGlzIGFzIGZvbGxvd3M6Cj4+Cj4+IMKg wqDCoMKgICNpZm5kZWYgY29weV9tY190b191c2VyCj4+IMKgwqDCoMKgIHN0YXRpYyBpbmxpbmUg dW5zaWduZWQgbG9uZyBfX211c3RfY2hlY2sKPj4gwqDCoMKgwqAgY29weV9tY190b191c2VyKHZv aWQgKmRzdCwgY29uc3Qgdm9pZCAqc3JjLCBzaXplX3QgY250KQo+PiDCoMKgwqDCoCB7Cj4+IMKg wqDCoMKgwqDCoMKgIC4uLgo+PiDCoMKgwqDCoCB9Cj4+IMKgwqDCoMKgICNlbmRpZgo+Pgo+PiBU aGVuIHRoaXMgZGVmaW5pdGlvbiB3aWxsIGNvbmZsaWN0IHdpdGggdGhlIGltcGxlbWVudGF0aW9u IG9mIFg4NiBhbmQgCj4+IGNhdXNlCj4+IGNvbXBpbGF0aW9uIGVycm9ycy4KPiBEb2VzIHBvd2Vy cGMgbmVlZCB0aGlzIGRlZmluZT8KCk9oLCBtaXNzaW5nIHRoYXQsIHdpbGwgZG8gbmV4dCB2ZXJz aW9uLgo+Pgo+PiBGaXhlczogZWM2MzQ3YmI0MzM5ICgieDg2LCBwb3dlcnBjOiBSZW5hbWUgbWVt Y3B5X21jc2FmZSgpIHRvIAo+PiBjb3B5X21jX3RvX3t1c2VyLCBrZXJuZWx9KCkiKQo+PiBTaWdu ZWQtb2ZmLWJ5OiBUb25nIFRpYW5nZW4gPHRvbmd0aWFuZ2VuQGh1YXdlaS5jb20+Cj4+IC0tLQo+ PiDCoCBhcmNoL3g4Ni9pbmNsdWRlL2FzbS91YWNjZXNzLmggfCAxICsKPj4gwqAgMSBmaWxlIGNo YW5nZWQsIDEgaW5zZXJ0aW9uKCspCj4+Cj4+IGRpZmYgLS1naXQgYS9hcmNoL3g4Ni9pbmNsdWRl L2FzbS91YWNjZXNzLmggCj4+IGIvYXJjaC94ODYvaW5jbHVkZS9hc20vdWFjY2Vzcy5oCj4+IGlu ZGV4IGY3OGUyYjM1MDFhMS4uZTE4YzVmMDk4MDI1IDEwMDY0NAo+PiAtLS0gYS9hcmNoL3g4Ni9p bmNsdWRlL2FzbS91YWNjZXNzLmgKPj4gKysrIGIvYXJjaC94ODYvaW5jbHVkZS9hc20vdWFjY2Vz cy5oCj4+IEBAIC00MTUsNiArNDE1LDcgQEAgY29weV9tY190b19rZXJuZWwodm9pZCAqdG8sIGNv bnN0IHZvaWQgKmZyb20sIAo+PiB1bnNpZ25lZCBsZW4pOwo+PiDCoCB1bnNpZ25lZCBsb25nIF9f bXVzdF9jaGVjawo+PiDCoCBjb3B5X21jX3RvX3VzZXIodm9pZCAqdG8sIGNvbnN0IHZvaWQgKmZy b20sIHVuc2lnbmVkIGxlbik7Cj4+ICsjZGVmaW5lIGNvcHlfbWNfdG9fdXNlciBjb3B5X21jX3Rv X3VzZXIKPj4gwqAgI2VuZGlmCj4+IMKgIC8qCj4gLgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=