All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] cpufreq_ondemand.c: don't use _WORK_NAR
Date: Mon, 19 Feb 2007 11:33:47 +0000	[thread overview]
Message-ID: <8561.1171884827@redhat.com> (raw)
In-Reply-To: <20070218214407.GA4229@tv-sign.ru>

Oleg Nesterov <oleg@tv-sign.ru> wrote:

> Looks like dbs_timer() is very careful wrt per_cpu(cpu_dbs_info),
> and it doesn't need the help of WORK_STRUCT_NOAUTOREL.

Actually, I think my problem with this was dbs_info->sample_type, but reading
it again, I'm not sure that it's actually a problem as the work function will
probably not ever be executing on two or more CPUs simultaneously because of
the deferral time involved.

So, your patch is probably fair enough.  Certainly, deletion isn't a problem.

Acked-By: David Howells <dhowells@redhat.com>

      reply	other threads:[~2007-02-19 11:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-18 21:44 [PATCH 2/3] cpufreq_ondemand.c: don't use _WORK_NAR Oleg Nesterov
2007-02-19 11:33 ` David Howells [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8561.1171884827@redhat.com \
    --to=dhowells@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=jun.nakajima@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.